Opened 2 months ago
Closed 8 weeks ago
#49163 closed defect (bug) (fixed)
Some typing mistakes in \wp-admin\includes\class-pclzip.php
Reported by: | passoniate | Owned by: | SergeyBiryukov |
---|---|---|---|
Milestone: | 5.4 | Priority: | normal |
Severity: | normal | Version: | trunk |
Component: | Filesystem API | Keywords: | has-patch |
Focuses: | docs | Cc: |
Description
Some typing mistakes in \wp-admin\includes\class-pclzip.php
Attachments (1)
Change History (3)
#1
@
2 months ago
- Component changed from General to Filesystem API
- Milestone changed from Awaiting Review to 5.4
- Owner set to SergeyBiryukov
- Status changed from new to reviewing
Thanks for the patch!
Per comment:3:ticket:38464, class-pclzip.php
used to be treated as an external library and was excluded from any documentation fixes. We only modify third-party libraries when it's needed to fix a bug, like in [46105/trunk/src/wp-admin/includes/class-pclzip.php] or [38101/trunk/src/wp-admin/includes/class-pclzip.php].
That said, looking at the commit history, there were some whitespace changes in [12042/trunk/wp-admin/includes/class-pclzip.php] and documentation additions in [8645/trunk/wp-admin/includes/class-pclzip.php].
Given that the upstream library hasn't been updated in 10 years since the last time it was merged, I think it's safe to treat it as "adopted" rather than external, same as jquery.imgareaselect.js or class-IXR.php, and make these fixes.
patch