Make WordPress Core

Keyboard Shortcuts | Hide comment threads
Dan Farrow 8:37 am on September 14, 2021

CSS Chat Summary: 09 September 2021

The meeting took place here on Slack. @wazeter facilitated and @danfarrow wrote up these notes.

Announcements & Housekeeping

CSS Custom Properties (#49930)

  • @dryanpress has some files ready to submit, @wazeter is finishing updating media-views.css and @danfarrow posted a draft PR for forms.css
  • deprecated-media.css is the only remaining unclaimed file
  • @ryelle has been working on reviewing & merging PRs as they come in. She is planning to open a new base branch, once more PRs are merged, to make it cleaner for the next stages
  • @danfarrow asked about the PR review process. @ryelle said she’s been trimming down custom properties to existing ones where possible, and testing in the browser
  • @danfarrow asked if creating a custom-properties aliasing existing custom-property is ever useful. @ryelle responded that they might be if there could be a requirement to style a component differently, but the subject is open to discussion. @dryanpress & @wazeter expressed the view that more aliases give users more granular control outside of the cascade
  • There was general agreement that this project is a good opportunity to clean up things like the inheritance structure, minor colour variations etc.

Open Floor / CSS Link Share

Thanks everybody!

#summary

Jb Audras 10:13 pm on September 13, 2021

A Week in Core – September 13, 2021

Welcome back to a new issue of Week in Core. Let’s take a look at what changed on Trac between September 6 and September 13, 2021.

  • 37 commits
  • 30 contributors
  • 40 tickets created
  • 4 tickets reopened
  • 25 tickets closed

As expected, WordPress 5.8.1 was released last week! Props to @desrosj and @circlecube for leading this new point release 🌟

The Core team is currently working on the next point (5.8.2) and major (5.9) releases 🛠

Ticket numbers are based on the Trac timeline for the period above. The following is a summary of commits, organized by component and/or focus.

Code changes

Administration

  • Accessibility: Improve aria-label on network admin Themes screen – #24442

Build/Test Tools

  • Fix CI for running tests on PHP 8.1 – #53945
  • Add more invalid IP test cases and @covers to Tests_Functions_Anonymization – #53363
  • Add tests for wpdb::_real_escape() – #53363
  • Fix “null to non-nullable” deprecation notice in Tests_Admin_IncludesPlugin::test_get_plugin_files_folder() – #53635

Bundled Themes

  • Twenty Eleven: Set a fixed height for search form when header image is added – #40398

Code Modernization

  • Fix “passing null to non-nullable” deprecation in wpdb::_real_escape() – #53635
  • Fix “passing null to non-nullable” deprecation notice in WP_Comment_Query::get_comment_ids() – #53635
  • Fix “passing null to non-nullable” deprecation notices in WP_Http::normalize_cookies() – #53635
  • Fix last parameter name mismatches for parent/child classes in Walker::start_el() – #51553
  • Fix null to non-nullable deprecation in term_exists() – #53635
  • Fix null to non-nullable deprecation in wp_privacy_anonymize_ip() – #53635
  • Fix null to non-nullable deprecations in WP_Meta_Query::get_sql_for_clause() – #53635
  • Fix parameter name mismatch with parent in WP_Customize_Custom_CSS_Setting::validate() – #51553
  • Fix parameter name mismatches for parent/child classes in WP_Customize_Setting::sanitize() – #51553
  • Fix parameter name mismatches for parent/child classes in WP_Customize_Setting::update() – #51553
  • Fix parameter name mismatches for parent/child classes in WP_Image_Editor::save() – #51553
  • Fix parameter name mismatches for parent/child classes in WP_List_Table::column_cb() – #51553
  • Fix parameter name mismatches for parent/child classes in WP_List_Table::handle_row_actions() – #51553
  • Fix parameter name mismatches for parent/child classes in WP_REST_Controller::prepare_item_for_response() – #51553
  • Fix parameter name mismatches for parent/child classes in WP_Sitemaps_Provider::get_max_num_pages() – #51553
  • Fix parameter name mismatches for parent/child classes in WP_Sitemaps_Provider::get_url_list() – #51553
  • Fix parameter name mismatches for parent/child classes in WP_Upgrader_Skin::error() – #51553
  • Fix parameter name mismatches for parent/child classes in WP_Widget::update() – #51553
  • Fix reserved keyword and parameter name mismatches for parent/child classes in WP_Upgrader_Skin::feedback() – #51553
  • Fix reserved keyword and parameter name mismatches for parent/child classes in Walker::end_el() – #51553
  • Fix reserved keyword and parameter name mismatches for parent/child classes in Walker::start_el() – #51553
  • Improve @since message in WP_List_Table::column_default() – #51553

Documentation

  • Correct documentation for the in_plugin_update_message-{$file} filter – #40006

Editor

  • Revert [51748] and [51649]. They intorduced a bug where wp.editor may be replaced with wp.oldEditor in certain cases – #53762
  • Editor: fix the replacement of wp.editor with wp.oldEditor in the inline script outputted when enqueueing the old editor – #53762

External Libraries

  • Update jQuery UI to 1.13.0-rc2 – #52163

General

  • Only use _jsonp_wp_die_handler() for JSONP REST API requests

Site Health

  • Add Intl to the list of recommended PHP extensions – #52654
  • Site Health: Move the Imagick entry higher in the list of recommended PHP extensions – #52654

Users

  • Introduce a meta_input argument for wp_insert_user() – #41950

Widgets

Props

Thanks to the 30 people who contributed to WordPress Core on Trac last week: @hellofromTonya (26), @jrf (26), @azaozz (19), @desrosj (18), @johnbillion (15), @sergeybiryukov (15), @audrasjb (2), @david.binda (2), @sabernhardt (2), @Clorith (2), @Soean (1), @davidmosterd (1), @BinaryKitten (1), @donmhico (1), @peterwilsoncc (1), @mdawaffe (1), @get_dave (1), @grantmkin (1), @fullofcaffeine (1), @lukecavanagh (1), @josklever (1), @mukesh27 (1), @zieladam (1), @andraganescu (1), @fedepia (1), @zodiac1978 (1), @mgol (1), @JavierCasares (1), @zeo (1), and @SergeyBiryukov (1).

Congrats and welcome to our new contributor of the week: @josklever ♥️

Core committers: @hellofromtonya (26), @sergeybiryukov (6), @azaozz (3), and @johnbillion (2).

#5-8-2, #5-9, #core, #week-in-core

Francesca Marano 9:32 pm on September 13, 2021

Upgrade/Install component meeting agenda for September 14, 2021

The next meeting is scheduled on Tuesday, September 14, 2021 at 05:00 PM UTC and will take place on the #core-auto-updates Slack channel.

The aim of the chat is to check the status of the [Feature project] Updates on updating the updaters and scrub tickets for inclusion in WordPress 5.9

Got something to propose for the agenda? Please leave a comment below.

See you there!

#core-auto-updates, #updater, #upgrade-install

Francesca Marano 7:59 am on September 9, 2021

Dev chat summary, September 8, 2021

@audrasjb led the chat on this agenda. You can also read the Slack logs.

Highlighted blog posts

The attendees did not add comments to the posts highlighted in the agenda.

Worth mentioning

Thanks to the 61 contributors of the past week, including 7 new contributors! Kudos to the 7 core committers of the week, too

A Week in Core – September 6, 2021

Announcements

  • WordPress 5.8.1 release team ran into an issue with GitHub that required a chunk of manual work. WordPress 5.8.1 went out few hours after the chat.
  • The Polyglots Team is currently organizing the 2021 edition of the WordPress Translation Days.
  • Work on the jquery upgrade is rolling on now, @azaozz is working on the PR

Component maintainers

Build/Test Tools

Work has continued on adding missing @covers tags to unit tests for more accurate coverage. See ticket #39265 for more details.

General

Work has continued on:

  • #51553 – Fixing parameter name mismatches for parent/child classes for PHP 8 named parameter support.
  • #53635 – Making various compatibility fixes for PHP 8.1. Thanks @jrf and @hellofromtonya! 

Upgrade/Install

Open Floor

The attendees briefly discussed #53784 – Additional review welcome.

@annezazu reminded everyone about the FSE Program Exploration: Help with the future of Block Theme Switching

#5-8-x, #5-9, #dev-chat, #summary

annezazu 2:56 am on September 9, 2021

Core Editor Improvement: Cascading impact of improvements to featured images

When a new feature is added, it’s easy to see what the feature does right now rather than the many things it allows you to do, particularly when combined with other tools. This is especially true as design tools continue to evolve! This post offers a quick dive into how improvements to the Featured Image block lead to more possibilities for content creation. 

Greater control of posts layout

Thanks to some recent changes to the Featured Image block, the Query Loop block just got even more powerful. As a reminder, the Query Loop block is an advanced block that allows you to display posts based on various parameters and was released in WordPress 5.8. Within the Query Loop block, different blocks, like the Featured Image block, can be placed within it to show the Featured Images for each post listed. While you’ve been able to control the general placement of the Featured Image, until Gutenberg 11.3, you couldn’t control the basics of the resulting image. This came up a few times during testing with the FSE Outreach Program as a pain point with folks wanting deeper customization options. Now, you can control the sizing and scale of the image to your liking opening up the beginnings of a new world of layout options!

Video showing the new Featured Image Block options within the Query Loop block.

More options when creating templates

This change also impacts anyone using the Template Editor as you can now customize how the Featured Image shows up in a template you created. This is just a start too with more size tooling planned for the Featured Image block. Most recently too, the ability to add duotone filters to spruce up your images with endless color options was included in Gutenberg 11.4. Just like with the Query Loop block example above, this allows you to add a Featured Image block with a duotone filter added and then apply that to any post or page you’d like so all posts have the same duotone shading:

Video showing the new Featured Image Block options within the Template Editor.

Thank you @shaunandrews for the design assist & @kellychoffman for help with the copy.

#core-editor, #core-editor-improvement

Andrei Draganescu 8:34 pm on September 8, 2021

Editor chat summary: 8 September, 2021

This post summarizes the weekly editor chat meeting (agenda here) held in Slack. Moderated by @andraganescu.

Announcements

Gutenberg 11.5 RC launched today (Sep 8)

@mikeschroder released Gutenberg 11.5 RC. You can take it for a spin from here.

Important resources for the incoming period of time

@priethor added some details about where we should look for guidance around the incoming updates to WordPress in light of the 5.9 release:

There will be an upcoming What’s Next in Gutenberg post based on the preliminary road. It’s worth noting the “What’s Next” intent is to highlight issues where contributors can help, whereas the high-level plan is defined in the preliminary road post.

Key Project Updates

Navigation Editor

@get_dave shared this week’s update:

Mobile

From mobile, @hypest offered the updates:

 Shipped

  • Block picker search.
  • Inline previews for YouTube and Twitter embeds.
  • Alignment options for embeds.
  • New experimental Gallery block.

In Progress

  • Embed block.
  • GSS Font size, line height, colors.

Components

@mciampini shared some updates from the folks working on the components package:

Shipping:

Notable fixes:

In Progress:

Task Coordination

Feel free to add items to this post if you weren’t able to make the meeting.

@ntsekouras

@joen

@mamaduka

  • Updated documentation to replace withSelect HOC references with useSelect.
  • Worked with Riad to fix code data issue with include query parameter.
  • Checked on approved PRs, merged some, and left comments on others to see if authors have time to address the feedback. (Sorry if you received more notifications than usual)

I would appreciate feedback on the following PRs:

@get_dave

@jorgefilipecosta

  • During the last week I updated the design of the mosaic view, I iterated on the engine to allow blocks to be aware of global styles, I proposed the PR to enhance the design of the new color picker and I did multiple PR reviews. I also started the effort to replace tinycolor with colord.
  • For the next week I place on continuing the color library replacement, Iterate on the color picker design and pick another task related to the global styles new design.

@zieladam

@annezazu

@mciampini I plan on:

@oandregal

  • I’ve been working on enabling the global stylesheet for all themes and other minor improvements. Prepared a PR to make sure themes with theme.json load the styles fine in the customizer as well as the theme directory.
  • In the area of alignments: landed a PR that makes the wide control only available if the theme provides a wide size and prepared another for fixing floats (left, center, right) for blocks that are not part of a container.

Open Floor

Will PHP minimum required version change in WordPress 5.9?

@anil (Anil Sardemann) asked about the future min. PHP requirements of 5.9. @hellofromtonya explained that there are no plans to change the minimum supported PHP version in WordPress 5.9 since still more than 5% of WordPress runs on PHP 5.6.

Help with the future of Block Theme Switching

@annezazu brought more attention to the FSE Program Exploration: Help with the future of Block Theme Switching. This is a very new approach in that it’s all about gathering insights to help shape the potential designs rather than testing a specific flow. It’s neat to be able to be involved this early in solving a problem. Check it out, share your thoughts, and get creative!

Help needed with review

@faizan asked for a review on his patch on Ticket 50074

#core-editor, #core-editor-summary, #summary, #themereview

Jb Audras 11:08 pm on September 7, 2021

Dev Chat Agenda for Sept 8, 2021

Here is the agenda for this week’s developer meeting to occur at Wednesday, September 8, 2021 at 08:00 PM UTC.

Blog Post Highlights and announcements

Bringing to your attention some interesting reads and some call for feedback and/or volunteers:

Components check-in and status updates

  • Check-in with each component for status updates.
  • Poll for components that need assistance.

Open Floor

Do you have something to propose for the agenda, or a specific item relevant to the usual agenda items above?

Please leave a comment, and say whether or not you’ll be in the chat, so the group can either give you the floor or bring up your topic for you accordingly.

This meeting happens in the #core channel. To join the meeting, you’ll need an account on the Making WordPress Slack.

#5-8-1, #5-9, #agenda, #core, #dev-chat

fictiont 12:34 pm on September 8, 2021

The proposal for Open Floor is to review this ticket
http://wayback.fauppsala.se:80/wayback/20210914150153/https://core.trac.wordpress.org/ticket/53784
I’ve sent a pull request there which solves the privacy issue

Jb Audras 12:43 pm on September 8, 2021

Thank you @fictiont, noted!

fictiont 12:45 pm on September 8, 2021

I will try to be in the chat for questions, though, but not guarantee 🙂
Anyway, it feels good if we address this problem since there are a lot of solutions around to enumerate WP users emails based on that privacy issue.

F.e. here: http://wayback.fauppsala.se:80/wayback/20210914150153/https://www.gosecure.net/blog/2021/03/16/6-ways-to-enumerate-wordpress-users/

annezazu 3:02 pm on September 8, 2021

Quick open floor item and/or blog post highlight (trust you to decide):

Please check out the FSE Program Exploration: Help with the future of Block Theme Switching. This is a very new approach in that it’s all about gathering insights to help shape the potential designs rather than testing a specific flow. It’s neat to be able to be involved this early in solving a problem and I really encourage folks to check it out, share your thoughts, and get creative!

Francesca Marano 8:05 pm on September 7, 2021

Upgrade/Install Meeting Notes, September 7

Quiet but productive chat, only two attendees, @afragen and @francina, but here is a quick recap 🙂 Slack logs.

#51857

@afragen stress tested it but didn’t find any concerning blockers. I asked @sergeybiryukov about commit: he is going to do another round of code review tomorrow, September 8, and if everything looks good, it will be committed. The solution addresses Outcome 1 and 2 of the initial feature proposal.

Outcome 3 – Have managed updates (database migrations)

This is going into the icebox momentarily. It needs a new API to work. If anyone is interested in picking it up, join our meetings on Tuesdays, at Tuesday, September 7, 2021 at 05:00 PM UTC.

Outcome 4 – Create a unified JSON convention for requirements and dependencies.

This nine-year-old issue was revived. Worth reading through it all.

Here is @afragen TL;DR

  1. Any plugin that requires a dependency should degrade gracefully if that dependency is not present.
  2. Dependencies should have notices to install and later activate the dependency.
  3. Some notification of which plugin is a dependency of what other plugin.

There is also the potential for abuse, with plugins reporting dependencies that aren’t really dependencies.

Andy also suggested making a proof of concept plugin, instead of creating a core patch.

What say you?

Do you want to add to the conversation? Please comment on the Trac ticket (beware, comments in GH will be shown in Trac, but not the other way around, so please use Trac, thank you 🙏). We are in the “feedback, validate, outreach, test, inform, reply to questions” loop stage. Join us!

See you next week 👋

#core-auto-updates, #updater, #upgrade-install

Francesca Marano 1:46 pm on September 7, 2021

Upgrade/Install component meeting agenda for September 07, 2021

The next meeting is scheduled on Tuesday, September 7, 2021 at 05:00 PM UTC and will take place on #core-auto-updates Slack channel.

The aim of the chat is to check the status of the [Feature project] Updates on updating the updaters.

Got something to propose for the agenda? Please leave a comment below.

See you later!

#core-auto-updates, #updater, #upgrade-install