Opened 12 months ago
Closed 9 months ago
#45155 closed defect (bug) (fixed)
When no menu exists the verbiage is misleading and provides an unnecessary link
Reported by: | garrett-eclipse | Owned by: | pento |
---|---|---|---|
Milestone: | 5.1 | Priority: | normal |
Severity: | normal | Version: | 4.9.8 |
Component: | Menus | Keywords: | has-patch commit |
Focuses: | Cc: | ||
PR Number: |
Description
Hello,
On a fresh install which doesn't have menus setup yet, when you go to the Appearance > Menus you'll get a form to Create Menu but before that there's misleading verbiage and a link;
"Edit you menu below, or <create a new menu>"
*I used <> to denote the link text.
This verbiage is misleading as there's no menu below to edit. As well the create a new menu
link just links back to the current page so isn't useful.
Suggesting verbiage;
'Create your first menu below.'
The other option is to remove that message box as it's not really needed.
Cheers
Attachments (6)
Change History (13)
#1
@
12 months ago
- Keywords has-patch needs-refresh dev-feedback ui-feedback ux-feedback needs-testing added
I've provided two patches for this to illustrate the two options;
45155.nomessage.diff - Fully suppresses the message section when there's no menus.
45155.firstmenumessage.diff - Replaces the invalid verbiage with new verbiage and new screen reader verbiage.
#2
@
12 months ago
- Milestone changed from Awaiting Review to 5.1
- Owner set to SergeyBiryukov
- Status changed from new to reviewing
I'd go with 45155.firstmenumessage.diff.
#4
@
10 months ago
- Keywords needs-refresh dev-feedback ui-feedback ux-feedback needs-testing removed
Hi @SergeyBiryukov I refreshed this patch after re-applying and testing. I found the verbiage could be more clear still.
I ended up with;
'Create your first menu below.'
Screen Reader Text - 'Fill in the Menu Name and click the Create Menu button to create your first menu.'
Thanks for your input earlier, I feel this is ready to commit if you want to take another look.
Misleading message when no menus exist