Opened 6 months ago
Last modified 3 weeks ago
#47019 reviewing defect (bug)
Twenty Sixteen: Text color setting in pullquote block not applied
Reported by: | kokkieh | Owned by: | SergeyBiryukov |
---|---|---|---|
Milestone: | 5.4 | Priority: | normal |
Severity: | normal | Version: | 5.0 |
Component: | Bundled Theme | Keywords: | good-first-bug has-patch needs-testing |
Focuses: | Cc: | ||
PR Number: |
Description
Text color settings in the pull quote block are not being applied.
To replicate:
- With Twenty Sixteen active, create a new post in the block editor
- Add a Pullquote block
- Add some text and try adjusting the color settings
Result:
The border color is applied, but the text color is not applied in either the editor or the published post.
The source code for the post does show a class for the applied color:
<figure class="wp-block-pullquote" style="border-color:#ff675f"><blockquote class="has-text-color has-bright-blue-color"><p>This is a quote</p><cite>by me<br></cite></blockquote></figure>
But looking in the inspector it seems the color is instead being applied from the blocks.css
file, line 170:
.wp-block-pullquote p { color: #686868; font-size: 19px; font-size: 1.1875rem; }
Reported by a WordPress.com user in the forums, but confirmed on a self-hosted installation as well. Also tested with no plugins active at all to rule out possible conflicts.
Attachments (2)
Change History (17)
#1
@
6 months ago
- Keywords needs-patch good-first-bug added
- Milestone changed from Awaiting Review to 5.3
- Version changed from 5.1.1 to 5.0
#4
@
6 months ago
- Keywords 2nd-opinion added
Hello guys!
Tested both 47019 and 47019.2.
47019 looks good to me; it seems to solve the issue on both the editor and frontend. On the other hand, 47019.2 doesn't seem to work well.
First time participating/contributing so I hope I'm doing it correctly! Looking forward to help out more.
This ticket was mentioned in Slack in #core by sergey. View the logs.
5 months ago
#6
@
5 months ago
Hi all.
I also tested the 47019 patch and I confirm that it works on my freshly installed latest build.
This is my first contribution. Hope it's helpful.
This ticket was mentioned in Slack in #core by desrosj. View the logs.
5 months ago
This ticket was mentioned in Slack in #core by marybaum. View the logs.
4 weeks ago
#12
@
4 weeks ago
- Keywords commit added; needs-testing removed
The most recent patch applies cleanly to trunk
, and the testing appears to confirm a resolution. Marking this one for commit
.
This ticket was mentioned in Slack in #core by ianbelanger. View the logs.
3 weeks ago
#14
@
3 weeks ago
- Milestone changed from 5.3 to 5.4
I might be doing something wrong, but for some reason 47019.diff did not resolve the issue in my testing. I did, however, notice that other bundled themes appear to have the same issue.
Moving to 5.4 to handle this consistently across all bundled themes.
Thanks, @kokkieh! I am also able to reproduce this. Looks like the text color has never worked correctly in Twenty Sixeteen.