Update WordPress packages with fixes targeted for 5.3 RC3

[youknowriad]

The list of included fixes is:

​https://github.com/WordPress/gutenberg/pull/18108
​https://github.com/WordPress/gutenberg/pull/18051
​https://github.com/WordPress/gutenberg/pull/18106
​https://github.com/WordPress/gutenberg/pull/18102

[desrosj]

@youknowriad This looks good to me. Feel free to commit to trunk. Just needs an additional sign-off before backporting!

[youknowriad]

In 46606:

Block Editor: Bug fixes targetted for WordPress 5.3 RC3.

The list of included fixes is:

• ​https://github.com/WordPress/gutenberg/pull/18108
• ​https://github.com/WordPress/gutenberg/pull/18051
• ​https://github.com/WordPress/gutenberg/pull/18106
• ​https://github.com/WordPress/gutenberg/pull/18102

Updated packages:

• @wordpress/api-fetch@3.6.4
• @wordpress/block-directory@1.0.4
• @wordpress/block-library@2.9.4
• @wordpress/core-data@2.7.4
• @wordpress/data-controls@1.3.4
• @wordpress/edit-post@3.8.4
• @wordpress/editor@9.7.4
• @wordpress/list-reusable-blocks@1.8.4
• @wordpress/media-utils@1.2.4
• @wordpress/server-side-render@1.3.4

Props desrosj.
See #48447.

[SergeyBiryukov]

In 46607:

Docs: Restore correct placement for duplicate hook reference in render_block_core_latest_comments().

Previously fixed in [46604], accidentally reverted in [46606].

See #48447, #48303.

[youknowriad]

@SergeyBiryukov The problem is that these files are automatically synced from the packages. everytime someone will perform npm install && npm run build it will be reverted. We should fix these in Gutenberg instead.

[azaozz]

Replying to youknowriad:

The problem is that these files are automatically synced...

Right. Seems it would be good to make few "readability improvements" to latest-comments.php. Added 48447-readability-fixes.diff as an example here, will open a low-priority issue for Gutenberg too.

Generally having nested function calls with each param on its own line adds a lot of "vertical bloat" and "indentation bloat" :)

These can be avoided by making the code a bit more "wordy" but the result is quite easier to read. Also if () statements usually signify a new "block" with its own indentation. Usually better to have empty lines around.

Also, for better readability long ternary operators should probably be if () {} ... else {} blocks instead (especially when returning from them).

The six level deep nested array in register_block_core_latest_comments() is also quite "problematic" with some vertical and indentation bloat and uneven/weird white spaces but that's a bug in WPCS that needs fixing upstream (the issue has been open there for over 6 months now!).

[azaozz]

Wooow, doing npm install:

updated 10 packages and audited 978269 packages in 22.037s
found 0 vulnerabilities

Didn't realize we use nearly 1 million packages!!! :)

[46606] looks good here, +1 to merge to 5.3.

[youknowriad]

These changes all look decent but IMO we should treat these files as "vendors" and not touch them at all in Core.

[azaozz]

Replying to youknowriad:

Right. Any changes would need to be made upstream (for 5.4). Opened ​https://github.com/WordPress/gutenberg/issues/18143.

[gziolo]

In 46611:

Block Editor: Bug fixes targetted for WordPress 5.3 RC3.

The list of included fixes is:
​https://github.com/WordPress/gutenberg/pull/18108
​https://github.com/WordPress/gutenberg/pull/18051
​https://github.com/WordPress/gutenberg/pull/18106
​https://github.com/WordPress/gutenberg/pull/18102
Updated packages:
@wordpress/api-fetch@3.6.4
@wordpress/block-directory@1.0.4
@wordpress/block-library@2.9.4
@wordpress/core-data@2.7.4
@wordpress/data-controls@1.3.4
@wordpress/edit-post@3.8.4
@wordpress/editor@9.7.4
@wordpress/list-reusable-blocks@1.8.4
@wordpress/media-utils@1.2.4
@wordpress/server-side-render@1.3.4

Props desrosj, youknowriad.
Merges [{46606}] to the 5.3 branch.
See #48447.