Gallery widget preview incorrectly updated after one image gets deleted

[afercia]

To reproduce:

• go in the widgets screen
• create a gallery widget with 7 images and save
• the preview displays 6 images, the last image has an overlay with text "+2"

• go in the media library
• delete one of the images used for the gallery
• go back in the widgets screen and open the gallery widget to see the preview
• the preview displays 5 images, the last image has an overlay with text "+2"

Since there's room available for the 6th image, the image should be displayed and the overlay with text "+2" shouldn't be there. Same happens in the Customizer.

Note: Clicking "Edit Gallery" to make the media modal open and then clicking "Update gallery" rebuilds the preview "fixing" the issue.

[janak007]

I have added a patch to fix this issue. I have eliminated media item id which is causing issue.

[westonruter]

It would be better to use _.filter. See 43139.2.diff​ for an untested patch.

[mrasharirfan]

Hi,

I just tested the issue by following the instructions in the description of the ticket and regenerated the bug.

Related screenshot:

After that, I applied the fix for testing. Then tried to reproduce the issue again and the bug was gone.

Related screenshot:

Hope this helps!

Peace ✌️

[pento]

In 44661:

Widgets: Fix Gallery Widget preview after an image is deleted.

The Gallery Widget incorrectly tried to include the deleted image in the preview.

Props westonruter, janak007, afercia, mrasharirfan.
Fixes #43139.