Admin email verification screen displayed on upgrade even though installed minutes earlier

[garrett-eclipse]

Hello,

I keep coming across this in trunk when I'm testing using Local by Flywheel and the Beta Testing plugin, or well any clean install of WP < 5.3 and then upgrading to trunk.

It seems the screen is triggered when upgrading to 5.3 (or trunk as we're in 5.3 RC1) but doesn't take into account the current lifetime of the website so feels it gets triggered basically upon install.

I'm wondering if we can account for the current lifetime of the install and only trigger the screen on upgrade to 5.3 if the install is older than the standard timeframe for the recurrence of that screen.

I hope that make sense, to reproduce;

1. Install 5.2.x
2. Install Beta Tester plugin
3. Switch to bleeding edge nightlies
4. Upgrade to trunk (currently 5.3RC1)

You'll find the screen is displayed on upgrade.

In this edge case it's most likely their email is valid as they just entered it.

Thanks

[johnbillion]

I've noticed something like this too but I haven't pinpointed when the message appears.

Moving to 5.3 for visibility.

[azaozz]

This is the expected behavior with these steps. It is meant to show the email verification on updating to 5.3 from any previous version.

It is a good idea to (somehow) detect when WordPress was installed and skip the verification on update to 5.3 when the install date is less than six months ago. Will look into adding that but unsure if it will make it in 5.3-RC2 (scheduled for tomorrow).

[desrosj]

Personally, I think that this is a really rare edge case.

The person must either:

• Install 5.2.4 sometime between now and November 12th (slated release date).
• Spin up a new install to test 5.3.

Also, though in most situations the site email would be correct after installing, there are scenarios where seeing the verification page the first time you log in to your new site would be helpful.

For example, a hosting provider that uses your account email as the site email when creating a new install. In some cases, the email that is used is not obvious, and you would not want your account email to be used there.

[azaozz]

Replying to desrosj:

Also, though in most situations the site email would be correct after installing, there are scenarios where seeing the verification page the first time you log in to your new site would be helpful.

For example, a hosting provider that uses your account email as the site email when creating a new install. In some cases, the email that is used is not obvious, and you would not want your account email to be used there.

Ah, didn't think about this, good catch :)

Then the choice here is between a minor inconvenience of being asked to click a button to confirm the admin email again if the user has installed WP shortly before updating to 5.3 vs. an opportunity to change the email when it was set automatically.

Thinking the second case is more important and the current behavior shouldn't change.

[garrett-eclipse]

Thanks @azaozz & @desrosj for the feedback and review. Closing this out and I agree with your points there the benefit to those auto-install users trumps the nuisance to new users. Cheers