Opened 3 years ago
Closed 13 months ago
#40647 closed enhancement (fixed)
Introduce `ms-site.php` and `ms-network.php` files
Reported by: | flixos90 | Owned by: | flixos90 |
---|---|---|---|
Milestone: | 5.1 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Networks and Sites | Keywords: | has-patch ms-roadmap |
Focuses: | multisite | Cc: | |
PR Number: |
Description
Let's introduce ms-site.php
and ms-network.php
files that should contain the core API functions for the site and network APIs respectively. All of them are currently dropped in ms-blogs.php
, and as we're starting to introduce more functions for those APIs, the file gets more cluttered.
This ticket is a subticket for #40623.
Attachments (3)
Change History (14)
This ticket was mentioned in Slack in #core by flixos90. View the logs.
3 years ago
This ticket was mentioned in Slack in #core-multisite by jeremyfelt. View the logs.
3 years ago
#4
@
3 years ago
- Milestone changed from Awaiting Review to Future Release
Let's do this in the same release we get the new sites C(R)UD API in (see #40364).
We need to find a good point to break as few patches as possible.
#5
@
3 years ago
- Keywords ms-roadmap added
These tickets belong to our planned roadmap (a few of them not per final decision), so flagging with a keyword for better overview.
This ticket was mentioned in Slack in #core-multisite by jeremyfelt. View the logs.
3 years ago
This ticket was mentioned in Slack in #core-multisite by flixos90. View the logs.
2 years ago
#8
@
16 months ago
- Keywords changed from has-patch, ms-roadmap to has-patch ms-roadmap
- Milestone changed from Future Release to 5.1
#10
@
13 months ago
40647.3.diff applies against latest trunk and accounts for new functions introduced.
This is exactly the same patch that I previously uploaded on #40623. It introduces the
ms-site.php
andms-network.php
files and moves the basic functions for their APIs in there. Let's continue work on it here.We discussed that briefly during office-hours yesterday, but as a reminder the question: Do we really need to load those two files from
ms-blogs.php
or can we load them fromwp-settings.php
? The latter would certainly be nicer, but not sure about BC with someone loadingms-blogs.php
manually.