Opened 11 days ago
Closed 4 days ago
#48386 closed task (blessed) (fixed)
Update Twenty Twenty with Latest Changes for RC 2
Reported by: | ianbelanger | Owned by: | ianbelanger |
---|---|---|---|
Milestone: | 5.3 | Priority: | normal |
Severity: | normal | Version: | trunk |
Component: | Bundled Theme | Keywords: | has-patch |
Focuses: | Cc: | ||
PR Number: |
Description
This is the reference ticket for the Twenty Twenty theme which is currently under development, ready for 5.3 RC 2.
Initial development is happening on GitHub: https://github.com/WordPress/twentytwenty
Read the announcement post: https://make.wordpress.org/core/2019/09/06/introducing-twenty-twenty/
Attachments (11)
Change History (21)
This ticket was mentioned in Slack in #core by david.baumwald. View the logs.
11 days ago
#4
@
11 days ago
- Keywords i18n-change added
48386.diff looks good to me.
There is one string change, so I am tagging as i18n-change
.
I did notice that in the starter content, there are two images not loading. They do not appear to be in the assets/images
folder on GitHub.
#6
@
10 days ago
- Keywords commit dev-feedback added
- Version set to trunk
This looks good to me. I'd love one more set of committer eyes.
#7
@
10 days ago
- Keywords dev-reviewed added; dev-feedback removed
48386.1.diff looks good to me as well.
#9
@
6 days ago
- Keywords needs-patch added; i18n-change has-patch commit dev-reviewed removed
- Resolution fixed deleted
- Status changed from closed to reopened
During latest accessibility bug-scrub we discovered a bug related to the comments "Reply" link that makes the comments pages barely usable for all users.
WordPress is still in RC 2 and the fix will need to be synced from the GitHub repo to core, so I'm reopening this ticket instead of creating a new one.
The bug is detailed on https://github.com/WordPress/twentytwenty/issues/927
The fix appears to be super simple and I'd strongly recommend to fix it before final release. I do realize it's RC 2 time but seems to me Twenty Twenty can't be released with this bug unsolved.
I guess this implies a quick RC 3 will be necessary.
#10
@
4 days ago
- Keywords has-patch added; needs-patch removed
- Resolution set to fixed
- Status changed from reopened to closed
The aforementioned bug https://github.com/WordPress/twentytwenty/issues/927 has been resolved and will be fixed in RC 3
. Closing this in favor of a new ticket for RC 3
There are 8 images that need to be added via
svn add
for the starter content. I will upload them here.