WordPress.org

Make WordPress Core

Opened 7 weeks ago

Closed 3 weeks ago

#49317 closed defect (bug) (fixed)

Coding Standard : src/js/_enqueues/wp/media/editor.js

Reported by: ankitmaru Owned by: SergeyBiryukov
Milestone: 5.4 Priority: normal
Severity: normal Version: 5.3.2
Component: Media Keywords: has-patch
Focuses: javascript, coding-standards Cc:

Description

Javascript Coding Standard : src/js/_enqueues/wp/media/editor.js

Attachments (1)

Javascript_Coding_Standards.patch​ (1.7 KB) - added by ankitmaru 7 weeks ago.

Download all attachments as: .zip

Change History (5)

@ankitmaru
7 weeks ago

#2 @SergeyBiryukov
6 weeks ago

  • Milestone changed from Awaiting Review to 5.4
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#3 @audrasjb
3 weeks ago

Hi there,

With Beta 3 approaching, we'll need a decision and a commit action very soon.
For Component maintainers: if you don't feel the current patch is ready to land in WP 5.4 in the next few day, it's could be better to move it to 5.5. We're leaving it in the milestone for now.

#4 @SergeyBiryukov
3 weeks ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 47349:

Coding Standards: Add missing braces to if conditions and use strict comparison in js/_enqueues/wp/media/editor.js.

Props ankitmaru.
Fixes #49317.

Note: See TracTickets for help on using tickets.