WordPress.org

Make WordPress Core

Opened 6 days ago

Last modified 6 days ago

#49690 new defect (bug)

Reconsider ja_JP usage in Tests_DB::test_locale_floats()

Reported by: SergeyBiryukov Owned by:
Milestone: 5.5 Priority: normal
Severity: normal Version: 5.1
Component: Database Keywords:
Focuses: Cc:

Description

Background: [746/tests], [747/tests], #19861.

Tests_DB::test_locale_floats() ensures that floats formatted as 0,700 get sanitized properly by wpdb.

This is relevant for locales using comma as a decimal separator: ru_RU, fr_FR, de_DE, es_ES, and others.

[43359] / #43829 added ja_JP to the list. Per ​Wikipedia, Japan uses a dot, not a comma, as a decimal separator, so adding it here doesn't seem to serve any purpose and might cause some confusion.

Change History (1)

#1 @johnjamesjacoby
6 days ago

If I understand correctly, the goal with #43829 was to make multibyte testing easier, not necessarily intentionally related to locale specific formatting.

Are there float tests that are inadvertently failing when testing with ja_JP?

Note: See TracTickets for help on using tickets.