WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#39276 closed defect (bug) (fixed)

Link Editor bug - target="_blank" not removed

Reported by: Mario62rus Owned by: iseulde
Milestone: 4.7.1 Priority: normal
Severity: normal Version: 4.7
Component: Editor Keywords: has-patch commit
Focuses: Cc:

Description

Here's my workflow:

  1. Setup clear WP 4.7, no themes or plugins.
  2. Edit post/page.
  3. Add some link.
  4. In the Link Manager uncheck "Open link in a new tab", press Update button and see tab "Text" - attribute target="_blank" added.
  5. Click "Edit link", uncheck "Open link in a new tab", press Update button and see tab "Text" - the attribute remains in place.

In version 4.6.1 this works correctly.

Attachments (1)

39276.patch​ (610 bytes) - added by iseuldebot 3 years ago.

Download all attachments as: .zip

Change History (8)

#1 @dd32
3 years ago

  • Component changed from General to Editor
  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 4.7.1
  • Summary changed from Link Manager bug - target="_blank" not removed to Link Editor bug - target="_blank" not removed

Hi @Mario62rus and thanks for reporting this!

I've reproduced this locally, I'm milestoning this for 4.7.1 pending a fix.

(Note: I renamed this from "Link Manager" as that's what we call another part of WordPress internally, just so we don't get tickets confused)

#2 @Mario62rus
3 years ago

OK, thx

@iseuldebot
3 years ago

#4 @iseulde
3 years ago

  • Keywords has-patch added; needs-patch removed

#5 @azaozz
3 years ago

  • Keywords commit added

39276.patch looks good.

#6 @iseulde
3 years ago

  • Owner set to iseulde
  • Resolution set to fixed
  • Status changed from new to closed

In 39601:

Editor: Remove target=_blank when unchecked in the link modal.

Fixes #39276 for trunk.

#7 @iseulde
3 years ago

In 39602:

Editor: Remove target=_blank when unchecked in the link modal.

Merges [39601] to the 4.7 branch.
Fixes #39276.

Note: See TracTickets for help on using tickets.