Theme Review Coding Standards Meeting on 31st of May 2018

Welcome to the Theme Review team!

We are a group of volunteers who review and approve themes submitted to be included in the official WordPress Theme directory.

We do license, security, and code quality reviews.

Code reviews are a great way to learn more about developing themes and improving your own skills.

If this sounds interesting, read more about the team here. Check out our guide for new reviewers.

Handbooks and review requirements

The team maintains the official Theme Review Requirements, the Theme Unit Test Data, and helps the documentation team with the Theme Developer Handbook.

Coding standards and plugins

We maintain the WPThemeReview Standard for PHP_CodeSniffer, and the Theme Sniffer plugin.

Code Packages

We have code packages for themes available for use on Github and Packagist

Communication

Meet us in the #themereview SlackSlack Slack is a Collaborative Group Chat Platform https://slack.com/. The WordPress community has its own Slack Channel at https://make.wordpress.org/chat/. channel.

Meetings:

Twice monthly at Tuesday @ 17:00 UTC Second Tuesday in the month is open floor and the fourth Tuesday is with a fixed agenda.

BlockBlock Block is the abstract term used to describe units of markup that, composed together, form the content or layout of a webpage using the WordPress editor. The idea combines concepts of what in the past may have achieved with shortcodes, custom HTML, and embed discovery into a single consistent API and user experience. Based Themes meeting twice monthly at Wednesday @ 16:00 UTC

Triage Meeting twice monthly at Wednesday @ 18:00 UTC

Important notice about TracTrac Trac is the place where contributors create issues for bugs or feature requests much like GitHub.https://core.trac.wordpress.org/. issues

If you are seeing this message: Missing or invalid form token. Do you have cookies enabled?

Go here: https://themes.trac.wordpress.org/ and login again.

#contributors

With WordCampWordCamp WordCamps are casual, locally-organized conferences covering everything related to WordPress. They're one of the places where the WordPress community comes together to teach one another what they’ve learned throughout the year and share the joy. Learn more. Europe coming closer every day, Juliette Reinders Folmer from the WordPress Coding Standards team and I decided to have a chat about the status of the current Theme coding standards and the Theme Sniffer plugin.

The current focus is bringing the Theme coding standards up to date with the PHP_CodeSniffer (v 3.x) and WordPress Coding Standards (0.14.1) (open PR #145) and finishing up the rewrite of the Theme SnifferTheme Sniffer Theme Sniffer is a plugin utilizing custom sniffs for PHP_CodeSniffer that statically analyzes your theme and ensures that it adheres to WordPress coding conventions, as well as checking your code against PHP version compatibility. The plugin is available from the plugin directory and Github. Themes are not required to pass the Theme Sniffer scan without warnings or errors to be included in the theme directory. pluginPlugin A plugin is a piece of software containing a group of functions that can be added to a WordPress website. They can extend functionality or add new features to your WordPress websites. WordPress plugins are written in the PHP programming language and integrate seamlessly with WordPress. These can be free in the WordPress.org Plugin Directory https://wordpress.org/plugins/ or can be cost-based plugin from a third-party so that it can be used during the Contributors day on WordCamp Europe.

I’ve written about the meeting in the slackSlack Slack is a Collaborative Group Chat Platform https://slack.com/. The WordPress community has its own Slack Channel at https://make.wordpress.org/chat/. channel, you can check that out here.

A meeting will be held on Thursday 31st, 09:00 AM CET via hangouts. You can add the google calendar events to your calendar by clicking these links meeting part 1, meeting part 2, the hangouts link is added in the events, but we’ll provide one during the meeting on the theme review slack channel. Be sure you are logged in with google account, so that we can use built-in hangouts functionality like chat, if needed.

The proposed agenda will be:

Talk through the PR to update to WPCS 0.14.1 / PHPCS 3.x & merge. #145
Go through all open PRs: PRs
- some will need updating for PHPCS 3.x
- some will need updating for WPCS
- some will need reviewing
- some might be mergeable (after rebase)
Go through all open issues: issues
- create PRs for those where upstream activity has made it an easy fix
- determine priority and action for the rest
Go through the upstream WPCS issue Add sniffs for theme checks to see:
- what’s still relevant what with the developments in TRT-land
- what can be fixed easily what with new sniffs having been added to WPCS + PHPCS
- open issues in WPTRT-CS repo for what remains
Go through all WPCS sniffs to see which if any of the new sniffs added should also be added to TRTCS
Browse through upstream PHPCS sniffs to see if there are (new) sniffs we should include.

There is still a lot of work to be done, so we would very much like to welcome people to contribute to this project. Contributors can really help us a lot by testing the new Theme Sniffer plugin. Testing sniffs and contributing by writing sniffs is also very welcome. I hope all who are interested and want to contribute will be there so that we can finish this before the WCEU Contributors day.

#contributors

poena 5:42 am on May 30, 2018

It is dififcult to take time off work in the morning to mid day so I will most likely not be able to attend.
- dingo-d 6:13 am on May 30, 2018
  
  I’m sorry to hear that :/ Tomorrow is a nonworking day in Croatia, so it was the only weekday working for me, and Juliette has a pretty busy schedule. You can still join and listen in, and leave a comment in the chat if that’s working for you.