@davidbaumwald facilitated the chat on this agenda.
Full meeting transcript on Slack
Highlighted blog posts
Upcoming Releases
WordPress 5.5 major release
WordPress 5.5 Call for Tickets is still open for feedback.
@sageshilling shared that the Editor team is working on a Gallery block update for WP 5.5.
WordPress 5.4.1 minor release
@audrasjb shared that on the 13 tickets in the milestone, 12 are already committed and one ticket still needs some work.
@whyisjake self nominated to lead WordPress 5.4.1. @davidbaumwald added that if anyone is interested in helping with 5.4.1, they can get in touch with @whyisjake. @audrasjb expressed his interest.
The idea is to ship a release candidate next week and a final release in two weeks.
Components Check-in
@imath shared an update on Comments component:
- He is working on a plugin to progress about #35214
- It would be nice to get some feedback on #49236, since it would be nice to have a patch committed early
- Feedback is also needed on #49179
@clorith pointed out that it would be nice to move forward on Dashboard Namespace introduction in REST API. Volunteers are welcome to contribute to the associated tickets.
@audrasjb shared the Accessibility team main focuses for WP 5.5:
@audrasjb also shared an update about WP Auto-updates feature plugin: version 0.5 was released just before the devchat. It addresses all the feedback received from the Design and Accessibility teams.
Open floor
@audrasjb raised a question concerning WP Auto-updates feature: should it provide a way to rollback to the previous version of an auto-updated plugin? This feature was proposed in a GitHub issue.
@imath believes WordPress could make it easier to come back to a previous version of a plugin.
@timothyblynjacobs pointed out that one of the big issues with rolling back, is that if a plugin does any kind of DB change, it can’t necessarily rollback without data loss or other breakage.
@clorith added that it might “double” the time needed per update in doing so, maybe even triple if it needs to revert as well, the increase in memory consumption, and processing time adds a new layer of potential failures as well.
@afragen raised this could be detected by the new WSOD so at least it wouldn’t white screen a site. @timothyblynjacobs answered WSOD protection would notice the error, but wouldn’t automatically deactivate the plugin.
@timothyblynjacobs thinks it would also be worth clarifying whether this would be limited to the updater automatically rolling back, or it being available for the user to take action.
For @sageshilling, ideally, the update if automated, would check for known problems and either notify site owner if detected during import. If possible, stop import, roll back and allow the site owner to address it.
@clorith thinks the correct approach is yes, keep a backup until the update is completed so it can be reverted, and introduce an actual feature for plugins/themes to run upgrade tasks after the fact, that way the site can be confirmed still functional without triggering any DB upgrades for example.
@timothyblynjacobs thinks there would be value to plugins being able to rollback the same way core does if the actual upgrade process fails. But he think having a WP-Rollback [note: it’s a plugin available on the repository] type solution in core should be a separate project.
As WP Auto-updates co-lead, @pbiron added an other question to the discussion: if one want to rollback, is that something that should be in the feature plugin or can that be worked on after the feature plugin is merged into core? He think the WP_Automatic_Updater
class has enough hooks that we could work on it in the feature plugin, but it might be difficult.
@desrosj point out that the way core handles rollbacks currently is a rollback URL is provided in the API response, and it gets retrieved if a severe failure occurs. There is no equivalent link returned in the API response for plugin updates.
@imath believes it’s better to have a way to manually upgrade/downgrade a plugin in WordPress before merging the feature into Core.
@desrosj thinks that for the first iteration, the WSOD may be enough for a non-technical to recover from an issue. Enabling auto-updates for plugins and themes will be opt-in, so maybe there just needs to be appropriate messaging when the site owner enables an auto-update for the first time.
@clorith agreed, when/if the feature is enabled by default, it needs rollback, but for a first iteration with manual enablling, let’s roll with what a manual way of reverting, sounds reasonable.
@audrasjb pointed out that managing updates rollback is a project in itself as it is something that should be currently available for manual updates.
@afragen asked: aren’t core rollbacks only for critical errors? Any plugin downloads and updates correctly but results in a fatal because of a coding issue sets a higher bar than we have for core.
@pbiron added that the current scope of the feature plugin has been providing a UI for enabling/disabling auto-updates, and rollback seems to be another feature plugin itself. Also, there is a notification email that gets sent with updates successes and failures. Also @timothyblynjacobs added that WSOD would send a recovery mode email if a site has fatal error on protected endpoints. @desrosj added that in the current process to manually upgrade a plugin in the dashboard today, there is no protection for a fatal error or coding error in the plugin.
@audrasjb raised that a rollback feature would be a nice improvement to WordPress Core, but it’s useful for both manual and auto updates.
#5-4-1, #5-5, #feature-autoupdates
Table of Contents PR needs reviews. Also would like a G2-style block icon, but I’d be happy to merge with the current dashicon.
http://wayback.fauppsala.se:80/wayback/20200422152559/https://github.com/WordPress/gutenberg/pull/21234
Need technical and design feedback on a PR to update the heading level control in the Heading block.
http://wayback.fauppsala.se:80/wayback/20200422152559/https://github.com/WordPress/gutenberg/pull/20246
I’ve got two Reusable Block polish/bugfixing PRs that are waiting for reviews.
http://wayback.fauppsala.se:80/wayback/20200422152559/https://github.com/WordPress/gutenberg/pull/21427
http://wayback.fauppsala.se:80/wayback/20200422152559/https://github.com/WordPress/gutenberg/pull/21181
Recently finished a PR to polish the Custom HTML block which also needs reviews.
http://wayback.fauppsala.se:80/wayback/20200422152559/https://github.com/WordPress/gutenberg/pull/21711
Got 3 tiny polish PRs that need reviews:
http://wayback.fauppsala.se:80/wayback/20200422152559/https://github.com/WordPress/gutenberg/pull/21304
http://wayback.fauppsala.se:80/wayback/20200422152559/https://github.com/WordPress/gutenberg/pull/21713
http://wayback.fauppsala.se:80/wayback/20200422152559/https://github.com/WordPress/gutenberg/pull/21744
Still stuck on List block color controls PR. One problem I’ve run into is that styles from the default editor styles with the same priority as my styles are overriding mine because the default editor styles are loaded after the block styles. Is that a bug? If not, I can just use a CSS duplicate selector (e.g. .doubled.doubled) to increase specificity, but I’d prefer to avoid that in order to keep styles easy to override. I’m also hoping that http://wayback.fauppsala.se:80/wayback/20200422152559/https://github.com/WordPress/gutenberg/pull/21102 will end up resolving a lot of the editor styles issues.
On the first agenda item, regarding the editor side for 5.4.1, the plan I have in mind is doing a cherry-picking of the PR’s to backport next Thursday.
All the PR’s to include were of Gutenberg 7.9, so they were tested in at lease one Gutenberg plugin release.
The PR’s to backport are labeled with “Backport to WP Core” http://wayback.fauppsala.se:80/wayback/20200422152559/https://github.com/WordPress/gutenberg/pulls?q=is%3Apr+sort%3Aupdated-desc+label%3A%22Backport+to+WP+Core%22+is%3Aclosed.
There are five PR’s with that labeled that were already part of Gutenberg release and should be part of 5.4.1:
http://wayback.fauppsala.se:80/wayback/20200422152559/https://github.com/WordPress/gutenberg/pull/21070
http://wayback.fauppsala.se:80/wayback/20200422152559/https://github.com/WordPress/gutenberg/pull/21460
http://wayback.fauppsala.se:80/wayback/20200422152559/https://github.com/WordPress/gutenberg/pull/21421
http://wayback.fauppsala.se:80/wayback/20200422152559/https://github.com/WordPress/gutenberg/pull/21376
http://wayback.fauppsala.se:80/wayback/20200422152559/https://github.com/WordPress/gutenberg/pull/21317
After the cherry-picking, a “package publish”, and core patch against 5.4.1 will be submitted.
Cc: @whyisjake as the release lead.
Planning for the 5.4.1 release Wednesday at 16:00 UTC.
Should we keep CONTRIBUTORS.md? Only 140 people are listed, but we have more than 550 code contributors, so it is not up-to-date. We don’t use this file in other repos. A GitHub -> WordPress connection is now build in on wp.org.
Discussion ticket: http://wayback.fauppsala.se:80/wayback/20200422152559/https://github.com/WordPress/gutenberg/issues/19948