WordPress.org

Make WordPress Core

Opened 3 months ago

Closed 3 months ago

#49163 closed defect (bug) (fixed)

Some typing mistakes in \wp-admin\includes\class-pclzip.php

Reported by: passoniate Owned by: SergeyBiryukov
Milestone: 5.4 Priority: normal
Severity: normal Version: 5.4
Component: Filesystem API Keywords: has-patch
Focuses: docs Cc:

Description

Some typing mistakes in \wp-admin\includes\class-pclzip.php

Attachments (1)

class-pclzip.php.patch​ (4.4 KB) - added by passoniate 3 months ago.
patch

Download all attachments as: .zip

Change History (3)

@passoniate
3 months ago

patch

#1 @SergeyBiryukov
3 months ago

  • Component changed from General to Filesystem API
  • Milestone changed from Awaiting Review to 5.4
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

Thanks for the patch!

Per comment:3:ticket:38464, class-pclzip.php used to be treated as an external library and was excluded from any documentation fixes. We only modify third-party libraries when it's needed to fix a bug, like in [46105/trunk/src/wp-admin/includes/class-pclzip.php] or [38101/trunk/src/wp-admin/includes/class-pclzip.php].

That said, looking at the commit history, there were some whitespace changes in [12042/trunk/wp-admin/includes/class-pclzip.php] and documentation additions in [8645/trunk/wp-admin/includes/class-pclzip.php].

Given that the ​upstream library hasn't been updated in 10 years since the last time it was merged, I think it's safe to treat it as "adopted" rather than external, same as jquery.imgareaselect.js or class-IXR.php, and make these fixes.

#2 @SergeyBiryukov
3 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 47123:

Docs: Fix typos in wp-admin/includes/class-pclzip.php.

With the upstream library not updated in 10 years since the last time it was merged, it should be safe to treat it as "adopted" rather than external, and make these fixes.

Props passoniate, ottok.
Fixes #49163. See #38464.

Note: See TracTickets for help on using tickets.