Make WordPress Core

Keyboard Shortcuts | Hide comment threads
Jeffrey Paul 2:49 am on May 8, 2020

Help needed —> Core team and WCEU Contributor Day

You may have seen update posts on WCEU’s plans on how to create an online Contributor Day this year (see posts from April 15th and April 24th). You may have also caught a reference to this in this past week’s devchat (see related summary post).

As part of the coming online/virtual WCEU, we’ve been asked to plan for how Core will handle an online Contributor Day.  The specific items we’ve been asked to consider:

  • Ensure our Getting Started at a Contributor Day handbook page has been updated as necessary
  • Ensure new contributor meeting happens between 25 May and 3 June, alerting the WCEU Contributor Day team via comment
  • Record a video intro about the Core team, similar to the live intros usually given in-person
  • Confirming list of good-first-issues and experience-issues for Contributor Day
  • Identifying 2+ experienced contributors to help facilities during Contributor Day
  • Plan for a live intro session at the beginning of Contributor Day

So I’m looking to you all to help here: who can help cover any of these tasks and help during the actual WCEU Contributor Day event? Please comment on this post noting which of the bulleted needs above are items you can assist with, thanks!

#contributor-day, #wceu

Greg Ziółkowski 12:36 pm on May 29, 2020

JavaScript Chat Summary: May 19, 2020

Below is a summary of the discussion from this week’s JavaScript chat (agenda, Slack Transcript).

Have a topic for discussion for the next meeting? Leave a suggested edit on next week’s agenda.

Dependency Group Comment Blocks

(Slack conversation)

Pull request: http://wayback.fauppsala.se:80/wayback/20200529165705/https://github.com/WordPress/gutenberg/pull/21730

Proposal:

Let’s use /* multi-line comment instead of /** JSDoc.

Rationale:

/** risks being interpreted as the JSDoc documentation of the first import in a grouping, especially in the case of variable assignment. Some examples: TypeScript (editor integrations, etc), @wordpress/docgen automatic documentation.

Action items:

  • @aduth will double check to see if the ESLint rule at least allows for this convention. If not, update to allow.
  • Documented examples could be updated to promote this pattern.
  • At some point, do a mass conversion of comments.
  • Finally, maybe consider to forbid the /** convention.

Core JS project on GitHub

(Slack conversation)

There is now a project board for Core JS tasks. It should include primarily framework tasks, the sorts of items we might want to discuss in the weekly meetings.

We also briefly discussed a few distinct tasks which could use some attention. New issues to work on:

Final check needed for:

News Roundup

This roundup contains a few links for Gutenberg and JavaScript related news curated (and commented on) by @nerrad.

  • Justin Tadlock offers some thoughts on where Gutenberg went wrong: Theme developer edition.
  • I somehow missed a gem of a post written by Matías back in April. He does a good job of providing some context to answering some of the questions out there regarding the direction of WordPress theming in the future. Read his post, Thoughts on Themes.
  • Gutenberg 8.1 has shipped. Highlights are: a new pattern search to make it easier to insert the desired pattern, a new testimonials pattern, and a new block action for copying single or multiple blocks. You can read the WPTavern’s take on this release here.
  • The recent Gutenberg Phase 2 Friday Design Update #53 shares some interesting updates on the Query block, the Block Navigator, Welcome guide, the “What’s new Modal”, and Template parts.
  • Speaking of templates, Envato launches a template kits marketplace for Elementor.
  • NPM 7 is getting some interesting new features including workspaces.
  • Next.js 9.4 is shipped. Notably, the inclusion of the new React Fast Refresh feature.
  • ESLint v7.0.0 was released.
  • Tom MacWright’s article Second-guessing the modern web has been making the rounds. There’s a counterpoint article by Rich Harris, “In defense of the modern web” (h/t @mkaz). I’m still processing both articles, there’s much I agree with in both, but much I’m shaking my head with too. As with everything in the development world, it’s hard to present a compelling argument while avoiding painting too broad a brush. As with all things coding, a good argument often includes some variation of “it depends”. My oversimplified hot take/response from/to all this? Frameworks are still evolving. By the way, is it just me, or does it seem like posts/controversies like this seem to surface every two years or so?
  • React recoil is public. Facebook’s take on a state management library for React. It’s intriguing to me, the tight integration with React itself suggests some really nice performance improvements over most other state management packages. In particular, how it handles asynchronous behavior seems really straightforward (and nicely integrates <Suspense> for handling pending state – which isn’t required).

#core-js, #javascript

Mary Baum 6:12 pm on May 28, 2020

Dev chat summary: May 27, 2020

@francina facilitated on this agenda. @sageshilling compiled this summary; @marybaum edited.

Celebration: WordPress turns 17!

@francina asked the group: What’s the next 17 years of WordPress look like? And then commented, “Futuristic I hope, maybe some steampunk.” 

Which led to this barrage from the group:

  • Radio buttons everywhere.
  • Marquees.
  • Blink tags, it’s all about attention grabbers.
  • Even more admin messages.
  • More animated gifs? I’m going to have nightmares. (edited) 

And this commentary:

  • Well that’s me not sleeping tonight.
  • No dancing baby unless it’s Leo [son of a Core committer]

Announcements

@francina got the meeting underway by pointing out two Highlighted/Need Feedback Blog Posts:

What’s new in Gutenberg? 

As often happens on a Wednesday, just before devchat, the Editor team issued a major release. This week: Gutenberg 8.2.0 featured block patterns and significant speed boosts, plus a long list of other enhancements.

To quote @francinadirectly: “Really, kudos, Gutenteam!”

 Team Reps. You still have time to vote

Through the rest of today, May 28, 2020. @jeffpaul has been shepherding this process and will announce the new reps.

5.4.2 update

@whyisjake  will lead 5.4.2 and confirmed he’s planning on this minor release in two weeks.

Last week the group agreed on releasing a public beta June 3 and the full release June 10th.

@whyisjake added that there is one ticket left in the milestone, and it has security implications. In the interest of making the web safer, the folx working on that ticket are thinking of backporting it to version 5.1 – which would be an exception to the project’s current policy

Components

@audrasjb gave his Accessibility update: two of three 2020 projects will make it into 5.5. The first of those, Alternate Table Views Choices, will likely be ready to discuss next week.

Open Floor

@garrett-eclipse brought a proposed UI change from Meta, that would add a dev-note field in Trac:
http://wayback.fauppsala.se:80/wayback/20200529165705/https://wordpress.slack.com/archives/C02RQBWTW/p1590133526466800

Also from Meta, the act of adding a PR to a ticket will toggle some keywords: has-patch/needs-patch/needs-refresh and needs-unit-tests/has-unit-tests.(meta:#5080)
Garrett thanked @dd32 for working on this, and @desrosj told the group it’s on his priority list for the next several days.

@johnstonphilip asked the group to discuss ticket #50214: Consider introducing the concept of “Editors”, and several people immediately got going in a lively thread.

@desrosj proposed a new enhancement in this ticket: #50268: Improve the plugin/theme auto-update emails

@Howdy_McGee asked for some eyes on his patch of #50070: ‘post_type’ query variable not set for taxonomy queries

Per his comment on the agenda, @apedog asked the group about avenues to overturn decisions that have already been made.

@justinahinon asked about next steps on APAC-friendly meetings, per http://wayback.fauppsala.se:80/wayback/20200529165705/https://make.wordpress.org/core/2020/04/29/proposals-an-apac-dev-chat-town-hall-meetings/

And to end the chat on a high note, @carike announced that Sitemaps will merge into 5.5!

@francina </devchat>

#core, #dev-chat, #summary

David Baumwald 6:31 pm on May 27, 2020

Dev Chat Agenda for May 27, 2020

Here is the agenda for the weekly meeting happening later today: Wednesday, May 27, 2020 at 08:00 PM UTC.

Highlighted/Need Feedback Blog Posts

Discussion

Any updates for a possible 5.4.2 based on the list of milestones tickets?

Components check-in and status updates

  • News from components
  • Components that need help/Orphaned components
  • Cross-component collaboration

Open Floor

Got something to propose for the agenda, or a specific item relevant to our standard list above?

Please leave a comment, and say whether or not you’ll be in the chat, so the group can either give you the floor or bring up your topic for you, accordingly.

This meeting happens in the #core channel. To join the meeting, you’ll need an account on the Making WordPress Slack.

#5-5, #agenda, #devchat

Garrett Hyder 6:59 pm on May 27, 2020

Hi David, can you add this request from Meta on the dev-note field in Trac;
http://wayback.fauppsala.se:80/wayback/20200529165705/https://wordpress.slack.com/archives/C02RQBWTW/p1590133526466800
Also from Meta when a PR is added to a ticket the has-patch/needs-patch/needs-refresh and needs-unit-tests/has-unit-tests will be toggled (meta:#5080)
Thanks go out to @dd32

Jake Spurlock 7:09 pm on May 27, 2020

For 5.4.2, we are looking to bring the changes in #49956 all the way back to 5.1. I want to make sure to highlight this potential change.

apedog 7:33 pm on May 27, 2020

I understand that it is well-accepted/decided/set-in-stone within WordPress development community that user names/authors is NOT considered private information. Some people hold an opposing view on this. What is the correct venue for overturning such a decision. And does such a venue even exist? Also – are there technical/back-compat issues if such a change was to be made.

This question is more about process than specifically the username/privacy policy question. It could also be about switching to short-syntax array. A decision has been made to not use short-syntax array. How does one go about overturning such a decision if the reasoning behind that decision is seen to be faulty?

A ticket does not seem to be a good avenue for this, as the more seasoned devs will (more likely than not) simply link to the documentation of such a decision, defer to that decision, and just set the ticket to wontfix.

annezazu 5:51 pm on May 27, 2020

Editor Chat Summary: 27th May, 2020

This post summarizes the latest weekly Editor meeting (agenda, slack transcript). This meeting was held in the #core-editor Slack channel on Wednesday, May 27, 2020 at 02:00 PM UTC and was moderated by @itsjusteileen.

Quick Announcements

  • WordPress turns 17 today! A big virtual high-five to everyone contributing to the project.
  • WordCamp Europe and Contributor day are coming up June 4-7.
  • For contributor day, @youknowriad is planning to do a quick zoom chat to help people setup a Gutenberg environment at the beginning of the day. To come prepared, please have “Docker” + Latest node.JS LTS setup.
  • There will be a chat tomorrow in #core-customize channel in Slack led by @dlh on the Customizer and FSE.
  • Stay up to date with Full Site Editing (FSE) and the various places coordination is happening with this summary post.

WordPress 5.5 Upcoming Release 

The planning roundup for 5.5 can be found here. There are several features that are under an experimental flag in Gutenberg, and to have a chance to make it for 5.5 they’d need to be out of experimental by July 7th. This led to a quick discussion that the widget screen can soon leave the experimental state!

@matveb chimed in to share the following later on to highlight that there’s plenty to do beyond the main projects that are underway if people want to/can help:

I wanted to mention that while many groups are focused on larger pieces of work (FSE, global styles, navigation, etc) 5.5 will require some focus on ensuring what exists right now is in good shape. That includes shipping the new design, patterns, the new inserter with new categories, new APIs and deprecations, etc.

Gutenberg version 8.2

Gutenberg RC candidate 8.2.0 was released this week with the stable release launched just after this meeting ended. Update your sites and check out what’s new.

Monthly Plan

There was limited discussion on the specifics of the current monthly priorities.

Task Coordination

Note: Anyone reading this summary outside of the meeting, please drop a comment in the post summary, if you can/want to help with something.

@poena

  • Flagged this issue as needing a decision about the dynamic content with @matveb chiming in to say that there needs to be closer parity with the current theme experience as a start.

@paaljoachim

@nosolosw

@michael-arestad

  • Dropping a new figma prototype very shortly on inserting saved (and new) template parts that deviates from previous designs and the current implementation. 
  • Planning to create a new issue with designs/discussion around a vertical grid for template building (and general layout things).
  • Planning to update the end to end full site editing prototype (i4).

@sageshilling

  • Working with core-media data flow, design gallery, image block, gallery patterns.

@mapk

  • Working on the widgets screen with @jorgefilipecosta.
  • Updating UI issues/PRs with Figma label.
  • Providing feedback on FSE work.
  • Redesign of spotlight mode with @youknowriad.

@karmatosed

  • Focusing deeply on navigation with a side order of triage.

@andraganescu

  • Various work on the navigation screen
  • Added new suggestion types to LinkControl
  • Continued the work on adding delete to Entities

@nrqsnchz

  • working with @michael-arestad on inserting saved (and new) template parts (FSE).

@zebulan

@itsjonq

  • Adding Padding controls
  • Working on video Background position controls
  • Working on cover image auto dominant colour detection

Open Floor

@youknowriad shared helpful guidelines for folks creating PRs to make the changelog easier to automatically compile.

  • When working on experimental screens and features, apply the [Type] Experimental label instead of Feature, Enhancement, etc.
  • When working on new features to technical packages (scripts, create-block, adding  react hooks, etc), apply the [Type] New API label instead of Feature, Enhancement, etc.
  • When fixing a bug or making an enhancement to an internal tool used in the project, apply the [Type] Build Tooling instead of Bugs, Enhancement, etc.
  • In PR titles, instead of describing the code change done to fix an issue, consider referring to the actual bug being fixed instead. For example: instead of saying “Check for nullable object in component”, it would be preferable to say “Fix editor breakage when clicking the copy block button”.
  • Take the time to choose the right [Type] label for your PRs. With some updates to the changelog command (type priorities), we should be able to support multiple types on a PR for some of the examples above.

Next step: @annezazu will look into updating both triage documentation and contributor documentation as appropriate.

Will core-editor participate in Contributor Day and should this be mentioned to participants? Raised by @itsjusteileen.

Yes! @youknowriad is planning to do a quick zoom chat to help people setup a Gutenberg environment at the beginning of the day. To come prepared, please have “Docker” + Latest node.JS LTS setup. This is also mentioned above under announcements.

Listing names in the code owners document to better understand who can be pinged for help/a review. Raised by @paaljoachim.

Paal encouraged everyone to review this document and keep it up to date. @karmatosed mentioned that relying on solid labeling alongside bringing in specific people from that list will likely help more for getting everyone to see issues appropriately.

#meeting-notes, #core-editor, #editor, #gutenberg, #core-editor-summary

annezazu 6:58 pm on May 27, 2020

Next step: @annezazu will look into updating both triage documentation and contributor documentation as appropriate.

After reviewing the triage documentation, it’s not clear to me that there’s value in updating it right now as that’s more for managing issues specifically. Happy to be wrong here so please chime in if you think it’s worthwhile. Instead, I opened two PRs:

annezazu 8:20 pm on May 27, 2020

Chatted with @karmatosed about this since she helped me with previous updates to the triage documentation. She helped clarify that triage is meant for both issues and pull requests (PRs). Right now, the language in the triage documentation isn’t super clear though. Tied to this @michael-arestad noted that non-contributors who submit PRs won’t have the ability to self label.

As a next step, once the Repository Management Doc updates are merged (awaiting some clarity around labels), I’ll do another pass through the triage documentation to clear all of this up.

Lara Schenck 5:37 pm on May 27, 2020

CSS Chat Agenda: 28th May…

CSS Chat Agenda: 28th May 2020

This is the agenda for the upcoming CSS meeting scheduled for Thursday, May 28, 2020 at 09:00 PM UTC.

This meeting will be held in the #core-css channel in the Making WordPress Slack.

If there’s any topic you’d like to discuss, please leave a comment below!

  • CSS audit status update
  • Color Scheming Updates
  • Open floor

#agenda, #core-css

Riad Benguella 4:32 pm on May 27, 2020

What’s new in Gutenberg? (27 May)

Gutenberg 8.2 is released. The team continues to heavily iterate on the two big projects: Full Site Editing and the navigation screen.

The release also includes a number of improvements, features, bug fixes to the post editor.

Block Patterns

After the introduction of the search support, the Block Patterns UI and APIs continue to improve with the introduction of the block pattern categories. In addition to that, a viewportWidth property has been made available to allow tweaking the width used on the block patterns preview. This is especially useful for large block patterns.

Cover Block content alignment

The Cover block saw the introduction of the new content alignment feature which opens up more design possibilities.

Editing flow

The editing flow is a constant priority for the project, and Gutenberg 8.2 introduces several enhancements to improve the writing experience. Copying, cutting, and pasting single blocks is now much easier. You can also split out of captions and button blocks using “Enter” to continue your writing.

8.2 🇮🇹

Features

  • Cover block: Support customizing the content alignment. (21091) (22322)
  • Add Block Pattern Categories Support. (22164) (22410)
  • Copy the whole block if no text is selected. (22186)

Enhancements

  • Limit the most used blocks in the inserter to 6 elements. (22521)
  • Allow split out of caption on Enter. (22290)
  • Buttons block: Allow split and merge. (22436)
  • Improve video backgrounds for the Cover block in iOS. (22346)
  • Combine Calendar Help and Close buttons in the date and time picker. (22176)
  • wordpress/env: Better run command errors. (22475)
  • Add support for named orientations and literal colors on custom gradients. (22239)
  • Use theme color as focus color. (22261)
  • Refine the specificity of the embed block styles. (21599)
  • Change inserter search placeholder text color. (22444)
  • Improve interactions and add unit parsing to the unit selector used in Cover block. (22329)
  • Use smaller spacer and cover block step values. (22320)
  • A11y: Add explanatory text before the a11y.speak aria-live regions. (22112)
  • Add Animoto, Dailymotion block embed icons. (21882)
  • Group block: Match frontend markup in the editor. (21867)
  • Iterations on the welcome guide. (21847)
  • Don’t show protocol in link suggestions. (20350)
  • New Block Patterns:
    • Hero and two columns. (21130)
    • Features or Services. (20898)

New APIs

  • React Hooks:
    • Add new React hook UseCopyOnClick as an alternative to the ClipboardButton component. (22224)
    • Add usePrevious hook to wordpress/compose package. (22540) (22597)
  • wordpress/env:
    • Granular volume mappings. (22256)
    • Add command to display Docker container logs. (21737)
    • Add a destroy command. (21529)
    • Add phpunit support. (20090)
  • wordpress/scripts:
    • Add CSS support to start and build scripts. (21730)
    • Support enabling/disabling dev tools, bundle analyzer and externals for build and start scripts. (22310) (22426)
  • Support preloading API requests using the fetchAllMiddleware middleware. (22510)
  • Support controlled InnerBlocks. (21368) (22366)
  • Add Close button filter. (22323)
  • Block API: Allow block registration without category. (22280)
  • Support customizing the viewportWidth for block patterns. (22216)

Bug Fixes

  • Fix theme CSS bleed in the Button component. (22460) (22522)
  • Fix CSS validation error on Button block styles. (22583)
  • Fix editor crash potentially happening when hovering style variations. (22490)
  • wordpress/env: Start database service before running tasks. (22486)
  • Fix editor crash when zooming. (22408)
  • Fix Button border radius set as 0. (22393)
  • Fix Cover block resizing. (22349)
  • Writing Flow: Fix reverse block selection after block deletion from rich text. (22292)
  • A11y: Include reusable blocks in announced inserter search results. (22279)
  • Remove the previous style CSS class when the default style variation is chosen. (22266)
  • Show the global inserter in container blocks nested inside locked templates. (22115)
  • Prevent the Page Break block from showing up as the first block in the inserter. (22523)
  • Polish code editor and fix iOS scrolling issue. (22021)
  • LinkControl component: Fix search result focus state border. (22553)
  • Prevent contributors for accessing the Media Modal. (22306)

Performance

  • Adds a command to run performance tests across branches. (22418)
  • useMovingAnimation: Avoid initial transform animation. (22536)
  • Optimize resizable preview hooks. (22511)
  • Short-circuit validation for identical markup. (22506)
  • More accurate dependency list for useGenericPreviewBlock hook. (22355)
  • Add missing side-effect declarations. (22300)

Experimental

  • Full Site Editing and Site Editor screen:
    • Add page-based navigation. (22368)
    • Page and Template switchers improvements. (22449)
    • Add Query block. (22199) (22364)
    • Use the inserter panel. (22413)
    • Add basic “tools” menu. (22539)
    • Implement post switcher and integrate with “navigate to link”. (22543)
    • Add focus mode and top toolbar modes. (22537)
    • Add entity editor to post content block. (22473)
    • Add ‘Review changes’ button for multi entity saving flow. (22450)
    • Fix Post Author block render issues. (22397)
    • Refactor Post Author block to use block context. (22359)
    • Templates Endpoint: Add resolved query arg to return only relevant templates. (21981)
  • Navigation Block and Screen:
    • Add block movers to the block navigator. (18014)
    • Add ellipsis menu to block navigator. (22427) (22517)
    • Add standard notices to nav menu page. (22374)
    • Implement the creation of menus on the edit navigation screen. (22309)
    • Add menu location management. (21351)
    • Navigation Link block: Add RichText split-at-end/merge/remove behavior. (21764)
    • Fix navigation block placeholder overlap. (22407)
    • Adds orientation class on frontend for the navigation block. (22272)
    • Refactor block navigation block contents. (22487)
    • Fix navigation screen crash with no menu items. (22342)
    • Adds save and failure notices to the navigation screen. (22326)
    • Display the block appender only for the currently active menu. (22311)
    • Allow editing of new menu items from the block inspector. (22210)
    • Submenu nesting and saving new nested items. (21671)
  • Block-based Widgets screen and Customizer tab:
    • Use interface package on widgets screen sidebar. (22304)
    • Use single block editor in the widgets screen. (22140) (22459)
    • Use the mobile view for the Customizer. (22533)
    • Add legacy widget to calendar transform. (14586)
  • Global Styles and theme.json:
    • Implement Managed CSS for Global Styles. (20290)
    • Support theme.json in Post editor. (22520)
  • Block Directory:
    • Activate deactivated blocks if already installed . (22286)
    • Only support an array of assets when injecting assets. (22289)
    • Remove the author rating when none exist. (22184)
    • Update layout for smaller inserter width. (22124)
    • Add error messages inline. (20001)

Documentation

  • Document experimental theme.json. (22518)
  • Fix duplicate grammar docs. (22466)
  • Document the performance testing commands. (22464)
  • Docs: Update note for extraProps filter. (22419)
  • Recommend adding an API docs section. (22415)
  • Add side effect documentation. (22379)
  • Update block editor docs to incorporate the block-toolbar Popover Slot. (22308)
  • Adds a README to MediaReplaceFlow. (22268)
  • Typos and tweaks: (22254) (21968) (21695) (22554)

Code Quality

  • Avoid circular dependency issue in AutoBlockPreview. (22425)
  • Remove opinionated label color from CustomSelectControl component. (22594)
  • Image block:
    • Use hooks. (22499) (22277)
    • Remove extra div wrapper in the editor. (22585)
  • Remove redundant condition from setting default grouping. (22563)
  • Testing: Replace require.requireActual with jest.requireActual. (22370)
  • Use a light block DOM for the Cover block to map frontend markup. (22348)
  • Rename a complementary area component property. (22336)
  • Block API: WP_Block: Document attributes class property. (22222)
  • Polish block wrapper elements file. (21304)
  • Move supports to block.json files for core blocks. (22422)
  • Create Block: Simplify the process of defining a config for templates. (22235)
  • Block Edit: Use hooks. (22433)
  • Add BlockContext component to type-checking. (22353)

Build Tooling

  • ESLint Plugin: Fix dependency group checking for CommonJS. (22230)
  • Restore Playground GitHub Pages deploy. (22443)
  • Fix API Docs generation for filenames with spaces. (22513)
  • Fix check-latest-npm.js failure on Windows. (22485)
  • Refactor the changelog script as a release tool command. (22380)
  • Enable import/no-unresolved ESLint rule for Gutenberg. (20905)
  • Only allow ECMAScript stage 4 features. (22083)
  • Storybook: Use a consistent port number. (22552)
  • Add 0BSD to GPLv2 compatible licenses. (22391)
  • Refactor the release tool and split it into several command files. (22003)
  • Replace wp-scripts env usage with wp-env in CI. (20280)

Various

  • Update: ResizableBox make showHandle true by default. (22360)
  • Fix dirty state end-to-end test intermittent failuire. (22532)
  • Fix dirty state end-to-end test. (22448)
  • Add a simple block patterns end-to-end tests and a test utility. (22414) (22495)
  • Remove insert block delay from end-to-end tests. (22377)
  • Add an end to end test to verify cover can be resized with drag & drop. (22369)
  • Upgrade Reakit to stable v1.0.0. (22352)
  • Use alternate display for the popover in alignment matrix. (22351)
  • Fix deprecated version used for register_pattern. (22341)
  • API Fetch: Remove deprecated useApiFetch. (22333)
  • Framework: Pin nvmrc to specific current LTS. (22236)

Performance Benchmark

The following benchmark compares performance for a particularly sizeable post (~ 36000 words, ~ 1000 blocks) over the last releases. Such a large post isn’t representative of the average editing experience but is adequate for spotting variations in performance.

Version Loading Time KeyPress event (typing)
Gutenberg 8.2.0 7.4s 29.7ms
Gutenberg 8.1.0 8.6s 29.7ms
WordPress 5.4 9.2s 26.8ms

Kudos for all the contributors that helped with the release. 👏

#core-editor, #editor, #gutenberg-new

Pascal Birchler 12:51 pm on May 26, 2020

XML Sitemaps Meeting: May 26th, 2020

A lot has been going on since our last blog post. Besides many improvements and fruitful discussions in the XML Sitemaps feature project, the proposed schedule for WordPress 5.5 has been published.

The first beta is currently slated for July 7, which still gives us a bit of time to finish work on our project. We’re getting close to a state where we feel comfortable publishing a merge proposal for inclusion in WordPress core as part of the 5.5 release.

This post aims to give an overview of the things currently in progress, and the items that should be discussed in the upcoming meeting on Slack.

Updates

  • Custom elements in sitemap (#151)
    The pull request proposing a simple API still needs some documentation, but overall ready for review.
  • PHP Warning on PHP < 7.3 (#186)
    A pull request has been opened to fix this edge case. Ready for review.
  • Filters for individual sitemap entries (#191)
    Freshly proposed over the weekend, this PR makes it easier to modify sitemap data while having access to the necessary post/term/user objects for context. Ready for review.
  • Filter to modify WP_Query arguments (#183)
    Feedback from initial code review still needs to be incorporated.
  • Removing core_ prefixes from code (#182)
    Still some feedback that needs to be incorporated. Tests are currently not passing. Otherwise very close.
  • Custom elements in stylesheet (#152)
    PR #163 is still work in progress. The feeling last time was that it might be too complex for core, and perhaps better off as a plugin.
    If the pre-existing stylesheet is deemed to not satisfy the needs, we could also omit the stylesheet completely if wanted.
  • Merge proposal post
    We started with an early draft for this, and will share the draft post with the broader group once we feel more comfortable with it.
  • Core patch
    Not yet in progress, as there are some bigger outstanding PRs needed for this. We’ll likely start with a first proof-of-concept PR that can then serve as the basis for discussion.

Agenda: May 26th

The next meeting will be held on Tuesday, May 26, 2020 at 02:00 PM UTC.

Items on the agenda so far:

  • Going through items from updates above
  • Open floor

Want to add anything to the above? Please leave a comment here or reach out on Slack.

This meeting is held in the #core-sitemaps channel. To join the meeting, you’ll need an account on the Making WordPress Slack.

#agenda, #feature-plugins, #feature-projects, #xml-sitemaps

Eileen Violini 1:09 am on May 26, 2020

Editor Chat Agenda 27 May, 2020

This is the agenda for the weekly core editor chat scheduled for Wednesday, 27 May, 2020, 10:00 AM EDT. This meeting is held in the #core-editor WordPress Slack channel.

If you have anything to share for the Task Coordination section, please leave it as a comment on this post. If you have anything to propose for the agenda or other specific items related to those listed above, please leave a comment below.

#agenda, #core-editor, #editor-chat, #core-editor-agenda

Zebulan Stanphill 3:17 am on May 26, 2020

Finished some PRs and got them merged over the past week. Most notably:

Add RichText split-at-end/merge/remove behavior.
http://wayback.fauppsala.se:80/wayback/20200529165705/https://github.com/WordPress/gutenberg/pull/21764

Add usePrevious hook to @wordpress/compose package.
http://wayback.fauppsala.se:80/wayback/20200529165705/https://github.com/WordPress/gutenberg/pull/22540

As for PRs that are still WIP or awaiting reviews:

Heading block level control revamp PR has been improved and looks ready to merge.
http://wayback.fauppsala.se:80/wayback/20200529165705/https://github.com/WordPress/gutenberg/pull/20246

PR to replace instances of Lodash.includes with native JS [].includes in the block-editor package is awaiting reviews.
http://wayback.fauppsala.se:80/wayback/20200529165705/https://github.com/WordPress/gutenberg/pull/21063

PR to refactor ReusableBlockEditPanel to use React hooks is still waiting for reviews.
http://wayback.fauppsala.se:80/wayback/20200529165705/https://github.com/WordPress/gutenberg/pull/21181

I’ve been maintaining the Table of Contents block PR and making slight code quality improvements here and there. But it hasn’t really had any feedback to progress for around 20 days. I simply can’t progress without technical help/feedback. Would also appreciate some general feedback on potential naming changes, as well as accessibility feedback to make sure the current markup makes sense.
http://wayback.fauppsala.se:80/wayback/20200529165705/https://github.com/WordPress/gutenberg/pull/21234

Great feedback/help has been provided to the Reusable Block edit component refactor/bugfix PR. It’s made some great progress, but there is still one noticeable behavior issue that I need help to resolve.
http://wayback.fauppsala.se:80/wayback/20200529165705/https://github.com/WordPress/gutenberg/pull/21427

Polish Custom HTML block PR is ready to go, assuming the stylistic changes are okay. Ideally, the block’s HTML view should look just like the Edit as HTML view on most blocks; yet the Edit as HTML view arguably doesn’t look as good as it should. Please provide design feedback.
http://wayback.fauppsala.se:80/wayback/20200529165705/https://github.com/WordPress/gutenberg/pull/21711

I also have a PR that was attempting to update the Quote block to use a light block wrapper, but I got completely stuck due to complications with the BlockQuotation component used to make the block edit component work on both web and native mobile. I need technical help to progress. It’s a difficult problem, but solving it will also solve how to convert other blocks to use light block wrappers.
http://wayback.fauppsala.se:80/wayback/20200529165705/https://github.com/WordPress/gutenberg/pull/22157

Another stuck PR is one to add color controls to the List block. It isn’t working on most default WordPress themes due to style conflicts. No idea how to get it working.
http://wayback.fauppsala.se:80/wayback/20200529165705/https://github.com/WordPress/gutenberg/pull/21387

Overall, several PRs have made significant progress thanks to your help/feedback. Others are still stuck where they were a week or two ago, but I’m sure there will be time for them once more pressing projects are tackled.

I’d like to express my thanks to everyone who has helped so far! Several PRs that I thought were ready turned out to have a few minor issues pointed out to me, and I’ve gained a good amount of experience through the maintenance of all these PRs and the feedback provided by various people. Again, thank you!

Paal Joachim Romdahl 7:45 am on May 27, 2020

Good going Zeb! Thanks for sharing the update!

Paal Joachim Romdahl 8:42 am on May 27, 2020

This is an important document for people to know about. As each of us have areas of focus that we can easier help out in. Listing our names in the document can help when someone creates a PR. As one will from the list understand who they can ping to get some help and/or a review.
http://wayback.fauppsala.se:80/wayback/20200529165705/https://github.com/WordPress/gutenberg/blob/master/.github/CODEOWNERS

Lara Schenck 5:59 pm on May 22, 2020

CSS Chat Summary: 21st May…

CSS Chat Summary: 21st May 2020

Full meeting transcript on Slack: http://wayback.fauppsala.se:80/wayback/20200529165705/https://wordpress.slack.com/archives/CQ7V4966Q/p1590094908056800

I (@notlaura) facilitated the meeting.

CSS audit updates

@isabel_brison had a couple of questions, and we clarified some items mentioned in the report outline:

For “List of unique values for each of a list of properties, and number of occurrences:” we discussed that margins, padding, top/left/bottom/right, transforms, and typography related properties would be useful for standardizing our units of measurement. @ryelle‘s audit tool would certainly be useful for that.

The other question was to do with the item “Units: instances of px/em/rem/%age and count of use with properties”. We discussed that that should be limited to areas that affect responsive/zoom behavior, or properties where px unit are used but and probably shouldn’t be. Extending this to more than those cases might be beyond the scope of the audit and difficult to automate. Part of the original intent of that item was to identify “brute force layout”, but we discussed that basically the entire wp-admin is brute force layout and auditing that would require manual inspection. Also, that is a subjective item and perhaps a conversation more appropriate for a CSS coding standards discussion after following the audit.

Color Scheming Update

@kburgoine has been doing lots of prep work and reading through historical tickets to get a good understanding of the problem with the current color schemes. She mentioned that the most pressing issue is not necessarily backwards compatibility, rather, the number of colors in use.

We discussed some more about design tokens, and I updated that I elaborated on my idea for the implementation in @ryelle‘s Gutenberg PR, and in a new comment on the “Iterating on Admin Color Schemes” ticket.

I also mentioned some recent activity on the ticket for Dark Mode – which is potentially a conversation we can participate in since the intent behind re-vamping color schemes it to be able to support something like Dark Mode.

Open Floor

@peterwilsoncc jumped in at the end with a question about #46090 and including the X-UA-Compatible header for IE detection.

That was all for this week!

#core-css #summary

Lara Schenck 8:20 pm on May 21, 2020

CSS Chat Agenda: 21st May…

CSS Chat Agenda: 21st May 2020

This is the agenda for the upcoming CSS meeting scheduled for Thursday, May 21, 2020, 5:00 PM EDT.

This meeting will be held in the #core-css channel in the Making WordPress Slack.

If there’s any topic you’d like to discuss, please leave a comment below!

  • CSS audit status update
  • Color Scheming Updates
  • Open floor

#agenda, #core-css