Make WordPress Themes

Keyboard Shortcuts | Hide comment threads

Gutenberg + Themes: Week of June 8, 2020

Hi everyone! Here’s the fifth weekly roundup of theme-related discussions, fixes, and developments in Gutenberg

Since conversations are ongoing, some of the issues & PRs mentioned were also present in previous weeks. We’ve tried to put brand new ones at the top of each of the bulleted lists. 

Please weigh in on the tickets below — your voice and feedback are welcome! 

In progress / Discussions:

General

  • Simplify the Quote block’s editor markup to better match the front end. 22803
  • PR to adjust max-width setting for reusable blocks. 22632
  • PR for adding color controls to the list block. 21387
  • PR to change CSS specificity of default font-size rules. 22671
  • Fixes for the issue where custom theme colors don’t work in the editor after Gutenberg 7.9.1. 22356
  • An attempt to remove some of the extra canvas padding in the editor. 22213

Block-based Themes

  • Tracking issue for Template Tags in Full Site Editing 22724 
  • Syncing theme templates to the block editor in all contexts: 22469
  • Figuring out a way to handle inline dynamic content in theme templates. 21932

FSE Blocks

A set of blocks are available with the Gutenberg plugin to enable building templates in FSE.

  • HTML/CSS output not consistent. 22759
  • Last element in “Latest Posts” block has wrong right margin. 22911
  • FSE blocks are missing classnames on the front end. 21903
  • Site Title: Add support settings for colors, fonts, and line height. 23007

Global Styles

  • Recap and next steps for Global Styles. 22296
  • Tracking and consolidating style attributes for blocks. 22700 

Navigation

  • This board tracks Navigation Screen and Navigation Block issues that are important for the WordPress 5.5 release. Project Overview

Merged:

General

  • New padding control to cover block. (21492, 23041)
  • New link color control to paragraph, heading, group, columns, and media-text blocks. (22722, 23025, 23049)
  • Experimental version of rich image editing tools. (21024, 22870)
  • Remove padding inheritance on lists in editor-styles (23080)

Block-based Themes

  • Add alignment and heading level support to the post title block. 22872
  • Add more customization options to the Author block. 22877
  • PR to add an “Export Theme” button to the Full Site Editor in the plugin. 22922  

Global Styles

  • A new iteration of `experimental-theme.json`, complete with draft documentation. 20290 (Documentation)

General Resources:


Thanks to @itsjusteileen, @joen, and @kjellr for help pulling this post together. Please let us know if it was helpful in the comments!

#gutenberg-themes-roundup

Meeting notes Tuesday 9 June 2020

Today we held a meeting with the proposed agenda. The recap of the meeting is below and you can read the meeting transcript in the slack archives (a Slack account is required).

Weekly Updates

In the past seven days

  • 251 tickets were opened
  • 250 tickets were closed:
  • 230 tickets were made live.
    • 15 new Themes were made live.
    • 215 Theme updates were made live.
    • 2 more was approved but are waiting to be made live.
  • 20 tickets were not-approved.
  • 0 ticket was closed-newer-version-uploaded.

We have managed to cut down on the queue length, which is always good news.

We thank to all the reviewers, keep doing a great job 🎉

Biweekly meeting schedule to Monthly meeting for Themes Team

Summer is closing in and we realised (and observed during the last few months) that having many meetings (regular, block themes and triages) can be a bit tiring – both to the reps and to the contributors.

The proposal is to cut the Themes Team regular meeting to once a month plus an additional one if we have some urgent thing to discuss.

This will give us a bit more breathing room both to recharge and focus on priorities set by phase three of the core editor development that are tied to the WordPress themes.

Open Floor

An issue was raised about Themes team not being a team anymore due to the lack of public discussions.

It was mentioned that the decisions are made and just announced.

This one is definitely on us (the reps). We should have been more tactful of how we presented the news (like changing the name of the team).
Team reps are always discussing and finding ways to improve this team’s impact in the WordPress community.

It’s hard to get noticed without active contributors, and in the last few years we have seen a decline in the active participants. To many authors theme repository is just one of the advertising avenues, which is disheartening.

One of the ways we wanted to spark the interest is to be involved with the core editor more, show that we are doing more than just review themes.

We definitely need to improve our transparency towards the community as team representatives. Writing more blogs about what we think would be a good way forward, and listening to advice and discussing them in the comments and then in the meetings.
What we do want to avoid are empty discussions that lead nowhere, as this is what kills the team. We need to adapt, change, and even innovate.

Andrea Middleton shared her experience from working in the Community Team:

In my observation, leading in the open is really difficult, and the process of learning how to do it effectively isn’t necessarily linear.

I’ve messed it up bunches of times — I think humans are just really prone to forming small groups, it helps us feel safe — and when it’s pointed out to me, I usually feel really dispirited and embarrassed.

For me, the best way to recover from that realization of “whoops, this conversation could/should have happened in the public channel” is to then go to the public channel and summarize the conversation there.

Andrea Middleton

It was also suggested that we should come up with a mission statement draft. Some goals that we as a team want to achieve.

This year we have put focus on Full Site Editing. We will continue working on preparing the community for the upcoming changes in the themes ecosystem.

Proofread by @williampatton

#meeting, #meeting-notes, #themes-team

Theme Review Team Meeting Agenda for June 09

Theme review team (TRT) conducts a meeting on the second and fourth Tuesday of the month. Along with the fixed agendas, we have open floor meeting at the end where you can ask or share anything related to themes.

We encourage all members and anyone interested to attend.

Channel: #themereview | Time: Tuesday, 09th June 2020, 17:00 UTC

Meeting Agenda

  1. Weekly Updates
  2. Biweekly meeting schedule to Monthly meeting for Themes Team
  3. Open Floor

The discussion about the meeting agenda can be held in the comments below. You are encouraged to propose topics.

Meetings usually last around 60 minutes. Attend and share your valuable feedback and suggestions.

#meeting, #themesteam

Gutenberg + Themes: Week of June 1, 2020

Hi everyone! Here’s the fourth weekly roundup of theme-related discussions, fixes, and developments in Gutenberg. This one’s coming one day late — we were all busy watching the excellent WCEU talks on Friday! 🙌

One quick thing to note before we get to the tickets: If anyone would like to follow along with the Full Site Editing Outreach Experiment, feel free to join the #fse-outreach-experiment channel on slack.

Since conversations are ongoing, some of the issues & PRs mentioned were also present in previous weeks. We’ve tried to put brand new ones at the top of each of the bulleted lists. 

Please weigh in on the tickets below — your voice and feedback are welcome! 

In progress / Discussions:

General

  • Simplify the Quote block’s editor markup to better match the front end. 22803
  • PR to adjust max-width setting for reusable blocks. 22632
  • PR for adding color controls to the list block. 21387
  • PR to change CSS specificity of default font-size rules. 22671
  • Fixes for the issue where custom theme colors don’t work in the editor after Gutenberg 7.9.1. 22356
  • An attempt to remove some of the extra canvas padding in the editor. 22213
  • A conceptual discussion about removing all default margins for blocks in the editor. 22208
  • A draft for converting pixel values to rem 22505

Block-based Themes

  • Add alignment and heading level support to the post title block. 22872
  • Add more customization options to the Author block. 22877
  • PR to add an “Export Theme” button to the Full Site Editor in the plugin. 22922  
  • Tracking issue for Template Tags in Full Site Editing 22724 
  • Syncing theme templates to the block editor in all contexts: 22469
  • Figuring out a way to handle inline dynamic content in theme templates. 21932
  • FSE blocks are missing classnames on the front end. 21903

Global Styles

  • Recap and next steps for Global Styles. 22296
  • Tracking and consolidating style attributes for blocks. 22700 

Merged:

General

  • Remove form control resets and include in components instead. 22596
  • Fix the appearance of Group block children in the editor. 22746

Global Styles

  • A new iteration of `experimental-theme.json`, complete with draft documentation. 20290 (Documentation)
  • Add ability to change link color in `experimental-theme.json`, add to documentation. 22722 22929

General Resources:


Thanks to @itsjusteileen, @jffng, and @joen for help pulling this post together. Please let us know if it was helpful in the comments!

#gutenberg-themes-roundup

Edited by @williampatton to correct link to FSE labled issues.

Summary of the WCEU Online contributor day

A big thank you to everyone who participated in the contributor day!

This year we tried something new: Not only was the contributor day run online, via Zoom and Slack, but we also tried a new format for how we introduce new contributors.

In previous contributor days, the contributors were given a short introduction and then they were assigned a theme each to review.

The results were always varied and it was hard for new contributors to get started because there are lots of requirements, a new process that is new to them and the Trac ticket system to learn. It also created extra administration overheads following up after the contributor day.

One feedback that we often receive is that learning how to do a review is not the primary reason for why contributors choose to contribute to the Themes team. The drive is to become a better theme developer – to learn and share thoughts and ideas with others.

That is why we had set a goal to both have a quick introduction on how to do a theme review, and build a basic full site editing theme together.

The goal of building a FSE compatible theme together was lofty and we were unable to reach that goal, but I hope that you still found the afternoon useful.

We had 6 contributors who attended a contributor day for the first time, and 3 contributors who had done theme reviews before. None of the new contributors had submitted a theme to WordPress.org.

Unfortunately, due to internet issues, we were only able to have one host on Zoom. We started an hour into the contributor day – as we all waited for people to find their way to the Slack channel and Zoom.

At most, we had 19 people on Zoom, and my experience as a host was that it was difficult to make everyone heard and engaged.

– If you have questions that I missed, please take the opportunity to ask them on Slack or as a comment to this post.

  • We did a quick walkthrough of the Trac ticket system and how to select a ticket to work on.
  • We downloaded and reviewed one theme that we tested with the Theme Check plugin.
    • We looked through the files of the theme and tested the theme options in the customizer.

Some questions that were asked was:

Q – How long does a review take?
A – It depends, it is faster to find errors in a theme with lots of issues, than to confirm that a theme has no errors.

Q – How do I get assigned to a theme?
A – You need to login to your WordPress.org account and add a comment to the Trac ticket that you want to review. You can start the review right away, and a moderator will go through the Tac list and assign it to you when they see your comment.

Q – How do we confirm if the license is compatible with GPL?
A – We follow an official list of compatible license from the Free Software Foundation: http://wayback.fauppsala.se:80/wayback/20200629192703/https://www.gnu.org/licenses/license-list.html#GPLCompatibleLicenses

The most common license issue is that theme authors forget to include license information.

Q – How can we spot a theme copy?
A – Sometimes, people submit themes and only change a letter or two in the theme name, and that is easy to spot. Other times, people change the screenshot and the name of the theme, but we can recognize that the code is a copy of a different theme. A common sign is that the theme description is copied from a different theme. We use http://wayback.fauppsala.se:80/wayback/20200629192703/https://wpdirectory.net/ to compare code snippets, and Trac diff to see the difference between two themes.


Second part -full site editing

I also did an introduction to full site editing on zoom for the 11 patient contributors who stayed with us until the end of the day.

I showed how to enable the full site editing experiment and where to find experimental themes to test: http://wayback.fauppsala.se:80/wayback/20200629192703/https://github.com/WordPress/theme-experiments

We talked about designing sites with blocks and I showed what the structure of a full site editing theme can look like, with block templates and template parts. We looked at the block grammar used inside the .html files, and how to include template parts inside templates.

We talked about the new full site editing blocks, block patterns, and block pattern categories.

I showed how to find theme related issues and pull requests in the Gutenberg Github repo, and talked briefly about what kind of bugs it would be good to open issues for when testing full site editing.

The contributors had questions about the time frame (when full site editing will be available), how to support plugins in templates and block patterns, and how to build more complex websites like eCommerce sites using blocks.

Proofread by @williampatton and @dingo_d

While reading this post, I was thinking, “Why isn’t there a set of YouTube videos showing how to do theme reviews?”. I then searched YouTube for, “how to do a wordpress theme review”, but didn’t really get any good results.

At one point in time, I dabbled in theme reviews, but it was a bit confusing and I could tell it would take some time to really learn how things work. For example, one confusing aspect was how much of the theme review was handled automatically via the theme review plugin, and how much of the review required me to manually grep through files and look for issues?

Anyways… Just an idea, it could help if there was a series of videos showing examples walkthroughs on how exactly to review a theme.

Thanks!
Brad

I have some videos on youtube but I wouldn’t recommend watching through it all because they are too long. http://wayback.fauppsala.se:80/wayback/20200629192703/https://youtu.be/XS0su_tFzac

Its not a great idea to show a real review because it can be negative for the theme author when we find errors.