Skip to content

/ gutenberg

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WordPress 5.5.1 Backports #24828

Merged
merged 5 commits into from Aug 26, 2020
Merged

WordPress 5.5.1 Backports #24828

merged 5 commits into from Aug 26, 2020
+42 −16

Conversation

@jorgefilipecosta
Copy link
Member

@jorgefilipecosta jorgefilipecosta commented Aug 26, 2020 •
edited

Backports the following PR's to be part of WordPress 5.5.1

PRAuthorAction For cherry pick
Fix missing selected block highlighting in list view@talldan-
Fix specificity for buttons with outline style and background colors@nosolosw-
Fix incorrect aria description in List View@talldanConflict on packages/block-editor/src/components/block-navigation/block.js. The resolution was accept incoming changes.
Fix regression bug for category select in QueryControls component @gchtr-
Fix tiny editor preview when using Mobile or Tablet options with metaboxes enabled@talldan-
talldan and others added 5 commits Aug 18, 2020
@talldan @jorgefilipecosta
Fix missing selected block highlighting in list view (#24609)
6694da9 
* Add back missing style for selected block in list view

* Override selected style on navigation screen
@nosolosw @jorgefilipecosta
Fix specificity for buttons with outline style and background colors (#…
2360d1a 
…24599)

When the .wp-block-button.is-style-outline .wp-block-button_link
selector was added, its specificity (030) overrode existing
theme selectors that had 020 specificity.
@talldan @jorgefilipecosta
Fix incorrect aria description in List View
7f41d98
@gchtr @jorgefilipecosta
Fix missing onChange for category select in QueryControls component (#…
d0ebc5c 
…24516)
@talldan @jorgefilipecosta
Force canvas size when using in editor preview option (#24478)
Loading status checks…
65836cc
@github-actions
Copy link

@github-actions github-actions bot commented Aug 26, 2020

Size Change: +164 B (0%)

Total Size: 1.14 MB

Filename Size Change
build/block-editor/index.js 120 kB +23 B (0%)
build/block-editor/style-rtl.css 10.6 kB +25 B (0%)
build/block-editor/style.css 10.6 kB +23 B (0%)
build/block-library/style-rtl.css 7.78 kB +1 B
build/block-library/style.css 7.79 kB +1 B
build/components/index.js 198 kB +1 B
build/edit-navigation/style-rtl.css 1.06 kB +45 B (4%)
build/edit-navigation/style.css 1.06 kB +45 B (4%)
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/annotations/index.js 3.67 kB 0 B
build/api-fetch/index.js 3.4 kB 0 B
build/autop/index.js 2.82 kB 0 B
build/blob/index.js 620 B 0 B
build/block-directory/index.js 7.93 kB 0 B
build/block-directory/style-rtl.css 944 B 0 B
build/block-directory/style.css 945 B 0 B
build/block-library/editor-rtl.css 7.57 kB 0 B
build/block-library/editor.css 7.57 kB 0 B
build/block-library/index.js 130 kB 0 B
build/block-library/theme-rtl.css 728 B 0 B
build/block-library/theme.css 729 B 0 B
build/block-serialization-default-parser/index.js 1.88 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 48.2 kB 0 B
build/components/style-rtl.css 15.8 kB 0 B
build/components/style.css 15.8 kB 0 B
build/compose/index.js 9.68 kB 0 B
build/core-data/index.js 11.4 kB 0 B
build/data-controls/index.js 1.29 kB 0 B
build/data/index.js 8.44 kB 0 B
build/date/index.js 5.38 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 569 B 0 B
build/dom/index.js 3.23 kB 0 B
build/edit-navigation/index.js 9.94 kB 0 B
build/edit-post/index.js 304 kB 0 B
build/edit-post/style-rtl.css 5.59 kB 0 B
build/edit-post/style.css 5.59 kB 0 B
build/edit-site/index.js 16.7 kB 0 B
build/edit-site/style-rtl.css 3.03 kB 0 B
build/edit-site/style.css 3.03 kB 0 B
build/edit-widgets/index.js 9.38 kB 0 B
build/edit-widgets/style-rtl.css 2.45 kB 0 B
build/edit-widgets/style.css 2.45 kB 0 B
build/editor/editor-styles-rtl.css 537 B 0 B
build/editor/editor-styles.css 539 B 0 B
build/editor/index.js 45.1 kB 0 B
build/editor/style-rtl.css 3.8 kB 0 B
build/editor/style.css 3.79 kB 0 B
build/element/index.js 4.65 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 7.72 kB 0 B
build/format-library/style-rtl.css 547 B 0 B
build/format-library/style.css 548 B 0 B
build/hooks/index.js 2.13 kB 0 B
build/html-entities/index.js 622 B 0 B
build/i18n/index.js 3.57 kB 0 B
build/is-shallow-equal/index.js 710 B 0 B
build/keyboard-shortcuts/index.js 2.51 kB 0 B
build/keycodes/index.js 1.94 kB 0 B
build/list-reusable-blocks/index.js 3.12 kB 0 B
build/list-reusable-blocks/style-rtl.css 476 B 0 B
build/list-reusable-blocks/style.css 476 B 0 B
build/media-utils/index.js 5.32 kB 0 B
build/notices/index.js 1.79 kB 0 B
build/nux/index.js 3.4 kB 0 B
build/nux/style-rtl.css 671 B 0 B
build/nux/style.css 668 B 0 B
build/plugins/index.js 2.56 kB 0 B
build/primitives/index.js 1.4 kB 0 B
build/priority-queue/index.js 789 B 0 B
build/redux-routine/index.js 2.85 kB 0 B
build/rich-text/index.js 13.9 kB 0 B
build/server-side-render/index.js 2.71 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.27 kB 0 B
build/url/index.js 4.06 kB 0 B
build/viewport/index.js 1.85 kB 0 B
build/warning/index.js 1.14 kB 0 B
build/wordcount/index.js 1.17 kB 0 B

compressed-size-action
@nosolosw
Copy link
Member

@nosolosw nosolosw commented Aug 26, 2020

Tested "Fix specificity for buttons with outline style and background colors" with TwentyTwenty and TwentyNineteen and works fine.
@nosolosw
Copy link
Member

@nosolosw nosolosw commented Aug 26, 2020

Tested "Fix missing selected block highlighting in list view" and works fine.
@nosolosw
Copy link
Member

@nosolosw nosolosw commented Aug 26, 2020

Tested "Fix tiny editor preview when using Mobile or Tablet options with metaboxes enabled" (with yoast seo, with big & small posts) and works fine.
@nosolosw
Copy link
Member

@nosolosw nosolosw commented Aug 26, 2020

Tested "Fix regression bug for category select in QueryControls component" by using the latest post block. I also ran npm run test locally as suggested and got some unrelated errors (same ones that we have in CI).
@nosolosw
Copy link
Member

@nosolosw nosolosw commented Aug 26, 2020

Tested "Fix incorrect aria description in List View" and works fine.
@nosolosw
nosolosw approved these changes Aug 26, 2020
View changes
@jorgefilipecosta jorgefilipecosta merged commit 2e91aa2 into wp/5.5 Aug 26, 2020
12 of 14 checks passed
12 of 14 checks passed
All All
Details
JavaScript JavaScript
Details
Check Check
Details
build
Details
Admin - 1
Details
pull-request-automation
Details
pull-request-automation
Details
test (gutenberg-editor-gallery)
Details
test (gutenberg-editor-gallery)
Details
Admin - 2
Details
PHP
Details
Admin - 3
Details
Mobile
Details
Admin - 4
Details
@jorgefilipecosta jorgefilipecosta deleted the try/wp/5.5 branch Aug 26, 2020
@jorgefilipecosta
Copy link
Member Author

@jorgefilipecosta jorgefilipecosta commented Aug 26, 2020

Changes:

  • @wordpress/block-directory: 1.13.6 => 1.13.7
  • @wordpress/block-editor: 4.3.6 => 4.3.7
  • @wordpress/block-library: 2.22.6 => 2.22.7
  • @wordpress/components: 10.0.5 => 10.0.6
  • @wordpress/edit-navigation: 1.3.6 => 1.3.7 (private)
  • @wordpress/edit-post: 3.21.6 => 3.21.7
  • @wordpress/edit-site: 1.11.6 => 1.11.7
  • @wordpress/edit-widgets: 0.20.6 => 0.20.7 (private)
  • @wordpress/editor: 9.20.6 => 9.20.7
  • @wordpress/format-library: 1.22.6 => 1.22.7
  • @wordpress/interface: 0.7.5 => 0.7.6
  • @wordpress/list-reusable-blocks: 1.21.5 => 1.21.6
  • @wordpress/nux: 3.20.5 => 3.20.6
  • @wordpress/react-native-editor: 1.31.6 => 1.31.7 (private)
@jorgefilipecosta jorgefilipecosta mentioned this pull request Aug 26, 2020
Closed
nylen pushed a commit to nylen/wordpress-develop-svn that referenced this pull request Aug 27, 2020
jorgefilipecosta
Editor: update packages.
Loading status checks…
1ed3fef 
The following package versions were changed:
@wordpress/block-directory: 1.13.6 -> 1.13.7
@wordpress/block-editor: 4.3.6 -> 4.3.7
@wordpress/block-library: 2.22.6 -> 2.22.7
@wordpress/components: 10.0.5 -> 10.0.6
@wordpress/edit-post: 3.21.6 -> 3.21.7
@wordpress/editor: 9.20.6 -> 9.20.7
@wordpress/format-library: 1.22.6 -> 1.22.7
@wordpress/list-reusable-blocks: 1.21.5 -> 1.21.6
@wordpress/nux: 3.20.5 -> 3.20.6
@wordpress/server-side-render: 1.16.5 -> 1.16.6
Includes PR WordPress/gutenberg#24828

Props nosolosw, desrosj, SergeyBiryukov, youknowriad.
Fixes: #51151.

git-svn-id: https://develop.svn.wordpress.org/trunk@48884 602fd350-edb4-49c9-b593-d223f7449a82
pento pushed a commit to WordPress/wordpress-develop that referenced this pull request Aug 27, 2020
@jorgefilipecosta
Editor: update packages.
Loading status checks…
fb04a13 
The following package versions were changed:
@wordpress/block-directory: 1.13.6 -> 1.13.7
@wordpress/block-editor: 4.3.6 -> 4.3.7
@wordpress/block-library: 2.22.6 -> 2.22.7
@wordpress/components: 10.0.5 -> 10.0.6
@wordpress/edit-post: 3.21.6 -> 3.21.7
@wordpress/editor: 9.20.6 -> 9.20.7
@wordpress/format-library: 1.22.6 -> 1.22.7
@wordpress/list-reusable-blocks: 1.21.5 -> 1.21.6
@wordpress/nux: 3.20.5 -> 3.20.6
@wordpress/server-side-render: 1.16.5 -> 1.16.6
Includes PR WordPress/gutenberg#24828

Props nosolosw, desrosj, SergeyBiryukov, youknowriad.
Fixes: #51151.

git-svn-id: https://develop.svn.wordpress.org/trunk@48884 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith pushed a commit to markjaquith/WordPress that referenced this pull request Aug 27, 2020
@jorgefilipecosta
Editor: update packages.
e9e6e0d 
The following package versions were changed:
@wordpress/block-directory: 1.13.6 -> 1.13.7
@wordpress/block-editor: 4.3.6 -> 4.3.7
@wordpress/block-library: 2.22.6 -> 2.22.7
@wordpress/components: 10.0.5 -> 10.0.6
@wordpress/edit-post: 3.21.6 -> 3.21.7
@wordpress/editor: 9.20.6 -> 9.20.7
@wordpress/format-library: 1.22.6 -> 1.22.7
@wordpress/list-reusable-blocks: 1.21.5 -> 1.21.6
@wordpress/nux: 3.20.5 -> 3.20.6
@wordpress/server-side-render: 1.16.5 -> 1.16.6
Includes PR WordPress/gutenberg#24828

Props nosolosw, desrosj, SergeyBiryukov, youknowriad.
Fixes: #51151.
Built from https://develop.svn.wordpress.org/trunk@48884


git-svn-id: http://core.svn.wordpress.org/trunk@48646 1a063a9b-81f0-0310-95a4-ce76da25c4cd
gMagicScott pushed a commit to gMagicScott/core.wordpress-mirror that referenced this pull request Aug 27, 2020
@jorgefilipecosta
Editor: update packages.
a326f5d 
The following package versions were changed:
@wordpress/block-directory: 1.13.6 -> 1.13.7
@wordpress/block-editor: 4.3.6 -> 4.3.7
@wordpress/block-library: 2.22.6 -> 2.22.7
@wordpress/components: 10.0.5 -> 10.0.6
@wordpress/edit-post: 3.21.6 -> 3.21.7
@wordpress/editor: 9.20.6 -> 9.20.7
@wordpress/format-library: 1.22.6 -> 1.22.7
@wordpress/list-reusable-blocks: 1.21.5 -> 1.21.6
@wordpress/nux: 3.20.5 -> 3.20.6
@wordpress/server-side-render: 1.16.5 -> 1.16.6
Includes PR WordPress/gutenberg#24828

Props nosolosw, desrosj, SergeyBiryukov, youknowriad.
Fixes: #51151.
Built from https://develop.svn.wordpress.org/trunk@48884


git-svn-id: https://core.svn.wordpress.org/trunk@48646 1a063a9b-81f0-0310-95a4-ce76da25c4cd
pento pushed a commit to WordPress/wordpress-develop that referenced this pull request Aug 27, 2020
@jorgefilipecosta
Editor: update packages.
Loading status checks…
0c1b1e1 
The following package versions were changed:
@wordpress/block-directory: 1.13.6 -> 1.13.7
@wordpress/block-editor: 4.3.6 -> 4.3.7
@wordpress/block-library: 2.22.6 -> 2.22.7
@wordpress/components: 10.0.5 -> 10.0.6
@wordpress/edit-post: 3.21.6 -> 3.21.7
@wordpress/editor: 9.20.6 -> 9.20.7
@wordpress/format-library: 1.22.6 -> 1.22.7
@wordpress/list-reusable-blocks: 1.21.5 -> 1.21.6
@wordpress/nux: 3.20.5 -> 3.20.6
@wordpress/server-side-render: 1.16.5 -> 1.16.6
Includes PR WordPress/gutenberg#24828

Props nosolosw, desrosj, SergeyBiryukov, youknowriad.
Merges [48884] to the 5.5 branch.
Fixes: #51151.

git-svn-id: https://develop.svn.wordpress.org/branches/5.5@48885 602fd350-edb4-49c9-b593-d223f7449a82
markjaquith pushed a commit to markjaquith/WordPress that referenced this pull request Aug 27, 2020
@jorgefilipecosta
Editor: update packages.
5228943 
The following package versions were changed:
@wordpress/block-directory: 1.13.6 -> 1.13.7
@wordpress/block-editor: 4.3.6 -> 4.3.7
@wordpress/block-library: 2.22.6 -> 2.22.7
@wordpress/components: 10.0.5 -> 10.0.6
@wordpress/edit-post: 3.21.6 -> 3.21.7
@wordpress/editor: 9.20.6 -> 9.20.7
@wordpress/format-library: 1.22.6 -> 1.22.7
@wordpress/list-reusable-blocks: 1.21.5 -> 1.21.6
@wordpress/nux: 3.20.5 -> 3.20.6
@wordpress/server-side-render: 1.16.5 -> 1.16.6
Includes PR WordPress/gutenberg#24828

Props nosolosw, desrosj, SergeyBiryukov, youknowriad.
Merges [48884] to the 5.5 branch.
Fixes: #51151.
Built from https://develop.svn.wordpress.org/branches/5.5@48885


git-svn-id: http://core.svn.wordpress.org/branches/5.5@48647 1a063a9b-81f0-0310-95a4-ce76da25c4cd
gMagicScott pushed a commit to gMagicScott/core.wordpress-mirror that referenced this pull request Aug 27, 2020
@jorgefilipecosta
Editor: update packages.
c6d73db 
The following package versions were changed:
@wordpress/block-directory: 1.13.6 -> 1.13.7
@wordpress/block-editor: 4.3.6 -> 4.3.7
@wordpress/block-library: 2.22.6 -> 2.22.7
@wordpress/components: 10.0.5 -> 10.0.6
@wordpress/edit-post: 3.21.6 -> 3.21.7
@wordpress/editor: 9.20.6 -> 9.20.7
@wordpress/format-library: 1.22.6 -> 1.22.7
@wordpress/list-reusable-blocks: 1.21.5 -> 1.21.6
@wordpress/nux: 3.20.5 -> 3.20.6
@wordpress/server-side-render: 1.16.5 -> 1.16.6
Includes PR WordPress/gutenberg#24828

Props nosolosw, desrosj, SergeyBiryukov, youknowriad.
Merges [48884] to the 5.5 branch.
Fixes: #51151.
Built from https://develop.svn.wordpress.org/branches/5.5@48885


git-svn-id: https://core.svn.wordpress.org/branches/5.5@48647 1a063a9b-81f0-0310-95a4-ce76da25c4cd
27pchrisl added a commit to 27partners/gutenberg that referenced this pull request Oct 27, 2020
@jorgefilipecosta @talldan
@nosolosw @gchtr @27pchrisl
WordPress 5.5.1 Backports (WordPress#24828)
Loading status checks…
25b2b9b 
Co-authored-by: Daniel Richards <daniel.richards@automattic.com>
Co-authored-by: Andrés <nosolosw@users.noreply.github.com>
Co-authored-by: Lukas Gächter <lukas.gaechter@mind.ch>
27pchrisl added a commit to 27partners/gutenberg that referenced this pull request Oct 27, 2020
@27pchrisl
Merge pull request #2 from 27partners/feature/backport-5.5
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a687efb 
WordPress 5.5.1 Backports (WordPress#24828)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nosolosw nosolosw

@youknowriad youknowriad

@talldan talldan

@Soean Soean

@ajitbohra ajitbohra

@chrisvanpatten chrisvanpatten

@ellatrix ellatrix

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@jorgefilipecosta @nosolosw @talldan @gchtr
You can’t perform that action at this time.