WordPress.org

Make WordPress Core

Opened 11 hours ago

Last modified 13 minutes ago

#48776 new defect (bug)

Empty "Continue" Buttons in install process

Reported by: derweili Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version: 4.0
Component: Upgrade/Install Keywords: needs-patch
Focuses: javascript Cc:
PR Number:

Description

When installing WordPress the first step is to select a Language. When selecting a language the "Continue" button instantly changes its text to the translation of "Continue" in the selected language.

For some languages which do not have a translation of "Continue" no fallback is used. Instead the Button is Empty.

This happens for following Languages (Language Codes)

  • as
  • dzo
  • rhg
  • tah

Some other Languages like "azb" are using the english version als fallback.

All available Languages are loaded from this api Endpoint:
http://api.wordpress.org/translations/core/1.0/

The data from the api contains following information

  {
    "language": "dzo",
    "version": "4.7.2",
    "updated": "2016-06-29 08:59:03",
    "english_name": "Dzongkha",
    "native_name": "རྫོང་ཁ",
    "package": "http://downloads.wordpress.org/translation/core/4.7.2/dzo.zip",
    "iso": {
      "1": "dz",
      "2": "dzo"
    },
    "strings": {
     "continue": ""
    }
  },

The continue field which is used for the continue button is empty.

Attachments (2)

48776.patch (461 bytes) - added by sathyapulse 10 hours ago.
48776.patch
48776.1.patch (3.0 KB) - added by sathyapulse 10 hours ago.
The patch addresses the problem in the server side and refactors the existing code to remove duplicates.

Download all attachments as: .zip

Change History (5)

#1 @ocean90
10 hours ago

  • Focuses javascript added
  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to Future Release
  • Version changed from 5.3 to 4.0

In language-chooser.js, the line which overrides the value attribute could be changed to value: option.data( 'continue' ) || 'Continue',

@sathyapulse
10 hours ago

48776.patch

@sathyapulse
10 hours ago

The patch addresses the problem in the server side and refactors the existing code to remove duplicates.

#2 @tobifjellner
49 minutes ago

I have now temporarily patched this problem "from the other side" by "translating" the missing strings to "Continue" for the four locales mentioned above.

A stable solution of this problem could perhaps more nicely be made by fixing the output of the api (which would be a fix in meta). The good thing about that approach is that one fix would automatically correct the problem also for recent versions of WordPress core.

#3 @tobifjellner
13 minutes ago

I have opened a corresponding Meta ticket: https://meta.trac.wordpress.org/ticket/4872
If that one is accepted by the Meta team, then this ticket could be closed as "Reported upstream".

Note: See TracTickets for help on using tickets.