Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backports for 5.6 Beta 3 #26588

Merged
merged 11 commits into from Nov 2, 2020
Merged

Backports for 5.6 Beta 3 #26588

merged 11 commits into from Nov 2, 2020

Conversation

@tellthemachines
Copy link
Contributor

@tellthemachines tellthemachines commented Oct 30, 2020

Description

Included:

Nest content styles in container for higher specificity (#26487)
Reusable Blocks: Make the number retrieved from the API unlimited (#26486 )
Fix block inserter WSOD when an empty reusable block exists (#26484)
Latest Posts: Bring back classname on post list (#26477)
[Heading Block] Fix double alignment controls in toolbar (#26492)
URLInput: Use debounce() instead of throttle() (#26529)
Fix single column block display for smaller screens. (#26438)
Fix incorrectly pluralised strings (#26565)
Ensure footer remains position fixed when navigating regions (#26533)
Removes extra fullstop (#26586)

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.
  • I've included developer documentation if appropriate.
  • I've updated all React Native files affected by any refactorings/renamings in this PR.
Addison-Stavlo and others added 9 commits Oct 27, 2020
…6486)

* Make the number of reusable blocks returned from the API unlimited

This is to fix #26352. Having no limit seems like it could be risky, but
there are a number of other places in the codebase where all entities
are returned in one call to the API, including categories, which could
return a similar amount of data to this.

* Remove unnecessary quotes to fix lint error.
* fix heading alignments

* add proper supports in deprecation

* update all previous deprecations

* regenerate fixtures for heading

* change migration call

* remove previous className + revert saves

* Revert "regenerate fixtures for heading"

This reverts commit 27af8c3.

* change fixtures

* create new fixtures + fix deprecation save

* address review feedback
Wait until the user finishes typing before sending an AJAX request. This
ensures that there isn't an AJAX request sent every 200 ms while the
user is typing.
If there is only one column, don't force a 50% flex-basis for small screens.
* Change block mover label i18n

* Update remove block i18n
@tellthemachines tellthemachines added this to Needs Review in WordPress 5.6 Must Haves via automation Oct 30, 2020
@github-actions
Copy link

@github-actions github-actions bot commented Oct 30, 2020

Size Change: +297 B (0%)

Total Size: 1.2 MB

Filename Size Change
build/block-editor/index.js 130 kB +10 B (0%)
build/block-editor/style-rtl.css 11 kB +8 B (0%)
build/block-editor/style.css 11 kB +8 B (0%)
build/block-library/index.js 144 kB +104 B (0%)
build/block-library/style-rtl.css 7.7 kB +12 B (0%)
build/block-library/style.css 7.7 kB +13 B (0%)
build/edit-post/index.js 306 kB -1 B
build/edit-post/style-rtl.css 6.39 kB +21 B (0%)
build/edit-post/style.css 6.37 kB +20 B (0%)
build/edit-site/style-rtl.css 3.83 kB +28 B (0%)
build/edit-site/style.css 3.83 kB +27 B (0%)
build/edit-widgets/style-rtl.css 3.11 kB +24 B (0%)
build/edit-widgets/style.css 3.11 kB +22 B (0%)
build/editor/index.js 42.6 kB +1 B
ℹ️ View Unchanged
Filename Size Change
build/a11y/index.js 1.14 kB 0 B
build/annotations/index.js 3.54 kB 0 B
build/api-fetch/index.js 3.35 kB 0 B
build/autop/index.js 2.72 kB 0 B
build/blob/index.js 668 B 0 B
build/block-directory/index.js 8.6 kB 0 B
build/block-directory/style-rtl.css 943 B 0 B
build/block-directory/style.css 942 B 0 B
build/block-library/editor-rtl.css 8.93 kB 0 B
build/block-library/editor.css 8.93 kB 0 B
build/block-library/theme-rtl.css 741 B 0 B
build/block-library/theme.css 741 B 0 B
build/block-serialization-default-parser/index.js 1.77 kB 0 B
build/block-serialization-spec-parser/index.js 3.1 kB 0 B
build/blocks/index.js 47.6 kB 0 B
build/components/index.js 170 kB 0 B
build/components/style-rtl.css 15.4 kB 0 B
build/components/style.css 15.4 kB 0 B
build/compose/index.js 9.63 kB 0 B
build/core-data/index.js 12.1 kB 0 B
build/data-controls/index.js 684 B 0 B
build/data/index.js 8.63 kB 0 B
build/date/index.js 31.9 kB 0 B
build/deprecated/index.js 772 B 0 B
build/dom-ready/index.js 569 B 0 B
build/dom/index.js 4.43 kB 0 B
build/edit-navigation/index.js 10.6 kB 0 B
build/edit-navigation/style-rtl.css 868 B 0 B
build/edit-navigation/style.css 871 B 0 B
build/edit-site/index.js 21.6 kB 0 B
build/edit-widgets/index.js 26.6 kB 0 B
build/editor/editor-styles-rtl.css 480 B 0 B
build/editor/editor-styles.css 482 B 0 B
build/editor/style-rtl.css 3.85 kB 0 B
build/editor/style.css 3.84 kB 0 B
build/element/index.js 4.45 kB 0 B
build/escape-html/index.js 733 B 0 B
build/format-library/index.js 7.49 kB 0 B
build/format-library/style-rtl.css 547 B 0 B
build/format-library/style.css 548 B 0 B
build/hooks/index.js 1.74 kB 0 B
build/html-entities/index.js 622 B 0 B
build/i18n/index.js 3.54 kB 0 B
build/is-shallow-equal/index.js 709 B 0 B
build/keyboard-shortcuts/index.js 2.39 kB 0 B
build/keycodes/index.js 1.85 kB 0 B
build/list-reusable-blocks/index.js 3.02 kB 0 B
build/list-reusable-blocks/style-rtl.css 476 B 0 B
build/list-reusable-blocks/style.css 476 B 0 B
build/media-utils/index.js 5.12 kB 0 B
build/notices/index.js 1.69 kB 0 B
build/nux/index.js 3.27 kB 0 B
build/nux/style-rtl.css 671 B 0 B
build/nux/style.css 668 B 0 B
build/plugins/index.js 2.44 kB 0 B
build/primitives/index.js 1.35 kB 0 B
build/priority-queue/index.js 789 B 0 B
build/redux-routine/index.js 2.85 kB 0 B
build/reusable-blocks/index.js 3.06 kB 0 B
build/rich-text/index.js 13 kB 0 B
build/server-side-render/index.js 2.61 kB 0 B
build/shortcode/index.js 1.7 kB 0 B
build/token-list/index.js 1.24 kB 0 B
build/url/index.js 4.06 kB 0 B
build/viewport/index.js 1.75 kB 0 B
build/warning/index.js 1.13 kB 0 B
build/wordcount/index.js 1.23 kB 0 B

compressed-size-action

@talldan
talldan approved these changes Nov 2, 2020
Copy link
Contributor

@talldan talldan left a comment

The tests seem to pass fine locally, so I'm unsure about the failures, especially the Adding Patterns one, which doesn't happen in master.

The changes are pretty straightforward and there doesn't seem to be anything that would cause an issue with those tests, so approving.

@tellthemachines tellthemachines merged commit fda29eb into wp/trunk Nov 2, 2020
13 of 15 checks passed
13 of 15 checks passed
Admin - 1 Admin - 1
Details
Compare performance with master Compare performance with master
Details
Cancel Previous Runs Cancel Previous Runs
Details
Check Check
Details
build
Details
pull-request-automation
Details
test (gutenberg-editor-gallery)
Details
test (gutenberg-editor-gallery)
Details
All
Details
JavaScript
Details
Admin - 2
Details
PHP
Details
Admin - 3
Details
Mobile
Details
Admin - 4
Details
WordPress 5.6 Must Haves automation moved this from Needs Review to Done Nov 2, 2020
@tellthemachines tellthemachines deleted the wp/trunk-5-6-beta-3 branch Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Linked issues

Successfully merging this pull request may close these issues.

None yet

10 participants
You can’t perform that action at this time.