Make WordPress Core

Keyboard Shortcuts | Hide comment threads

CSS Chat Summary: 22 July 2021

The meeting took place here on Slack. @notlaura facilitated and @danfarrow wrote up these notes.

Housekeeping

  • No housekeeping items this week

Custom Properties (#49930)

  • @notlaura shared some background on the project for new participants and suggested another session of individual work time
  • @notlaura added a note to the trac ticket indicating who has “claimed” particular core CSS files

30 or so minutes later…

  • @Dave Ryan reported having made solid progress on login.css & finding some near-duplicate shades of blue, for which he added new custom properties. Work on colour unification can come later
  • @notlaura had a similar experience with shades of grey and agreed with the approach. @Dave Ryan added a note about it to the shared doc

CSS Link Share / Open Floor

Thanks everyone!

#core-css, #summary

Dev Chat Agenda for July 28, 2021

Here is the agenda for this week’s developer meeting to occur at Wednesday, July 28, 2021 at 08:00 PM UTC.

Blog Post Highlights

5.8 Review

Components check-in and status updates

  • Check-in with each component for status updates.
  • Poll for components that need assistance.

Open Floor

Do you have something to propose for the agenda, or a specific item relevant to the usual agenda items above?

Please leave a comment, and say whether or not you’ll be in the chat, so the group can either give you the floor or bring up your topic for you accordingly.

This meeting happens in the #core channel. To join the meeting, you’ll need an account on the Making WordPress Slack.

#5-8, #agenda, #core, #dev-chat

  • Remaining tasks from Releasing Major Versions handbook:
    • Run the DocBlocks parser for DevHub.

As far as I can tell, that has already been done. For instance, the filter block_categories_all was adding in 5.8 and is in the Code Reference.

Thanks @pbiron, marking this as checked alongside the update of the history page since I took care of that task ✅

CSS Chat Summary: 15 July 2021

The meeting took place here on Slack. @notlaura facilitated and @danfarrow wrote up these notes.

Housekeeping

  • @notlaura wondered how we could encourage participation at the chats, and get more help with the Custom Properties project. She suggested maybe some guidelines on how to get started contributing
  • @danfarrow offered to add some notes to the shared document
  • @notlaura also suggested a “Call for CSS contributors” Make post linking to the shared document and offered to work on writing that

Custom Properties (#49930)

  • @notlaura suggested spending some time working individually on the project which is something we’ve tried at previous meetings with great success

20 minutes later…

  • @notlaura used the time to write a draft of the previously mentioned Make post
  • @danfarrow started updating forms.css noting that some custom properties have a longer ancestry e.g. --wp-admin--button--text takes its value from --wp-admin--button-primary, which in turn takes its value from --wp-admin--theme--primary. He speculated that tooling could make it easier to traverse & understand this hierarchy

CSS Link Share / Open Floor

Thanks everyone!

#core-css, #summary

A Week in Core – July 26, 2021

Welcome back to a new issue of Week in Core. Let’s take a look at what changed on Trac between July 19 and July 26, 2021.

  • 24 commits
  • 23 contributors
  • 103 tickets created
  • 18 tickets reopened
  • 68 tickets closed

Please note that as expected, WordPress 5.8 was released last week, on Tuesday July 20, 2021 🌟

Ticket numbers are based on the Trac timeline for the period above. The following is a summary of commits, organized by component and/or focus.

Code changes

Build/Test Tools

  • Rename classes in phpunit/tests/widgets/ per the naming conventions – #53363
  • Rename classes in phpunit/tests/sitemaps/ per the naming conventions – #53363
  • Rename classes in phpunit/tests/blocks/ per the naming conventions – #53363
  • Move and fix incorrectly placed tests for block supported styles – #53363
  • Use better assertions in WP_UnitTestCase_Base::assertEqualFields(): – #53363
  • Modernize the WP_UnitTestCase_Base::assertEqualFields() method: – #53363
  • Correct placement of the $message parameter in assertDiscardWhitespace()#53363
  • Add a $message parameter for custom assertions in WP_UnitTestCase_Base#53363
  • Correct class name for WP_Filesystem_Base::find_folder() tests – #53363
  • Update PHP_CodeSniffer to version 3.6.0 – #53477

Bundled Themes

  • Version Bump 2010, 2011 and 2012 – #53777
  • Bundled Themes: Use correct path for loading images in block patterns – #53769
  • Twenty Ten: Use correct path for loading block patterns – #53752

Media

  • Check the posts_per_page value in wp_ajax_query_attachments() before using it as a divisor – #53773
  • Media: Remove unused code from wp-admin/includes/media.php#53764

Documentation

  • Miscellaneous docblock corrections and improvements – #53399
  • Add a comment about the $title global usage in various admin files – #53729
  • Correct a comment about WebP constants in wp-includes/compat.php#53680

Help/About

  • Add / character to img and source tags – #53716

Internationalization

  • Fix broken loop in WP_Theme_JSON_Resolver

Editor

  • Conditionally load registered styles for block variations – #53616

External Libraries

  • Correct the underscore version used when registering – #53713
  • Correct the jquery-form version used when registering – #53714
  • Correct the hoverIntent version used when registering – #53715

Props

Thanks to the 23 people who contributed to WordPress Core on Trac last week: @jrf (5), @audrasjb (4), @sabernhardt (3), @david.binda (3), @hellofromTonya (2), @aristath (2), @SergeyBiryukov (1), @schlessera (1), @TobiasBg (1), @ankitmaru (1), @radixweb (1), @rtm909 (1), @GaryJ (1), @dd32 (1), @ravipatel (1), @peterwilsoncc (1), @loranrendel (1), @ryelle (1), @rudlinkon (1), @youknowriad (1), @kapilpaul (1), @2linctools (1), and @johnbillion (1).

Congrats and welcome to our 5 new contributors of the week! @radixweb, @rtm909, @loranrendel, @rudlinkon, and @2linctools ♥️

Core committers: @sergeybiryukov (17), @desrosj (3), @gziolo (2), @peterwilsoncc (1), and @johnbillion (1).

#5-8, #week-in-core

Editor Chat Agenda: 28 July 2021

Facilitator and notetaker @ajitbohra

This is the agenda for the weekly editor chat scheduled for Wednesday, 28 July 2021, 14:00 UTC.

This meeting is held in the #core-editor channel in the Making WordPress Slack.

Even if you can’t make the meeting, you’re encouraged to share anything relevant for the meeting in the comments below:

  • If you have anything to share for the Task Coordination section, please leave it as a comment on this post.
  • If you have anything to propose for the agenda or other specific items related to those listed above, please leave a comment below.

#core-editor #core-editor-agenda #agenda #meetings

For task coordination:
Landed a fix for the immediate issue in http://wayback.fauppsala.se:80/wayback/20210728150719/https://github.com/WordPress/gutenberg/issues/31515. Going to create a followup issue and PR to discuss if a deeper fix would be helpful.

For open floor:
If it’s okay, I’d be interested in shadowing someone close to my timezone (JST, so I’m guessing APAC or EU would work best) on a Gutenberg release, to learn more about what’s involved.

I’d eventually love to be able to help with running one, and hoping that would help with learning about the knowledge gaps to fill.

I won’t be here but…

For Task Coordination:

For Open Floor:

  • Could whoever is running the Gutenberg Plugin release today please let me know how they found the automated changelog feature grouping? I worked on a couple of PRs on that and I’m curious to know whether anything could be improved. My DM’s are open 🙂
  • Also on that note, please can I make a plea for folks to consider being even more proactive in assigning labels to Github Issues? With the correct labels assigned creating the release changelog can be far more automated. I’ve noticed a number of recent PRs without any labels and so I’m hopeful that we can reverse that trend for the benefit of the release leads. Much appreciated 🙇🏻‍♂️

Dev Chat Summary: July 21, 2021

@desroj led the weekly meeting at 20:00 UTC. Here is the meeting agenda.

Link to 20:00 UTC <dev-chat> in #core on Making WordPress Slack

Notable news and blog posts

WordPress 5.8 was released yesterday(July 20, 2021)! The new release was downloaded 7.7 million times in a little over 24 hours.

What’s next in Gutenberg?

What’s new in Gutenberg 11.1.0?

Requests for Feedback

Component Team Updates

Build/Test Tools

  • Ongoing modernization of PHPUnit tests. #53363
  • PHP_CodeSniffer updated to 3.6 (with PHP 8 support) #53477

Auto-Updates

Themes

Open Floor

  • @desroj highlighted a bug in the Multisite Filesystem API that was requested to be prioritized in 5.9.
  • @chanthaboune raised a discussion about Making WordPress Slack — what we can/should use it for. Should #core be the default channel? Should some other Slack channel be created to greet new users (who may or may not have context entering Slack that it is mostly a working environment)? This was a lively discussion, please add more thoughts in the comments below!
  • While it’s been a fairly quiet (some might say too quiet) and smooth release, @chanthaboune encouraged the hosting (and greater) community to check-in with support folks and report back any trends. @johnbillion also noted a handful of tickets about Widgets have been opened related to “widget customisation and logic plugins.”

Watch For

Interested in volunteering for upcoming WordPress releases? Please comment below and team reps will reach out!

Props to @dryanpress for taking these #summary notes!

#dev-chat

CSS Chat Agenda: July 22, 2021

This is the agenda for the upcoming CSS meeting scheduled for Thursday July 22 at 21:00PM UTC.

The meeting will be held in the #core-css channel in the Making WordPress Slack.

  • Housekeeping
  • Custom Properties (#49930)
    • Discussion as needed
    • Work time
  • Open Floor + CSS Link Share

If there’s any topic you’d like to discuss, please leave a comment below!

#agenda, #core-css

Editor chat summary: 21 July, 2021

This post summarizes the weekly editor chat meeting (agenda here) held on Wednesday, July 21, 2021 at 02:00 PM UTC on Slack. Moderated by @andraganescu.

Announcements

Monthly Priorities & Key Project Updates

Block based Widget Editor

As the project has landed in core, there is now a new tracking issue set up for things identified by the community as great follow up work to improve on it.

Mobile Team

  • Shipping: Block picker search and first iteration of the embed block will be shipping in the next release.
  • In Progress: Scoping the next phase of Global Style Support work focusing on text-related styles.

Task Coordination

@ntsekouras

  • Landed SegmentedControl (PR: 31937)
  • I’m working on porting some more components from g2 and will make explorations for more layout integrations. Related Riad’s PR (PR: 33359)

@torounit

  • I am working on refactoring HierarchicalTermSelector (PR: 33418)

@zieladam

@mamaduka

  • Started refactoring FlatTermSelector into a functional component and utilize core data module for fetching terms.
  • While working on this discovered a few minor issues with the “Most Used Terms” component, which should be fixed now.
  • Also, now users with author roles should be able to set featured images uploaded by other users.

@aristath

  • Autogenerate headings anchors – PR: 30825.
  • Allow enqueing multiple stylesheets per-block – PR: 32510.

@getdave

  • I improved the build tooling by automatically grouping changelog items by feature when it is build on CI PR: 33229.

@ajlende

  • Cropping for the site logo needs reviewers PR: 31607.
  • Working on duotone enhancements we can discuss more during open floor PR: 33466.
  • Related bug fix for cover block spacing ui PR: 33560.

Open Floor

A test file was added to WP Core in 5.6.0, but added incorrectly, which means that the tests effectively were never run. I’m trying to fix that, but am now finding that 7 out of the 20 tests are failing. Raised by @jrf

We need someone with good knowledge of global styles to help figuring out if the test’s problem is on the PHP or JS side of the global styles.

@torounit surfaced issue 33589

This is probably a bug introduced by the recent work on the “select all” behavior in the block editor.

@ntsekouras surfaced a problem in PR: 1483 – It seems there will be the need for WP version check in patterns

The problem lies that patterns can have blocks with shape that is not supported in a WP version, but themes are also checked against WP version that are compatible. This isn’t the same WP version usually.

@ajlende asked if more people think it might be beneficial to have a system to that allow block supports to detect placeholder state.

General support for the idea was offered.

@mikeschroder raised PR: 32516 and asked if this direction is a good approach.

Looking forward for feedback from folks who know the rich-text package and can provide advice. Does that seem along the right lines for a fix?

#core-editor, #core-editor-summary

[Request for feedback] Updater Proof of Concept

Over the past month, @aristath and @sergeybiryukov have been working on a proof of concept to solve the two first outcomes highlighted in the Updater Initiative scope post.

They drew inspiration from the http://wayback.fauppsala.se:80/wayback/20210728150719/https://wordpress.org/plugins/rollback-update-failure/ plugin and tried to address a few tickets.

They created a proof of concept that can be found in a draft PR on http://wayback.fauppsala.se:80/wayback/20210728150719/https://github.com/WordPress/wordpress-develop/pull/1492/files and does the following:

  • Add new arguments to hook_extra passed by plugin and theme updates to ensure we can rollback to the correct version.
  • After a plugin/theme is successfully downloaded and extracted, the old plugin/theme folder is moved to wp-content/upgrade/rollback/plugins/PLUGIN or wp-content/upgrade/themes/THEME wp-content/upgrade/rollback/themes/THEME (thanks Paul Bigai for catching that)
  • If the plugin/theme was successfully installed, the backup of the previous version we kept in wp-content/upgrade/rollback/ is deleted.
  • If the plugin/theme was not successfully installed, then we cleanup any remnants of files in wp-content/plugins/PLUGIN (or the corresponding folder for themes), and then we move the backup we kept in the rollbacks folder back to its original location.
  • Adds info in the site-health screen, to make sure the rollback folder is writable (or can be created if it doesn’t exist)

That is the basic concept. The team ran some tests, helped by @peona as well and it seems to be working.

The main difference with the rollback-update-failure plugin is that this solution moves the plugin/theme folders instead of zipping/unzipping them. This change should help to make the implementation a bit lighter/safer on shared hosts with limited resources.

Before moving forward, I would like to ask the Upgrade/Install Maintainers to have a look at this and discuss together, in the comments of this post, if you agree with this change, if it works, etc…

I am not setting a deadline for the comments, but ideally, I would like to be able to write a merge proposal for 5.9 so I will review the post in mid-JulyAugust (thanks @meher for pointing out that we are at the end of July already 😂) and nudge a bit more 😉

Thank you all for your help and feedback!

Thanks @ipstenu for the peer review

#updater

Just my first feedback there are any plans like a filter to disable the rollback feature?

I am looking this as security stuff, as usually you update to remove old versions of themes or plugins affected. Also if they are not enabled they can be sources of troubles or have php files that can be called outside wordpress.

I think that something that ensure this is required like htaccess rules to disable the execution of those php file is important or zip those files.

The goal of this project is to make the process of updating a plugin or a theme more secure and less prone to errors.
The “rollback” is not something that stays, it’s a temporary backup of the plugin/theme to be updated, and as soon as the update is successfully completed, that backup is deleted from the filesystem. The rollback’s only purpose is so that in case of an update error, we can restore the site to what it previously was without breaking anything.
These “rollback” folders are not exposed to users, ie they can’t say “I want to rollback this plugin to the previous version I had”, it’s just a transient backup which usually has a lifetime of a few seconds (or as long as it takes to perform an update).
The reason this approach doesn’t go with zipping files, is because zipping a large plugin folder requires significant system resources that a low-end shared host may not be able to spare. Moving the folders is fast, requires practically zero resources, and achieves the goal of having a transient backup to restore if the update fails.

What’s next in Gutenberg? Site Editing status check (Late July-August 2021)

WordPress 5.8 is already here, an exciting release marked by the inclusion of many Full Site Editing features that have been big-picture focuses in recent times. Because of this important achievement, in contrast to normal monthly updates, this post seeks to review the status of Full Site Editing and summarize the next high-level focuses within Gutenberg Phase 2.


Full Site Editing is the lighthouse goal for phase 2 of Gutenberg. As such, it’s good to remember it is a collection of projects that allow site editing with blocks, bringing powerful capabilities for a smooth editing experience.

WordPress 5.8 includes some of these Full Site Editing projects and features; while some of them will continue as ongoing focuses for subsequent Gutenberg releases (⚒️), others can be considered stable and enter a maintenance phase (✅)

Without further ado, let’s look at the current status of the milestones that have guided Full Site Editing work in the last months and the updated scope for Site Editing.

Site Editing Infrastructure and UI

The Site Editing Infrastructure and UI provide foundational work for the rest of FSE projects, mainly in the Site/Template Editor, Template parts, and the numerous APIs that support work around Full Site Editing.

The first two iterations of the site editor milestone introduced editing block themes and all their template files. The ongoing third one offers the possibility of creating custom block templates in classic themes and is available in WordPress 5.8 for those themes that opt-in to the site editing experience. Work will continue to finalize the Site Editor naming and placement: the current Site Editor as we know it in the Gutenberg plugin may evolve for better navigation flows and interactions.

Thanks to feedback from different FSE Outreach Program testing rounds, the next focus for site experience and tooling improvement include:

Overview Issues: ✅ Part 1, ✅ Part 2, ⚒️ Part 3

Global Styles

Global Styles comprises two major areas that fall underneath the global styles umbrella: centralized theme configuration and an interface for manipulating visual aspects of blocks globally.

Theme configuration absorbs things like declaring color palettes, presets, different supports and settings, and toggle on or off the available block design tools (typography, colors, dimensions, etc.). All of this can be managed through the theme.json configuration file and is one of the key features available in WordPress 5.8. After a few iterations and open testing, this feature is considered stable and moved to a maintenance phase.

The other major part of global styles is the user interface to make edits to blocks globally. With theme.json in place, the next release cycle will have the Global Styles UI as one of its main focuses, allowing users to tweak the theme easily. Color handling will be an important focus, not only to better theme switch but also to seamlessly integrate color palettes with patterns.

⚒️ Global Styles Overview Issue

Theme Blocks

To support the theme building needs outside of the template and template parts infrastructure, there was a need to create many new blocks centered around theme functions. WordPress 5.8 brings several of these blocks, from Site Title, Site Tagline, and Site Logo that allow users to configure site settings with blocks, to the post-related blocks such as Post Title and Post Date, to be used inside a Query Loop to display post data.

Although new theme blocks may be added as the need arises and the existing ones will receive incremental upgrades, the basics of this milestone are complete.

Theme blocks Overview Issue

Query Loop Block

Among the theme blocks, the Query Loop Block has been a significant area of the site editing focus in the past months, deserving its own milestone. Taking some of the block API infrastructures to the limit, such a powerful block has proven challenging to expose at a user level. As a result of the feedback collected in the FSE Outreach Program, the block has been renamed to clear confusion, and usability enhancements have been implemented before launching it in WordPress 5.8.

With the Query Loop foundations in place, the next iterations will seek to ease the user interactions and flows, even more, thanks to two fundamental Gutenberg tools – block patterns and block variations. The former will continue to help set the inner block structure and content. In contrast, the latter will present the powerful Query Loop’s features in the form of preconfigured blocks and consolidate similar blocks to use the Query Loop Block as their underlying mechanism.

Query Loop Block Overview Issue

Navigation Block

Along with the Query Loop Block, the Navigation Block is another theme block that stands out as a project in its own right. This block has seen great improvements in the last few months, from improved overlays to responsive menus. New blocks are available as well, such as the Home Link block. Shortly, we will see the Navigation block house whole new kinds of blocks thanks to the recent frontend markup adjustments that allow blocks other than links in an accessible way.

Because of its key role in building rich theme blocks, the Navigation Block will be one primary focus during the next WordPress release cycle. Apart from more blocks being available inside the Navigation Block, customization options – such as configuring dropdown behavior or adding fullscreen variants – are an area that seeks improvement. These customizations should be design-driven due to the multiple layouts nested navigation menus can have.

⚒️ Navigation Block Tracking Issue

Site Editing Gradual adoption

Full Site Editing represents a new paradigm in site and theme building in the well-established WordPress ecosystem, and as such, providing the right tools is key to gradual adoption. Tools like the Widgets Editor and Navigation Editor bring block editing capabilities to traditional features that can’t take full advantage of their native block counterpart implementation.

WordPress 5.8 brings the power of blocks to both the Block Widgets Editor and the Customizer. Users will be able to add blocks in widget areas, add widgets and blocks with live preview, and schedule and share directly from the Customizer.

Because blocks can now be added to widget areas, developers are encouraged to phase out their widgets in favor of blocks, which are more intuitive and can be used in more places. Developers can allow users to easily migrate a Legacy Widget block containing a specific widget to a block or multiple blocks. 

On the other hand, the Navigation Editor has also seen its share of iterative improvements in the last months. Together with the Navigation Block, it will remain an ongoing focus for the next WordPress release cycle.

Widgets Editor Tracking Issue

⚒️ Navigation Editor Tracking Issue

Smoothing block interactions

As mentioned with regards to Query and Navigation blocks, the complexity of the editor increases as site editing capabilities are introduced with advanced block structures and customization options. This highlights the need to expand our APIs and interactions — which are well suited for simple block structures — to better support container blocks.

To address some of this, the List View introduced in Gutenberg 10.7, and WordPress 5.8 aims to help navigate these advanced structures more efficiently and should continue evolving further in the future. Internally, the List View is powered by a component available in the post editor List View and advanced blocks like Navigation; all features and blocks having a list of blocks will benefit from the improvements made to this component.

Another challenging editing experience with the increased number of container and inner blocks is adjusting parent block settings when editing a child block.  Users often need to switch between different child and parent blocks to change settings like layout or positioning. In turn, it is necessary to explore Toolbar absorption mechanisms that allow parent blocks to expose their toolbar on their children.

Patterns everywhere

At this stage, it is no secret that block patterns represent considerable potential for users to add many blocks with different preset layouts and settings easily. By using patterns, users don’t need to individually add blocks to achieve rich representations in headers, columns, or Query blocks, as patterns act as a jumpstart blueprint that can be tweaked and adjusted to the user’s needs. 

An example of the improved interaction block patterns is demonstrated by the Query block, which allows users to select block patterns in its placeholder state. This is just the tip of the iceberg in terms of the ways patterns can leverage the editing experience, and as such, efforts will continue improving pattern insertion capabilities.

Thanks to the recently released Block Pattern Directory, patterns can be copied and pasted into the block editor; upcoming Gutenberg iterations will connect and retrieve patterns from this directory, allowing users to choose from huge amounts of beautiful patterns without leaving the editor. Both to ease navigating the big number of patterns users will be able to choose from and accommodate increased pattern complexity and richness, such as in Query or Header patterns, revisiting the pattern insertion UI will be an ongoing focus in the months to come.

 ⚒️ Pattern Insertion Tracking Issue

Design Tools

Several design tools are needed to ​​ensure a wide range of exquisitely crafted patterns can support powerful settings and rich block customizations. These encompass all tools related to the appearance of blocks and range from colors, typography, alignments, and positioning to filters like duotone, cropping, and background media and will need to integrate seamlessly with theme.json mechanics.

Going further, controls like font size, even if exposed as single values to users in the UI, are built behind the scenes to accommodate different viewport ranges. Apart from providing access to the underlying mechanisms through theme.json, responsive-previewing and device-specific editing will be necessary to support this.

To support the ever-increasing number of tools, the sidebar, while secondary in some regards to the block canvas and toolbar, will need to accommodate many of these tools, whereas the Component System will provide a shared design language between all these controls.

⚒️ Design Tools Overview Issue


How to follow along with Gutenberg

Here’s an overview of different ways to keep up with Gutenberg and the Full Site Editing project. There is also an index page of Gutenberg development-related posts and an updated Site Editing overview issue that breaks down the upcoming work into more concrete next steps.

Ways to Get Involved

While the above items are our focuses, don’t forget that you can always help with triage, testing issues, good first issues, and reviewing PRs. In particular, if you’re interested in helping with triage but don’t know where to start, there’s a course on Learn WordPress for how to do triage on GitHub! Check it out and join us.

Hearing your feedback is crucial to drive upcoming priorities and iterate on our work, so you are more than welcome to join our Full Site Editing Outreach Program!

If there’s anything we can do to make contributing easier, let us know in the comments or #core-editor chats. While we can’t promise to fix everything, we’d appreciate being aware of any blockers.


Props to @javiarce for creating the images, and to @cbringmann and @mcsf for reviewing the post.

#core-editor #gutenberg-next #gutenberg #full-site-editing