Make WordPress Core

Keyboard Shortcuts | Hide comment threads

CSS Chat Summary: 26 August 2021

The meeting took place here on Slack. @notlaura facilitated and @danfarrow wrote up these notes.

Announcements & Housekeeping

  • Previously we had talked about rotating the meeting facilitator on a regular basis. @notlaura asked anybody wanting to join the rota to step forward
  • UPDATE: We’re now working on a Meeting Guide document, which includes a facilitator schedule for people to sign up to

CSS Custom Properties (#49930)

  • @notlaura introduced the project for new attendees and asked for any updates
  • @wazeter committed two PRs last week, one in coordination with @robertg – more commits coming in a few days!
  • @dryanpress similarly expects to be committing in the next few days
  • @ryelle has updated the shared planning document with links to the PRs, and @circlecube has been helpfully indicating merged PRs by striking them through
  • @ryelle asked for help reviewing the PRs – @dryanpress & @wazeter offered their assistance
  • @wazeter shared some details of his methodology for themes.css where he temporarily moved many custom properties to the top of the file with a prefix --wp-admin--themes
  • @ryelle noted that all custom properties should eventually be moved into custom-properties.css
  • @wazeter asked about fallback values which @ryelle responded to: hex fallback rules, which precede rules assigning rgba values for browsers that don’t understand rgba, can now be removed since core’s browser support has been updated – UPDATE: I’ve added a note about this in the shared doc
  • @notlaura added a final note thanking all contributions, especially newcomers

CSS Link Share / Open Floor

  • @notlaura raised the topic of meeting structure, in particular keeping the structured work sessions for times when attendance is low
  • @wazeter supported the meeting format, noting that he sometimes was unsure what to do in the structured work session
  • @notlaura suggested creating some general guidelines on how to run Core CSS meetings – UPDATE: Now underway here!
  • @ryelle volunteered to run the CSS triage session before next week’s meeting – thanks @ryelle!

Thanks everyone!

NOTE: For those interested in facilitating a future meeting or triage, please add your name to the Facilitator Schedule here

#core-css, #summary

CSS Chat Agenda: August 26, 2021

The next weekly CSS meeting is Thursday, August 26 at 21:00PM UTC in the #core-css channel in Making WordPress Slack.

CSS Custom Properties (#49930)

Focused on substituting existing colors throughout Core stylesheets, the CSS Custom Properties project aims to make working with Admin Themes & Admin Color Schemes easier and more reliable both in Core and Plugins.

The #core-css team is looking for contributors interested in adopting a stylesheet (a process outlined here). No prior contributing experience is required — we’re happy to assist anyone who would like to participate! This meeting we will continue with work and collaboration, time permitting.

Meeting Agenda

  • Welcome (21:00PM UTC)
  • Announcements & Housekeeping
  • CSS Custom Properties (#49930)
    • Overview & Updates
    • How to Get Involved
    • Status Check-In & Blockers
  • Work & Collaboration (time permitting)
  • Open Floor
  • CSS Link Share (Bring neat examples & helpful tools!)

#agenda, #core-css

Editor chat summary: 25 August, 2021

This post summarizes the weekly editor chat meeting (agenda here) held on Wednesday, August 25, 2021, 04:00 PM GMT+1 in Slack. Moderated by @paaljoachim.

Gutenberg plugin releases

Gutenberg 11.3.0 release notes. Thanks to @vcanales for writing the notes and tackling the release!

New feature highlights:

  • New Dimensions Panel
  • Block inserter performance improvements
  • Dimension controls for Featured Image Block
  • New icons for Reusable Blocks and Template Parts

Gutenberg 11.4 RC is available for testing.

Whats next in Gutenberg: July and August

July and August monthly priorities.

Key project updates

Based on the scope for Site Editing projects.

Template Editor

Check out the – Site Editor Template mosaic view

Global Styling

Navigation Block & Navigation Editor

  • The team have been focused on reforming the project around the goal of removing the “experimental” status of the feature within the Gutenberg Plugin (only).
  • Held a Hallway Hangout on Tuesday to compare and contrast Navigation screens and determine next steps.
    A summary of the meeting and decisions made is available.
  • Tracking issue is being updated to focus on the tasks required to remove “experimental”.
  • Work is continuing on exploring wider architectural issues such as how to best make use of the Navigation block whilst retaining stability.
  • We’ve continued with small UI/UX fixes.

Mobile

  • Help menu option that teaches users about the block editor
  • Typography controls to manipulate the font size and line height and improved color settings

In progress:

  • Finalizing Block Picker Search
  • Embed block
  • Editor onboarding help section
  • GSS Font size, line height, colors

Components squad

At the time of the meeting there were no updates on the Pattern project.

Refactored Gallery block

The refactored Gallery block main PR from October 2020 has now finally been merged, and will be included as part of Gutenberg plugin 11.4. There is also a dev note on make core.

Task Coordination

@joen

@annezazu

  • Responding to Full Site Editing (FSE) feedback, testing FSE items, and helping amplify various efforts.
  • Working on a core editor improvement post about featured image block improvements.

@get_dave

Open Floor

@get_dave

Friendly reminder from Dave to add the most appropriate labels to PRs in GitHub, whether you’re submitting PRs or helping with triage. All efforts there make work easier for the release lead.

@paaljoachim

It would be very helpful for us who run the Core Editor Meetings to have tracking issues that are updated once a week, so we can share the project updates during the meeting. As it will also give a nice overview and it would make it easier for anyone to follow along to see the progress over time.

#core-editor, #core-editor-summary, #gutenberg, #meeting-notes, #summary

Hallway Hangout Summary: “compare and contrast” the Navigation screens

This post summarises the Navigation screen Hallway Hangout held on Tuesday, August 24, 2021 at 09:00 AM UTC in Zoom facilitated by @get_dave, @talldanwp and @javier.

The block-based Navigation editor screen has been behind an “experimental” feature flag within the Gutenberg plugin for some time. The purpose of the call was to outline the work required in order to remove the “experimental” status from the screen in order that the editor is active by default in the Gutenberg plugin.

The team working on the feature feel this is valuable in order to increase the visibility of the feature and therefore improve the quantity of feedback we receive.

Meeting Recording

If you’d like to watch the full recording of the session you can do so below:

Key points agreed

It was agreed that the prerequisite for removing “experimental” was: UI/UX feature parity with the existing Navigation screen (nav-menus.php) in Core.

We also acknowledged that:

  • We wouldn’t commit to feature parity of developer focused APIs at this stage.
  • Removing “experimental” in the Gutenberg plugin, would not automatically make the feature ready for merging into Core (that won’t happen until WordPress 5.9 at the earliest).

What was discussed?

The format of the hangout was an open discussion comparing and contrasting the classic menu screen with the experimental block-based navigation screen.

To this end attendees were asked to test drive both screens and note down their findings prior to the call.

The meeting facilitators also prepared a list of items as discussion points which were worked through during the call.

Each item was demonstrated, discussed and then assigned a loose priority of High/Medium/Low based on how critical the group felt the issue was to achieving feature parity.

Outcomes

The key outcomes of the call were:

Next Steps

Contributors working on the Nav Editor will now look to reorganise and reprioritse the tracking issue around the problems identified during the call.

  • All items will be added to the tracking issue (with the possible exception of bugs).
  • The High priority section of the tracking issue will be reformed and refocused around the goal of “removing the experimental status from the Navigation Editor”. Only tasks directly related to this goal will be considered for inclusion in the “High” priority section.
  • Tasks identified during the call that were marked as Medium or High till be added to the aforementioned High priority section of the tracking issue.
  • Contributors will focus on tackling High priority tasks in order to realise the goal of removing the “experimental” status.

All contributors are encouraged to become involved in prioritisation. Everyone is welcome and we’d very much value your feedback. If you feel a priority is wrong or missing then please let your fellow contributors know.

Thanks to everyone who attended the hangout and we look forward to moving the Navigation Editor forward together.

#feature-navigation-block-editor, #hallwayhangout, #navigation, #summary, #video

WordPress 5.8.x release team and 5.8.1 schedule

8/25/2021 @ 18:40 UTC: Added the “Release coordination” section to detail where release related communication will take place – @desrosj

The 5.8.x releases will follow the same consistent minor release leads strategy as the 5.7.x releases did. For the 5.8.x releases, the release leads will be:

5.8.1 proposed schedule

The following schedule is being proposed for 5.8.1:

  • RC: Wednesday, September 1, 2021
  • Final release: Wednesday, September 8, 2021.

As of the publish date of this post, 24 tickets have already been fixed and backported to the 5.8 branch to be included in 5.8.1. 38 additional open tickets are currently in the 5.8.1 milestone for consideration. Please head over and check out that list to contribute to the release.

Release coordination

During the 5.8 release, a new, #5-8-release-leads channel was created in Slack for the release squad to have all 5.8 related conversations. Because the 5.8.x releases are part of 5.8 by extension, all coordination and conversation related to the 5.8.x releases will also be held here before the channel is archived when WordPress 5.9 is released.

Props @circlecube and @chanthaboune for peer review.

#5-8-1

A Week in Core – August 23, 2021

Welcome back to a new issue of Week in Core. Let’s take a look at what changed on Trac between August 16 and August 23, 2021.

  • 27 commits
  • 21 contributors
  • 58 tickets created
  • 5 tickets reopened
  • 43 tickets closed

Pending the appointment of the WordPress 5.9 team, a number of tickets have been fixed, waiting for the next minor and major release(s).

Ticket numbers are based on the Trac timeline for the period above. The following is a summary of commits, organized by component and/or focus.

Code changes

Build/Test Tools

  • Include the commit short summary in Slack messages – #52644
  • Move loading the PO class to set_up_before_class()#53363
  • Move loading the WP_Community_Events class to set_up_before_class()#53363
  • Rename classes in phpunit/tests/admin/ per the naming conventions – #53363
  • Rename classes in phpunit/tests/editor/ per the naming conventions – #53363
  • Rename classes in phpunit/tests/error-protection/ per the naming conventions – #53363
  • Rename classes in phpunit/tests/feed/ per the naming conventions – #53363
  • Rename classes in phpunit/tests/formatting/ per the naming conventions – #53363
  • Use a better return type check for parse_url() in do_enclose() tests – #53635

Code Modernization

  • Check the input type in validate_file()#53635
  • Check the return type of parse_url() in WP::parse_request()#53635
  • Check the return type of parse_url() in download_url()#53635
  • Check the return type of parse_url() in ms_cookie_constants()#53635
  • Check the return type of parse_url() on Plugin/Theme Editor screens – #53635
  • Correct handling of null in wp_parse_str()#53635
  • Only set auto_detect_line_endings in PHP < 8.1 – #53635
  • Pass correct default value to http_build_query() in WP_Sitemaps_Provider::get_sitemap_url()#53635
  • Silence the deprecation warning for auto_detect_line_endings#53635

Customize

  • Hide native control on background position field – #53803

Editor

  • Replace the remaining references to wp.editor with wp.oldEditor#53762

External Libraries

  • Restore the phpcs:ignore statements in PHPMailer – #53953
  • Upgrade PHPMailer to version 6.5.1 – #53953

Media

  • Check the return type of _get_cron_array() in WP_Media_List_Table::prepare_items()#53949
  • Fix layout of media library modal on narrow screens – #53679
  • Increase number of media items displayed per page – #53827

Privacy

  • Add space below page selector – #53782

REST API

  • Remove trailing slashes when preloading requests and add unit tests for it – #51636

Toolbar

  • Limit the icon transition style to color only – #43423

Props

Thanks to the 21 people who contributed to WordPress Core on Trac last week: @jrf (10), @SergeyBiryukov (9), @hellofromTonya (8), @mukesh27 (4), @sabernhardt (3), @joedolson (2), @zieladam (2), @audrasjb (2), @earnjam (1), @moch11 (1), @desrosj (1), @andraganescu (1), @wb1234 (1), @walbo (1), @antpb (1), @AlGala (1), @ravipatel (1), @antonvlasenko (1), @johnjamesjacoby (1), @guillaumeturpin (1), and @lucatume (1).

Congrats and welcome to our 5 new contributors of the week! @moch11, @wb1234, @AlGala, @antonvlasenko, and @guillaumeturpin ♥️

Core committers: @sergeybiryukov (19), @peterwilsoncc (3), @azaozz (2), @ryelle (2), and @desrosj (1).

#5-8-1, #5-9, #core, #week-in-core

Dev Chat Agenda for August 25, 2021

Here is the agenda for this week’s developer meeting to occur at Wednesday, August 25, 2021 at 08:00 PM UTC.

Blog Post Highlights and announcements

Bringing to your attention some interesting reads and some call for feedback and/or volunteers

Components check-in and status updates

  • Check-in with each component for status updates.
  • Poll for components that need assistance.

Open Floor

Do you have something to propose for the agenda, or a specific item relevant to the usual agenda items above?

Please leave a comment, and say whether or not you’ll be in the chat, so the group can either give you the floor or bring up your topic for you accordingly.

This meeting happens in the #core channel. To join the meeting, you’ll need an account on the Making WordPress Slack.

#agenda, #core, #dev-chat

Editor Chat Agenda: 25 August 2021

Facilitator and notetaker: @paaljoachim

This is the agenda for the weekly editor chat scheduled for Wednesday, August 25, 2021, 04:00 PM GMT+1.

This meeting is held in the #core-editor channel in the Making WordPress Slack.

If you are not able to attend the meeting, you are encouraged to share anything relevant for the discussion:

  • If you have anything to share for the Task Coordination section, please leave it as a comment on this post.
  • If you have anything to propose for the agenda or other specific items related to those listed above, please leave a comment below.

#agenda, #core-editor, #core-editor-agenda, #meeting

I’d like to make another plea for adding the most appropriate labels to PRs in Github. It’s a small thing but it really helps the release lead when they are pruning the changelog.

Anything folks can do to help add labels when triaging PRs or remembering to use labels when they can would be much appreciated. Thank you!

Upgrade/Install component meeting agenda for August 24, 2021

The next meeting is scheduled on Tuesday, August 24, 2021 at 05:00 PM UTC and will take place on #core-auto-updates Slack channel.

The aim of the chat is to check the status of the rollback for failed plugin/theme updates after last Friday’s testing session and triage/scrub tickets in the component.

Got something to propose for the agenda? Please leave a comment below.

See you later!

#core-auto-updates, #updater, #upgrade-install

CSS Chat Summary: 19 August 2021

The meeting took place here on Slack. @dryanpress facilitated and @danfarrow wrote up these notes.

CSS Custom Properties (#49930)

Working Time

  • @robertg has taken on src/wp-admin/css/customize-controls.css which 2900+`lines of CSS. Bon courage Robert!
  • @wazeter has looked at other contributors change files in order to see how others have approached the problem, which seems like a sensible approach

CSS Link Share / Open Floor

Thanks everyone!

#core-css, #summary