Make WordPress Core

Keyboard Shortcuts | Hide comment threads
Dan Farrow 6:25 pm on September 2, 2021

CSS Chat Agenda: September 02, 2021

The next weekly CSS meeting is today, Thursday September 02, at 21:00pm UTC in the #core-css channel in Making WordPress Slack.

There will also be a Core CSS Triage starting at 20:00pm UTC, an hour before the meeting.

Meeting Agenda

  • Welcome (21:00pm UTC)
  • Announcements & housekeeping
  • CSS Custom Properties (#49930)
  • Open floor / CSS link share

See you there!

#agenda

annezazu 2:50 am on September 2, 2021

Editor chat summary: 1 September, 2021

This post summarizes the weekly editor chat meeting (agenda here) held in Slack. Moderated by @annezazu.

Announcements

Gutenberg 11.4 launched

Release notes coming soon after a quick fix. For now, some highlights:

  • The Gallery Block now acts as a wrapper for core Image Blocks thanks to the Gallery Block Refactor. Plugin and theme authors, please do check out out this dev note to get up to speed on backwards compatibility
  • The Featured Image block now has the option to add duotone filters so you now have even more ways to add your own style to your content.
  • Padding support was added to the Buttons Block making it easier to get the spacing just right.

5.8.1 RC launches today (Sept 1)

Based on the schedule previously shared, 5.8.1 RC will launch today with the release coming on September 8th. If you can, please help test the release.

Final day for the current FSE call for testing (Sept 1 )

It’s the last day to explore the current FSE Outreach Program call for testing. If you have time, share your thoughts! If you don’t, please help amplify by sharing with others.

Reminder: monthly block theme meeting in #themereview

A reminder was shared that there is a block theme meeting in for anyone keen to chat about what’s happening with block themes. This is a recurring monthly meeting so if you missed today’s, don’t worry!

Monthly Priorities & Key Project Updates

The overarching plan for September has not yet been shipped yet so we based today’s conversation on the July & August Plan. As a reminder to those working on these projects, async updates are both welcomed if you can’t make the meeting and needed.

Navigation Editor

For the Navigation Editor portion, @talldanwp shared a lovely update. Here are some highlights:

  • A plan has been formed for migrating from the customize API to the REST API in the navigation editor.
  • The nav editor header’s design has been refreshed.
  • Some conversation is underway around extensibility of the editor (join in if you’re interested). 

Mobile

Shipping:

  • Block picker search

 Notable fixes:

  • Fixed an npm install breakage on Gutenberg’s trunk branch due to third-party dependency we were building that had an unpinned typescript dependency.

In Progress:

  • Embed block (hoping to release some inline previews in our next release)
  • GSS Font size, line height, colors

Patterns

For patterns, some context was shared amongst the core editor wranglers from @paaljoachim that the design tool overview enhancements will ultimately also trickle down to make pattern creation easier, more responsive, etc.

Styling

I’m going to reuse part of the async update from André since he’s done a ton of work there. Lots of work is underway with adding duotone support in theme.json along with a PR around enabling global styles to all themes. Expect work to continue on this path for the week ahead.

No update for the Template Editor or the Navigation Block

If anyone has any context to add around the Template Editor or the Navigation Block, feel free to chime in below in the comments.

Task Coordination

Feel free to add items to this post if you weren’t able to make the meeting.

@mikeschroder

Shipped:

  • Closed 32024 via [51677]. Thanks everyone for your help, including with the follow-up tests commit! 
  • Opened two Video Block poster related PRs (34415 and 34411).

This week, planning to investigate 33437.

@oandregal

@zieladam

@youknowriad

  • I’ve worked a bit on performance. I want to get back to some layout related work.
  • I’ve reviewed a number of PRs as well.
  • I’ve spent some time this week exploring some wild ideas for block registration (both to make easier and more universal/language independent). For the curious, the repo is here http://wayback.fauppsala.se:80/wayback/20210903144545/https://github.com/youknowriad/blocky it’s no where near ready but I’d love to learn more about your custom blocks, if you have examples or ideas about how you’d ideally write them and what use-cases would you want to see for the simplified “view” property.

@joen

@gziolo

@annezazu

  • Recapping and responding to the current call for testing for the outreach program.
  • Finalizing the next call for testing(more exploration than call for testing right now on theme switching).
  • Drafting some core editor improvement posts + assisting with an upcoming News post
  • Shipped a YouTube video all about patterns.
  • Triaging unlabeled PRs (down from over 100 to in the 20s). The unlabeled PRs that are left I am not quite sure what to do with so feel free to jump in.

Open Floor

Offer to run a Gutenberg Release for the first time. Raised by @mikeschroder.

If folks are interested, after shadowing @talldanwp (thanks again!), I would love to try running a Gutenberg release for the first time. Whenever it works best for the team is okay with me!

Next step: @priethor will coordinate since he helps wrangle the release process.

Proposed migration of E2E specs to Playwright. Raised by Bart Kalisz.

A proof concept was shared and well received thus far as part of a proposed migration to Playwright. At this point, a wider discussion needs to happen with impacted parties to ensure that folks are willing to follow the proposed changes. A few folks chimed in agreeing that a wider discussion needs to happen along with perhaps a comparison with Cypress (mentioned by @swissspidy). Depending on how things go, a Make Core post might make sense.

Next steps: Bart alerted the crew in #core-test and @annezazu will ensure that it gets discussed in the Core Dev meeting for wider attention.

Call for community ideas for FSE Outreach testing calls. Raised by @annezazu.

I’d love to start experimenting with community members sharing ideas for what to test in the outreach program. If you’d like to suggest an idea for a call for testing, know it’s very welcomed and all ideas will be weighed against current project priorities to figure out what makes the most sense to pursue. You can share ideas directly in the #fse-outreach-experiment slack channel or via DM to me! In case you’re curious about how calls for testing have been wrangled in the past, it’s typically been a combination of monthly project priorities/release priorities + my own testing/what I can make happen + conversations with contributors.

#core-editor, #core-editor-summary, #summary

Evan Mullins 8:31 pm on September 1, 2021

WordPress 5.8.1 RC 1

WordPress 5.8.1 Release Candidate 1 (RC1) is available for testing!

Some ways you can help testing WordPress 5.8.1 RC1:

What’s in this release candidate?

5.8.1 Release Candidate 1 features 41 bug fixes on Core, as well as 20 bug fixes for the Block Editor.

The following core tickets from Trac are fixed:

  • #52818 – Ordering metaboxes broken in WP 5.7
  • #53556 – Add a new template-editing tag to the Theme API
  • #53562 – Widgets Editor in Customizer doesn’t load with E2E tests + 0ms Animations
  • #53609 – Responsive widget block embeds not showing in the customizer
  • #53616 – Registered block styles should only be rendered when the block exists on a page
  • #53641 – Can not configure image widget (and others) in widget accessability mode
  • #53654 – Menus: Hide bulk-select options when no menus exist
  • #53667 – Support wp_editor_set_quality for both loaded and saved mime_types
  • #53668 – Generated images for one file can be overwritten by another with the same name when mapping mime types for generated images
  • #53679 – The media library looks broken on mobile
  • #53680 – Correct inline documentation about IMAGETYPE_WEBP and IMG_WEBP
  • #53696 – wp_add_iframed_editor_assets_html() not checking for block editor
  • #53697 – Possible Regression – Border settings not displaying for Button Block
  • #53702 – Four css files removed between 5.7.x and 5.8 were not included in $_old_files
  • #53713 – Bounce underscore.js version in script-loader
  • #53714 – Bounce jquery.form.js version in script-loader
  • #53715 – Bounce hoverIntent.js version in script-loader
  • #53716 – The “/” missing at the end of image tag
  • #53719 – grunt clean:css does not clean the css/dist folder
  • #53738 – Broken loop in WP_Theme_JSON_Resolver
  • #53752 – Twenty Ten: Block patterns file causes error in child themes
  • #53757 – Widget editor calls get_block_categories() with incorrect arg type
  • #53762 – Replace the remaining references to wp.editor with wp.oldEditor
  • #53769 – Bundled themes: block-patterns.php file should use get_template_directory_uri instead of get_stylesheet_directory_uri
  • #53773 – /wp-admin/includes/ajax-actions.php file line 3006 is creating divide by zero error
  • #53777 – Bump bundled theme versions for
  • #53799 – Remove version-controlled files check from Test Old Branches workflow
  • #53803 – Customizer: Radio button on background image position selector visible on focus
  • #53820 – Build doesn’t support Docker Compose V2
  • #53827 – Increase number of media items displayed when clicking button to “Load More”
  • #53830 – Default filters try to create nonce during installation before options table exists
  • #53833 – ‘Replace image’ Media Modal is missing select fields under filter media due to css issues
  • #53877 – Menus: Selected display locations for new menus aren’t saved
  • #53898 – Duplicated 404 templates in the TemplatePanel
  • #53922 – Docblock in get_block_editor_settings function
  • #53932 – Media grid view doesn’t show all media elements
  • #53936 – Output of serialize_block_attributes does not match equivalent Gutenberg function
  • #53955 – Fix and improve the docs for the image_editor_output_format filter
  • #54030 – Pressing esc in Widgets Editor closes panel in customizer
  • #54036 – PclZip throwing errors on PHP 8 – previously merged patch is incomplete
  • #54052 – Block editor package updates for 5.8.1

The following block editor issues from GitHub are fixed:

  • PR33384 – Fix API docs for data reference guides
  • PR33381 – Docs: use markdown headings instead of links for API declarations
  • PR33498 – Docs: Run Prettier after updating API in documentation
  • PR33549 – Use tabs instead of spaces in block transform doc example
  • PR30617 – Fix metabox reordering
  • PR32083 – Block editor: move layout styles to document head (instead of rendering inline)
  • PR33814 – Widgets: Allow HTML tags in description
  • PR33457 – Editor: Set ‘hide_empty’ for the most used terms query
  • PR33482 – Update widget editor help links to point to the new support article
  • PR33621 – Fixed that the block is selected instead of the title when using the select all shortcut.
  • PR33699 – Writing flow: select all: remove early return for post title
  • PR33618 – Call onChangeSectionExpanded conditionally
  • PR33679 – FontSizePicker: Use number values when the initial value is a number
  • PR33739 – Fix justification for button block when selected
  • PR33771 – Add error boundaries to widget screens
  • PR33802 – Fix insertion point in Widgets editors
  • PR34280 – Default batch processor: Respect the batch endpoint’s maxItems
  • PR34314 – Fix button block focus trap after a URL has been added
  • PR34076 – Text for dropdown fields within legacy widgets in the Customizer is off centered
  • PR32935 – Add a SearchControl component and reuse accross the UI(class change in tests)

What’s next?

The dev-reviewed workflow (double committer sign-off) is now in effect when making any changes to the 5.8 branch.

As per the proposed WordPress 5.8.1 schedule, the final release is expected on Wednesday, September 8, 2021. Please note that this date can change depending on possible issues after RC1 is released. Coordination will happen in the WordPress.org Slack #5-8-release-leads channel.

A special thanks to everyone who helped test, raised issues, and helped to fix tickets. With this release candidate testing continues, so please, help test!

The 5.8.1 release is being led by @desrosj and @circlecube.

Props @webcommsat and @desrosj for peer review.

#5-8, #5-8-1, #minor-releases, #releases

ramonopoly 8:08 pm on September 1, 2021

What’s new in Gutenberg 11.4? (1 September)

Depending on where you live, it’s the first day of Spring. Or Autumn. Or, if you live on Venus, just another season of sulphuric acid showers.

No matter where you are, Gutenberg 11.4 has been released with new features to brighten your mood including the refactored Gallery Block, duotone filters for featured images, and more block design tools!

Gallery Block now uses Image Blocks

The Gallery Block now acts as a wrapper for core Image Blocks.

Individual gallery images will therefore feature all existing and future functionality of not only Image Blocks – for example, the ability to add custom links, filters, and styles – but also standard block behavior such as move, drag and drop, copy, and keyboard navigation.

For now, the new Gallery Block can be enabled on the Gutenberg Experiment page, but the plan is for the Gallery Block to ship with WordPress 5.9.

Theme and plugin authors can get wise about backward compatibility recommendations over in the Gallery Block Refactor Dev Note.

Duotone filters for featured images

Duotone filters were introduced to image and cover blocks in 10.6. By extending duotone filters to Post Featured Image blocks, 11.4 enables us to set consistent effects across post and page templates, recent posts lists, and Query Block content.

Padding support for Button Blocks

As of 11.4, we can define padding for Button Blocks with the further option of linking padding values to vertical and horizontal axial sides.

The aim is to provide greater control as well as uniformity in the way we display button elements. We can still set a single padding value for all sides – adding extra vertical or horizontal padding just gives us that extra flexibility to create variations on our design patterns.

Support for block gap spacing

Having a consistent way to tweak the margin/gap between blocks has been a long-standing feature request. 11.4 introduces the groundwork for adding gap spacing control to blocks such as Buttons, Images, and Columns, opening up the possibility of more powerful and precise layout tools.

There’s work in progress to bring this to the editor so stay tuned for updates in upcoming releases!

Other notable highlights

Font weight support is now available for the Post Date and Post Terms Blocks.

An “early beta” feature has also made it into 11.4: the ability to expose a parent block’s toolbar controls to its child blocks. A use case would be changing the alignment of Buttons when editing a single Button. Keep an eye out for a request for feedback on this developing feature soon.

11.4.0

Enhancements

  • Accessibility
    • Cover Block: Allow alt text in Cover blocks. (33226)
    • Add aria-describedby to custom select control component to describe currently-selected font size. (33941)
  • Block Editor
    • Block Lists: improve iframe block, pattern and template previews. (28165)
  • Block Library
    • Query Loop: update Post Template sub-block icon. (34204)
    • Convert Gallery block to use Image blocks. (25940)
    • Post Featured Image: add duotone block supports. (34113)
    • Post Featured Image: add contextual help text to the scaleproperty. (34158)
    • File block: update transform from image to use image filename if caption is empty. (34256)
    • Post date Block: add font weight support to the block. (34070)
    • Post terms: add font weight support to the block. (34142)
    • Site Tagline: add font weight support. (33983)
    • Button: update spacing support to use axial padding. (33859)
  • Components
    • Add deprecated props adapter for ColorPicker. (34014)
    • Wrap SegmentedControl in a BaseControl with an added help property. (34017)
    • Combobox: update the current selection if the list of suggestions is filtered. (33928)
    • Post Title: use rich text hook and updating tag to h1 (31569)
  • Design Tools
    • Add layout default value support for blocks. (34194)
    • Dimensions Panel: add padding tool as default for blocks where this is a common setting. (34026)
  • Navigation Screen
    • Update navigation screen topbar. (34166)
  • Packages
    • Updates the “settings” icon, which toggles the display of additional controls in an interface. (34165)
  • Post Editor
    • Migrate post editor feature preferences to the interface package. (34154)
  • Widgets Editor
    • Migrate customize widgets feature preferences to interface package. (34135)
    • Refactor editor ‘feature’ preferences to interface package. (33774)

Bug Fixes

  • Block API
    • Spacing/Dimensions Supports: separate spacing from dimensions for compatibility purposes. (34059)
  • Block Editor
    • Font-size adjustment for tablet and mobile device previews. (33342)
    • Fix single block selection by holding shift key. (34137)
    • Fix unwanted additional spaces added around pasted text on Windows. (33607)
    • Inserter: prevent non-deterministic order of inserter items. (34078)
    • Try: Fix multiselect toolbar indent and reformat BlockContextualToolbar(). (34038) (34173)
  • Block Library
    • Latest Comments: use site locale in the editor. (33944)
    • Navigation: fix vertical layout on the frontend. (34226)
    • Navigation: add z-index value to responsive menu overlay. (34228)
    • Navigation: enable flex on container to fix space between. (34258)
    • Navigation: fix submenu icon positioning. (34168)
    • Navigation block: add missing </ul> closing tag. (34077)
    • Post Excerpt: remove interactive formatting. (34083)
    • RichText: fix space key for button and summary elements. (30244)
    • Search Block: add space between generated border class names. (34025)
  • Build Tooling
    • Webpack: Fix watch on .json and .php files. (34024)
    • Pin TypeScript dependency to a specific version to avoid pulling in breaking changes. (34422)
  • Components
    • Fix RTL on Flex component. (33729)
    • NavigationSidebar: fix template content for content-navigation-item preview. (34203)
    • Remove deprecated import style for storybook/addon-docs. (34095)
    • ToolsPanel: add tools panel item deregistration. (34085)
    • Post Title: remove wrapper div and fix border style. (34167)
  • Core Data
    • GetEntityRecords returns items even if some included IDs don’t exist. (34034)
  • Design Tools
    • Allow zero values for theme.json styles. (34251)
  • Global Styles
    • Site editor: fix for how CSS custom properties are generated. (33932)
  • Packages
    • Rich Text: add check to toTree() in replacements before accessing its type. (34020)
  • Post Editor
    • Fix selector params in isPluginItemPinned() selector. (34155)

Performance

  • Data Layer
    • Data: Add a batch function to the data module to batch actions. (34046)

Experiments

  • Block API
    • Block Editor: absorb parent block toolbar controls. (33955)
    • Block Editor: use groups for InspectorControls. (34069)
  • Block Library
    • Add generic classnames to children of Navigation. (33918)
  • Global Styles
    • Add slashes back to the Theme JSON. (33919)
    • Add block spacing gap configuration to theme.json and add support for this CSS variable to the “flow/default” layout. (33812)

Documentation

  • Handbook
    • Alphabetize glossary entries. (34058)
    • Correct minor typos in wp-plugin.md (34185)
    • Remove extraneous params from block_type_metadata hook. (34151)
    • Update incorrect settings examples in “Global Settings & Styles”. (34084)
    • Use block.json to add attributes in create block tutorial. (33978)
    • Fix typo in block gap documentation in theme-json.md. (34231)
    • Fix broken mobile testing documentation link in testing-overview.md. (34187)
    • Fix typo in legacy-widget-block.md. (34103)
    • Update spelling and fontSize examples in create-block-theme.md. (34152)
  • Library
    • Bump mobile version in experiments page for Gallery. (34220)
  • Packages
    • Add documentation for mobile components directory. (33872)

Code Quality

  • Block Editor
    • Render head and body with single portal for block previews. (34208)
    • BlockList: refactor element context for style/svg appending. (34183)
    • BlockList: use InnerBlocks internally. (29895)
  • Components
    • Unit Control: add unit tests for getValidParsedUnit utility method. (34029)
    • Rename SegmentedControl to ToggleGroupControl. (34111)
    • Dropdown Menu: remove min-width from the dropdown component and add whitespace rule to avoid wrapping (33995)
  • Core Data
    • Allow passing store definitions to controls. (34170)
  • Site Editor
    • Remove extra DOM element used for template part overlay. (34012)

Tools

  • Build Tooling
    • Automated Changelog: force group all documentation tasks under Documentation. (34042)
    • Automated Changelog: rename “Editor” grouping to “Post Editor” to avoid ambiguity with other editors. (34093)
    • Automated Changelog: sort feature groups by issue name. (34071)
    • Automated Changelog: use nested headings for feature groups instead of indenting lists. (34040)
    • Automated Changelog: remove Uncategorized header in output and place items at top. (34037)
    • Add Typescript extensions to watched files. (34094)
    • Remove obsolete step that pushes tags in NPM publishing flow. (34114)
    • Release workflow: only commit modified changelogs. (34211)
  • ESLint
    • Eslint plugin: use @typescript-eslint/no-duplicate-imports in TS projects. (34055)
  • GitHub Contributor Templates
    • Issue Forms: simplify the bug report form template. (34007)
  • Logs
    • Hide deprecation logs under a console group. (34163)
  • Testing
    • Emulate reduced-motion in end-to-end tests. (34132)
    • Re-enable Android end-to-end tests. (34243)
    • Remove extra props from Cover deprecations. (34066)
    • Remove the ENVIRONMENT_DIRECTORY env variable that was added to the performance jobs. (34086)
    • Add snapshot test for changelog formatting. (34049)
    • Experiment with using REST API in end-to-end tests to build up states. (33414)

Performance benchmark

VersionLoading TimeKeyPress Event (typing)
Gutenberg 11.46.35s36.87ms
Gutenberg 11.36.29s36.97ms
WordPress 5.86.91s35.48ms

Thanks to @critterverse for our release preview assets, @priethor for guiding the release, @noisysocks, @talldanwp, and @andrewserong for their help with the release build and deploy, and to all who contributed to this release. Thank you for your splendid work!

#block-editor, #core-editor, #gutenberg, #gutenberg-new

nick6352683 12:22 am on September 2, 2021

WP 5.8, Xampp Localhost, PHP 7.2.

Unfortunately for me Gut. 11.4.0 is a total disaster…

  • While editing, sometimes instead of getting the Post Title I was getting the Pattern Category dropdown. Refreshing the page was fixing the issue.
  • I had to save a post twice, before it would accept the changes made, otherwise I would get the message that maybe the post was not saved when trying to leave the page. Again, saving the post twice would avoid the warning.
  • The icing on the cake was when after 10 minutes of testing, I could not edit any page/post anymore, I would get the Gutenberg white screen of death. Attempting to recover would do nothing. Disabling the Gutenberg plugin fixes everything, so as reverting back to Gutenberg 11.3 which I did. I hope you guys fix all the breaking issues… here is the video where editing is not possible, and by simple disabling the Gutnbrg plugin, everything starts working as normal again.

Video

Thanks.

ramonopoly 3:41 am on September 2, 2021

Thanks for the comment, and for the effort of posting a video demonstration.

It would be interesting to view the Editor’s error output by clicking on the “Copy Error” button in the modal and pasting it.

It would also be helpful to learn which plugins and theme you’re running in conjunction with 11.4.

Knowing these bits of information would assist folks to create issues, and ultimately debug/fix things as quickly as possible.

Cheers!

nick6352683 4:22 am on September 2, 2021

Thanks for the quick reply, I have to say that every single dev team I had any interactions with the last 3-4 years are simply awesome.

Well here is the deal… What I did not mention above was that I had tried to empty the Chrome browser with Ctrl + F5, which did nothing.

I now updated Gutenberg to the latest version, the issue had returned, but this time I used the command “window.localStorage.clear();” in the Console and magically all is fine again. This is the first time ever that I had encountered such issue after a Gutenberg update.

Also, not that, after both cases of updating the Gutenberg update, the editor reseted itself to it’s original setting, by going FullScreen mode, and presenting with the original popup box for the tour… I am not sure if this was the intend… This was never done with any update before…

Anyway, all is good now, maybe somewhere you guys should post that console command (if not already done)…

Thanks again, now I’m looking forward to test my new toy !

ramonopoly 4:30 am on September 2, 2021

I used the command “window.localStorage.clear();” in the Console and magically all is fine again.

Nice work. I’m happy it’s working again for you!

Also, not that, after both cases of updating the Gutenberg update, the editor reseted itself to it’s original setting, by going FullScreen mode, and presenting with the original popup box for the tour

I suspect this relates to the local storage clear. Many editor preferences, including fullscreen mode, are stored locally in your browser.

nick6352683 4:32 am on September 2, 2021

The fullscreen mode was before the storage clearing…

nick6352683 4:34 am on September 2, 2021

BTW, the bug is back within minutes of use, I posted the error message, but the message is awaiting approval…

nick6352683 4:31 am on September 2, 2021

I am sorry but within just a few minutes all pages/posts became un-editable again, here is the error code per your prior request:

TypeError: Cannot read property 'autosaveInterval' of undefined
at t.value (http://wayback.fauppsala.se:80/wayback/20210903144545/http://localhost/software/wp-content/plugins/theme-blocks/addons/block-options/build/index.js:16:240569)

nick6352683 4:39 am on September 2, 2021

Looking at the error code, and disabling the EditorsKit plugin fixed the issue. I guess I have to report the issue to them. You leave the whole conversation for others to see, or delete everything as I now know that the combination of the latest Gutenberg version with the EditorsKit plugin causes major corruption.

Thanks a million, you taught me to use the error button…

ramonopoly 5:01 am on September 2, 2021

Any time. Happy that you got to the bottom of it. I see that you’ve created an issue in the forum too. Thank you!

Tonya Mork 5:58 pm on September 1, 2021

Dev Chat Agenda for Sept 1, 2021

Here is the agenda for this week’s developer meeting to occur at Wednesday, September 1, 2021 at 08:00 PM UTC.

Blog Post Highlights and announcements

Bringing to your attention some interesting reads and some call for feedback and/or volunteers

Components check-in and status updates

  • Check-in with each component for status updates.
  • Poll for components that need assistance.

Open Floor

Do you have something to propose for the agenda, or a specific item relevant to the usual agenda items above?

Please leave a comment, and say whether or not you’ll be in the chat, so the group can either give you the floor or bring up your topic for you accordingly.

This meeting happens in the #core channel. To join the meeting, you’ll need an account on the Making WordPress Slack.

Peer review @annezazu and @circlecube.

#agenda, #core, #dev-chat

marctison75 6:36 pm on September 1, 2021

Hi, I have a question for the Open Floor: when will the development of the Twenty Twenty-Two theme begin?

Jan Thiel 6:55 pm on September 1, 2021

Hey @hellofromtonya I would kindly ask for some core contributor feedback on http://wayback.fauppsala.se:80/wayback/20210903144545/https://core.trac.wordpress.org/ticket/53450 . The PR is complete, tested and would benefit alot of usecases in the wild getting rid of “REGEX” meta compares. Just missing some dev feedback and a “good to go”. If someone would like to jump in, I would highly apreciate it to get this into 5.9!

Jb Audras 7:03 am on August 31, 2021

A Week in Core – August 30, 2021

Welcome back to a new issue of Week in Core. Let’s take a look at what changed on Trac between August 23 and August 30, 2021.

  • 33 commits
  • 34 contributors
  • 63 tickets created
  • 11 tickets reopened
  • 49 tickets closed

The Core team is currently working on the next point (5.8.1) and major (5.9) releases.

Ticket numbers are based on the Trac timeline for the period above. The following is a summary of commits, organized by component and/or focus.

Code changes

Administration

  • Remove a misleading pointer cursor from list items in the admin menu – #51551

Build/Test Tools

  • Install the Composer package dependencies within the Docker environment as part of the local development environment installation and testing processes – #53945
  • Preserve text within backticks in Slack notifications – #52644
  • Remove shell: bash from PHPUnit test workflow – #53363
  • Remove shell: bash from code coverage workflow – #53363
  • Use list format when defining environment variables in Docker compose file – #53820
  • Remove css/dist in grunt clean command – #53719
  • Improve bootstrap error message for when ABSPATH folder does not exist
  • Move wp_list_filter() tests to their own file – #53363, #53987
  • Move wp_list_pluck() tests to their own file – #53363, #53987
  • Move wp_list_sort() tests to their own file – #53363, #53987
  • Remove duplicate wp_list_pluck() tests – #53363, #53987
  • Rename the test file and class for wp_filter_object_list() tests – #53363, #53987

Coding Standards

  • Add missing visibility keywords for wp_filter_object_list() and wp_list_pluck() tests – #53363, #53987
  • Fix WPCS issue in [51682] – #54030
  • Fix indentation and remove ignore annotation in wp_privacy_send_personal_data_export_email() – #53359
  • Make ignore annotation more specific in WP_Site_Health_Auto_Updates::test_vcs_abspath() – #53359
  • Remove redundant ignore annotation in populate_options() – #53359
  • Update the config for WordPress.PHP.FileName in PHPCS ruleset – #53359
  • Update the config for WordPress.PHP.NoSilencedErrors in PHPCS ruleset – #53359
  • Use static closures when not using $this – #53359
  • Pass correct default value to http_build_query() in WP_Sitemaps_Provider::get_sitemap_url() – #53635

Customize

  • Prevent collapsing expanded panel/section/control when Esc is pressed on a block editor instance – #54030
  • Respect prefers-reduced-motion media query in Customizer animations – #53542

Documentation

  • Add missing @since tag for the $check_signatures parameter of WP_Upgrader::run() – #53399
  • Clarify a comment in WP_Upgrader::run() – #53399

Editor

  • Ensure block attribute serialization in PHP matches the JavaScript equivalent – #53936

Filesystem API

  • Make sure to only call fread() on non-empty files in PclZip::privAddFile() – #54036

Media

  • Fix wp_unique_filename() to check for name collisions with all alternate file names when an image may be converted after uploading. This includes possible collinions with pre-existing images whose sub-sizes/thumbnails are regenerated – #53668

Menus

  • Save display locations for new menus – #53877

Plugins

  • Display a message on Plugins list table if a plugin requires a higher version of PHP or WordPress – #53990

REST API

  • Correct the description for the last_updated property in the block-directory endpoint – #53595

Security

  • Correct the inline docs for the wp_kses_allowed_html filter – #53597

Toolbar

  • Provide a CSS custom property for the admin bar height – #52623

Props

Thanks to the 34 people who contributed to WordPress Core on Trac last week: @jrf (10), @hellofromTonya (8), @SergeyBiryukov (6), @desrosj (5), @johnbillion (3), @dlh (2), @azaozz (2), @netweb (2), @sabernhardt (1), @pbearne (1), @swissspidy (1), @youknowriad (1), @nico23 (1), @ocean90 (1), @pbrearne (1), @timothyblynjacobs (1), @kevinfodness (1), @peterwilsoncc (1), @mikeschroder (1), @mamaduka (1), @TacoVerdo (1), @zieladam (1), @isabel_brison (1), @kevin940726 (1), @earnjam (1), @gwwar (1), @opurockey (1), @ryelle (1), @kurudrive (1), @circlecube (1), @DavidAnderson (1), @mukesh27 (1), @andraganescu (1), and @ianmjones (1).

Congrats and welcome to our 2 new contributors of the week! @kevinfodness and @kurudrive ♥️

Core committers: @sergeybiryukov (12), @hellofromtonya (7), @desrosj (5), @johnbillion (4), @peterwilsoncc (2), @mikeschroder (1), @ryelle (1), and @azaozz (1).

#5-8-1, #5-9, #core, #week-in-core

annezazu 3:23 pm on August 30, 2021

Editor Chat Agenda: 1 Sept 2021

Facilitator and notetaker: @annezazu

This is the agenda for the weekly editor chat scheduled for Wednesday, September 1, 2021 at 02:00 PM UTC.

This meeting is held in the #core-editor channel in the Making WordPress Slack.

If you are not able to attend the meeting, you are encouraged to share anything relevant for the discussion:

  • If you have an update for the main site editing projects, please feel free to share as a comment or come prepared for the meeting itself.
  • If you have anything to share for the Task Coordination section, please leave it as a comment on this post.
  • If you have anything to propose for the agenda or other specific items related to those listed above, please leave a comment below.

#agenda, #core-editor, #core-editor-agenda, #meeting

Mike Schroder 12:42 pm on August 31, 2021

For Task Coordination:
Last week:

  • Closed 32024 via [51677]. Thanks everyone for your help, including with the follow-up tests commit! 🙇🏼
  • Opened two Video Block poster related PRs (34415 and 34411).

This week:

  • Planning to investigate 33437.

For Open Floor:

  • If folks are interested, after shadowing @talldanwp / @danr (thanks again!), I would love to try running a Gutenberg release for the first time. Whenever it works best for the team is okay with me!
annezazu 3:12 am on September 1, 2021

Thanks so much, Mike! I’ll be sure to share both for task coordination and the open floor.

André 7:25 am on September 1, 2021

Task coordination:

I’ve been helping with reviews, most notably adding duotone support in theme.json.
I’ve also created a few PRs in this area of work: the main one is perhaps enabling global styles to all themes. I’ll continue to work in this area for the next week.

Dan Farrow 11:59 am on August 29, 2021

CSS Chat Summary: 26 August 2021

The meeting took place here on Slack. @notlaura facilitated and @danfarrow wrote up these notes.

Announcements & Housekeeping

  • Previously we had talked about rotating the meeting facilitator on a regular basis. @notlaura asked anybody wanting to join the rota to step forward
  • UPDATE: We’re now working on a Meeting Guide document, which includes a facilitator schedule for people to sign up to

CSS Custom Properties (#49930)

  • @notlaura introduced the project for new attendees and asked for any updates
  • @wazeter committed two PRs last week, one in coordination with @robertg – more commits coming in a few days!
  • @dryanpress similarly expects to be committing in the next few days
  • @ryelle has updated the shared planning document with links to the PRs, and @circlecube has been helpfully indicating merged PRs by striking them through
  • @ryelle asked for help reviewing the PRs – @dryanpress & @wazeter offered their assistance
  • @wazeter shared some details of his methodology for themes.css where he temporarily moved many custom properties to the top of the file with a prefix --wp-admin--themes
  • @ryelle noted that all custom properties should eventually be moved into custom-properties.css
  • @wazeter asked about fallback values which @ryelle responded to: hex fallback rules, which precede rules assigning rgba values for browsers that don’t understand rgba, can now be removed since core’s browser support has been updated – UPDATE: I’ve added a note about this in the shared doc
  • @notlaura added a final note thanking all contributions, especially newcomers

CSS Link Share / Open Floor

  • @notlaura raised the topic of meeting structure, in particular keeping the structured work sessions for times when attendance is low
  • @wazeter supported the meeting format, noting that he sometimes was unsure what to do in the structured work session
  • @notlaura suggested creating some general guidelines on how to run Core CSS meetings – UPDATE: Now underway here!
  • @ryelle volunteered to run the CSS triage session before next week’s meeting – thanks @ryelle!

Thanks everyone!

NOTE: For those interested in facilitating a future meeting or triage, please add your name to the Facilitator Schedule here

#core-css, #summary

Lara Schenck 6:29 pm on August 26, 2021

CSS Chat Agenda: August 26, 2021

The next weekly CSS meeting is Thursday, August 26 at 21:00PM UTC in the #core-css channel in Making WordPress Slack.

CSS Custom Properties (#49930)

Focused on substituting existing colors throughout Core stylesheets, the CSS Custom Properties project aims to make working with Admin Themes & Admin Color Schemes easier and more reliable both in Core and Plugins.

The #core-css team is looking for contributors interested in adopting a stylesheet (a process outlined here). No prior contributing experience is required — we’re happy to assist anyone who would like to participate! This meeting we will continue with work and collaboration, time permitting.

Meeting Agenda

  • Welcome (21:00PM UTC)
  • Announcements & Housekeeping
  • CSS Custom Properties (#49930)
    • Overview & Updates
    • How to Get Involved
    • Status Check-In & Blockers
  • Work & Collaboration (time permitting)
  • Open Floor
  • CSS Link Share (Bring neat examples & helpful tools!)

#agenda, #core-css

Paal Joachim Romdahl 2:55 pm on August 26, 2021

Editor chat summary: 25 August, 2021

This post summarizes the weekly editor chat meeting (agenda here) held on Wednesday, August 25, 2021, 04:00 PM GMT+1 in Slack. Moderated by @paaljoachim.

Gutenberg plugin releases

Gutenberg 11.3.0 release notes. Thanks to @vcanales for writing the notes and tackling the release!

New feature highlights:

  • New Dimensions Panel
  • Block inserter performance improvements
  • Dimension controls for Featured Image Block
  • New icons for Reusable Blocks and Template Parts

Gutenberg 11.4 RC is available for testing.

Whats next in Gutenberg: July and August

July and August monthly priorities.

Key project updates

Based on the scope for Site Editing projects.

Template Editor

Check out the – Site Editor Template mosaic view

Global Styling

Navigation Block & Navigation Editor

  • The team have been focused on reforming the project around the goal of removing the “experimental” status of the feature within the Gutenberg Plugin (only).
  • Held a Hallway Hangout on Tuesday to compare and contrast Navigation screens and determine next steps.
    A summary of the meeting and decisions made is available.
  • Tracking issue is being updated to focus on the tasks required to remove “experimental”.
  • Work is continuing on exploring wider architectural issues such as how to best make use of the Navigation block whilst retaining stability.
  • We’ve continued with small UI/UX fixes.

Mobile

  • Help menu option that teaches users about the block editor
  • Typography controls to manipulate the font size and line height and improved color settings

In progress:

  • Finalizing Block Picker Search
  • Embed block
  • Editor onboarding help section
  • GSS Font size, line height, colors

Components squad

At the time of the meeting there were no updates on the Pattern project.

Refactored Gallery block

The refactored Gallery block main PR from October 2020 has now finally been merged, and will be included as part of Gutenberg plugin 11.4. There is also a dev note on make core.

Task Coordination

@joen

@annezazu

  • Responding to Full Site Editing (FSE) feedback, testing FSE items, and helping amplify various efforts.
  • Working on a core editor improvement post about featured image block improvements.

@get_dave

Open Floor

@get_dave

Friendly reminder from Dave to add the most appropriate labels to PRs in GitHub, whether you’re submitting PRs or helping with triage. All efforts there make work easier for the release lead.

@paaljoachim

It would be very helpful for us who run the Core Editor Meetings to have tracking issues that are updated once a week, so we can share the project updates during the meeting. As it will also give a nice overview and it would make it easier for anyone to follow along to see the progress over time.

#core-editor, #core-editor-summary, #gutenberg, #meeting-notes, #summary