Make WordPress Core

Keyboard Shortcuts | Hide comment threads

Dev Chat Agenda for Sept 8, 2021

Here is the agenda for this week’s developer meeting to occur at Wednesday, September 8, 2021 at 08:00 PM UTC.

Blog Post Highlights and announcements

Bringing to your attention some interesting reads and some call for feedback and/or volunteers:

Components check-in and status updates

  • Check-in with each component for status updates.
  • Poll for components that need assistance.

Open Floor

Do you have something to propose for the agenda, or a specific item relevant to the usual agenda items above?

Please leave a comment, and say whether or not you’ll be in the chat, so the group can either give you the floor or bring up your topic for you accordingly.

This meeting happens in the #core channel. To join the meeting, you’ll need an account on the Making WordPress Slack.

#5-8-1, #5-9, #agenda, #core, #dev-chat

The proposal for Open Floor is to review this ticket
http://wayback.fauppsala.se:80/wayback/20210908144455/https://core.trac.wordpress.org/ticket/53784
I’ve sent a pull request there which solves the privacy issue

Thank you @fictiont, noted!

I will try to be in the chat for questions, though, but not guarantee 🙂
Anyway, it feels good if we address this problem since there are a lot of solutions around to enumerate WP users emails based on that privacy issue.

F.e. here: http://wayback.fauppsala.se:80/wayback/20210908144455/https://www.gosecure.net/blog/2021/03/16/6-ways-to-enumerate-wordpress-users/

Upgrade/Install Meeting Notes, September 7

Quiet but productive chat, only two attendees, @afragen and @francina, but here is a quick recap 🙂 Slack logs.

#51857

@afragen stress tested it but didn’t find any concerning blockers. I asked @sergeybiryukov about commit: he is going to do another round of code review tomorrow, September 8, and if everything looks good, it will be committed. The solution addresses Outcome 1 and 2 of the initial feature proposal.

Outcome 3 – Have managed updates (database migrations)

This is going into the icebox momentarily. It needs a new API to work. If anyone is interested in picking it up, join our meetings on Tuesdays, at Tuesday, September 7, 2021 at 05:00 PM UTC.

Outcome 4 – Create a unified JSON convention for requirements and dependencies.

This nine-year-old issue was revived. Worth reading through it all.

Here is @afragen TL;DR

  1. Any plugin that requires a dependency should degrade gracefully if that dependency is not present.
  2. Dependencies should have notices to install and later activate the dependency.
  3. Some notification of which plugin is a dependency of what other plugin.

There is also the potential for abuse, with plugins reporting dependencies that aren’t really dependencies.

Andy also suggested making a proof of concept plugin, instead of creating a core patch.

What say you?

Do you want to add to the conversation? Please comment on the Trac ticket (beware, comments in GH will be shown in Trac, but not the other way around, so please use Trac, thank you 🙏). We are in the “feedback, validate, outreach, test, inform, reply to questions” loop stage. Join us!

See you next week 👋

#core-auto-updates, #updater, #upgrade-install

Upgrade/Install component meeting agenda for September 07, 2021

The next meeting is scheduled on Tuesday, September 7, 2021 at 05:00 PM UTC and will take place on #core-auto-updates Slack channel.

The aim of the chat is to check the status of the [Feature project] Updates on updating the updaters.

Got something to propose for the agenda? Please leave a comment below.

See you later!

#core-auto-updates, #updater, #upgrade-install

Editor Chat Agenda: 8 September 2021

Facilitator and notetaker: @andraganescu

This is the agenda for the weekly editor chat scheduled for Wednesday, September 8 2021, 04:00 PM GMT+1.

This meeting is held in the #core-editor channel in the Making WordPress Slack.

If you are not able to attend the meeting, you are encouraged to share anything relevant for the discussion:

  • If you have an update for the main site editing projects, please feel free to share as a comment or come prepared for the meeting itself.
  • If you have anything to share for the Task Coordination section, please leave it as a comment on this post.
  • If you have anything to propose for the agenda or other specific items related to those listed above, please leave a comment below.

#agenda, #core-editor, #core-editor-agenda, #meeting

There’s the possibility I won’t make it to today’s meeting so, adding here the update from the native mobile folks:

👋 all!

🚀 Shipped

  • Block picker search.
  • Inline previews for YouTube and Twitter embeds.
  • Alignment options for embeds.
  • New experimental Gallery block.

⏳ In Progress

  • Embed block.
  • GSS Font size, line height, colors.

Personal update:

I’ve been working on enabling the global stylesheet for all themes and other minor improvements. Prepared a PR to make sure themes with theme.json load the styles fine in the customizer as well as the theme directory.

In the area of alignments: landed a PR that makes the wide control only available if the theme provides a wide size and prepared another for fixing floats (left, center, right) for blocks that are not part of a container.

CSS Chat Summary: 02 September 2021

The meeting took place here on Slack. @danfarrow facilitated and wrote up these notes.

Announcements & Housekeeping

  • @danfarrow shared a document he worked on after last week’s meeting: a CSS Chat Facilitator’s Guide
  • The document includes a facilitator schedule – anybody interested in running a future CSS Chat or CSS Triage session is very welcome to add their name!
  • @notlaura let us know that her attendance will be spottier than usual for the next couple of months, but we are lucky to have had some new attendees join the meetings recently

CSS Custom Properties (#49930)

On that encouraging note the meeting drew to a close. Thanks everyone!

#core-css, #summary

A Week in Core – September 6, 2021

Welcome back to a new issue of Week in Core. Let’s take a look at what changed on Trac between August 30 and September 6, 2021.

  • 23 commits
  • 61 contributors
  • 41 tickets created
  • 12 tickets reopened
  • 52 tickets closed

The Core team is currently working on the next point (5.8.1) and major (5.9) releases.

Ticket numbers are based on the Trac timeline for the period above. The following is a summary of commits, organized by component and/or focus.

Code changes

Build/Test Tools

  • Double escape quotation marks() for Slack “messages” – #52644
  • Clean css/dist as part of the webpack build step – #53719
  • Add missing @covers tags for Tests_Admin_IncludesComment#39265
  • Add missing @covers tags for Tests_Admin_wpCommunityEvents#39265
  • Add missing @covers tags for actions’ tests – #39265

Code Modernization

  • Code Modernization: Fix parameter name mismatches for parent/child classes in WP_List_Table::column_default()#51553
  • Apply coding standards on CSS#53866

Customize

  • Add wp-embed-responsive class to body if using widgets block editor – #53609

Documentation

  • Correct the post_submitbox_minor_actions hook description – #54045
  • Fix typo in a comment in WP_Customize_Manager::get_return_url()#53399
  • Improve documentation in wp-signup.php#41566
  • Move @since notes from the safe_style_css filter to the safecss_filter_attr() function – #53731
  • Provide a more accurate description for a few script and style functions – #54044
  • Сlarify that term_id is a valid value for the $field parameter of get_term_by()#54065

Editor

  • Update block editor packages for WordPress 5.8.1 – #54052, #52818

Media

  • Remove documentation detailing specific edge cases in the image_editor_output_format filter – #53955
  • Apply the wp_editor_set_quality filter not only when loading an image in the editor but also when saving an converted image, after the mime-type of the output image has changed – #53667
  • Media: fix showing of the “Filter Media” filds when replacing an image from the media modal – #53833

Site Health

  • Remove MySQL query cache size from the Site Health Info screen – #53845

Widgets

  • Pass correct context to get_block_categories() calls – #53757
  • Rename and soft deprecate retrieve_widgets()#53811
  • Show title and media select fields in Accessibility Mode – #53641

Props

Thanks to the 61 people who contributed to WordPress Core on Trac last week: @audrasjb (8), @hellofromTonya (5), @pbearne (4), @jrf (4), @azaozz (4), @sabernhardt (4), @desrosj (3), @zieladam (2), @walbo (2), @kevin940726 (2), @johnbillion (2), @andraganescu (2), @netweb (2), @sergeybiryukov (2), @peterwilsoncc (2), @mukesh27 (2), @circlecube (2), @zodiac1978 (1), @noisysocks (1), @antonvlasenko (1), @terraling (1), @dariak (1), @vladytimy (1), @bedas (1), @ramonopoly (1), @timothyblynjacobs (1), @mikeschroder (1), @mkaz (1), @mhuntdesign (1), @hudson-atwell (1), @mark-k (1), @alexstine (1), @Enchiridion (1), @mt8biz (1), @westonruter (1), @jayupadhyay01 (1), @joen (1), @aristath (1), @toro_unit (1), @juanmaguitar (1), @gazchap (1), @tmatsuur (1), @muhammadfaizanhaidar (1), @ankitmaru (1), @pbiron (1), @ayeshrajans (1), @hareesh-pillai (1), @oandregal (1), @gziolo (1), @ntsekouras (1), @jblz (1), @talldanwp (1), @ribaricplusplus (1), @youknowriad (1), @paaljoachim (1), @kreppar (1), @ellatrix (1), @ajlende (1), and @mamaduka (1).

Congrats and welcome to our 7 (!) new contributors of the week! @terraling, @bedas, @hudson-atwell, @Enchiridion, @juanmaguitar, @gazchap, and @muhammadfaizanhaidar ♥️

Core committers: @sergeybiryukov (8), @hellofromtonya (5), @desrosj (4), @azaozz (2), @ryelle (1), @noisysocks (1), and @peterwilsoncc (1).

#5-8-1, #5-9, #core, #week-in-core

I am honoured to give back to the WordPress community.

Awesome work!

N.B. @audrasjb There’s a typo for @peterwilsoncc in the first set of props

That’s right @costdev, probably because a committer made the typo in a commit message, so this props won’t count in general stats.

But of course I can fix it at leasst in this the Post, thanks for the heads up.

WordPress 5.9 Planning Roundup

Happy September no matter where you are in the world! Since we’re halfway through the alpha period for the next big release of WordPress, it’s time to gather all the pieces of planning into one place. This post will include all the best guesses and targets for dates, features, and squads.

This release will follow the same general cadence as the other releases this year, with a long alpha period (132 days) and a short beta period (14 days) before the release candidate phase.

Proposed WordPress 5.9 Schedule

These are my best guesses at the milestones:

MilestoneDateDays from
Alpha (trunk open for 5.9 release)June 30, 2021
Go/no go DateOctober 12, 2021104 days after Alpha
Feature freeze/Bug FixesNovember 9, 202142 days after go/no go
Beta 1November 16, 20217 days after Feature Freeze
Release Candidate 1November 30, 202114 days after Beta 1
General releaseDecember 14, 202114 days after RC1
WP5.9 Schedule

This schedule puts Beta 1 the week of a major US holiday and a few major commerce dates worldwide. It does avoid putting RC1 during that week.

Proposed WordPress 5.9 Scope

The main goal for 2021 is getting full site editing to all WordPress users. For WP5.9 the following features are in the suggested roadmap:

  • Blocks + intrinsic web design
  • Navigation menus
  • Interface for theme.json
  • Refining editing flows for block themes
  • New default theme
  • Additional design tools

There are also a few roadmap hopefuls out there.

  • Pattern insertion + creation
  • Unzip/Rollback Failsafes
  • PHPUnit Tests
  • Improved compatibility with PHP 8.0 and 8.1

Proposed WordPress 5.9 Leads

  • Release Lead: Matt Mullenweg
  • Release Coordinators:
  • Triage Lead:
  • Editor Tech:
  • Editor Design:
  • Core Tech:
  • Theme Lead:
  • Technical Writer: Jonathan Bossenger
  • Docs Lead:
  • Marketing & Comms: Josepha Haden
  • Accessibility Lead:
  • Test Lead:

How to help!

I think we will need a slightly larger release squad for this final release of the year, so I’m opening calls for volunteers. As we approach the go/no go date and get a better idea of what features will really land in the release, we’ll get more squad leads assigned.

However, there are a couple of roles we really could use some volunteers for right now:

  1. Triage Lead
  2. Release Coordinators

If you’re interested in lending a hand, please share your interest in the comments!

Props to @francina for early versions of this post, and @jeffpaul + @desrosj for wrestling calendars with me.

#5-9, #planning

Thanks Josepha, this is great news to hear!
Happy September and 5.9 release!

Here are Proposed WordPress 5.9 Schedule
Listed are awesome. Thanks

Look forward to the last release of the year. Awaiting the release of a new core theme!

I am interested/willing. Release comms, learn release coordinator, and for a big first: planned content on Learn related to the release.

Very nice to see this proposed timeline, allowing folks to plan. 👍🏻

The proposed schedule looks great to me!
I’m looking forward to 5.9 and its brand new bundled theme.
For this release, I would be happy to help on Trac tickets Triage, Docs, or Accessibility 🙌

I’ll of course dedicate some time to help on the new Bundled theme issues/tests.

I don’t have enough time to offer for any official role but I’ll be happy to coordinate between Docs lead and Docs team.

CSS Chat Agenda: September 02, 2021

The next weekly CSS meeting is today, Thursday September 02, at 21:00pm UTC in the #core-css channel in Making WordPress Slack.

There will also be a Core CSS Triage starting at 20:00pm UTC, an hour before the meeting.

Meeting Agenda

  • Welcome (21:00pm UTC)
  • Announcements & housekeeping
  • CSS Custom Properties (#49930)
  • Open floor / CSS link share

See you there!

#agenda

Editor chat summary: 1 September, 2021

This post summarizes the weekly editor chat meeting (agenda here) held in Slack. Moderated by @annezazu.

Announcements

Gutenberg 11.4 launched

Release notes coming soon after a quick fix. For now, some highlights:

  • The Gallery Block now acts as a wrapper for core Image Blocks thanks to the Gallery Block Refactor. Plugin and theme authors, please do check out out this dev note to get up to speed on backwards compatibility
  • The Featured Image block now has the option to add duotone filters so you now have even more ways to add your own style to your content.
  • Padding support was added to the Buttons Block making it easier to get the spacing just right.

5.8.1 RC launches today (Sept 1)

Based on the schedule previously shared, 5.8.1 RC will launch today with the release coming on September 8th. If you can, please help test the release.

Final day for the current FSE call for testing (Sept 1 )

It’s the last day to explore the current FSE Outreach Program call for testing. If you have time, share your thoughts! If you don’t, please help amplify by sharing with others.

Reminder: monthly block theme meeting in #themereview

A reminder was shared that there is a block theme meeting in for anyone keen to chat about what’s happening with block themes. This is a recurring monthly meeting so if you missed today’s, don’t worry!

Monthly Priorities & Key Project Updates

The overarching plan for September has not yet been shipped yet so we based today’s conversation on the July & August Plan. As a reminder to those working on these projects, async updates are both welcomed if you can’t make the meeting and needed.

Navigation Editor

For the Navigation Editor portion, @talldanwp shared a lovely update. Here are some highlights:

  • A plan has been formed for migrating from the customize API to the REST API in the navigation editor.
  • The nav editor header’s design has been refreshed.
  • Some conversation is underway around extensibility of the editor (join in if you’re interested)

Mobile

Shipping:

  • Block picker search

 Notable fixes:

  • Fixed an npm install breakage on Gutenberg’s trunk branch due to third-party dependency we were building that had an unpinned typescript dependency.

In Progress:

  • Embed block (hoping to release some inline previews in our next release)
  • GSS Font size, line height, colors

Patterns

For patterns, some context was shared amongst the core editor wranglers from @paaljoachim that the design tool overview enhancements will ultimately also trickle down to make pattern creation easier, more responsive, etc.

Styling

I’m going to reuse part of the async update from André since he’s done a ton of work there. Lots of work is underway with adding duotone support in theme.json along with a PR around enabling global styles to all themes. Expect work to continue on this path for the week ahead.

No update for the Template Editor or the Navigation Block

If anyone has any context to add around the Template Editor or the Navigation Block, feel free to chime in below in the comments.

Task Coordination

Feel free to add items to this post if you weren’t able to make the meeting.

@mikeschroder

Shipped:

  • Closed 32024 via [51677]. Thanks everyone for your help, including with the follow-up tests commit! 
  • Opened two Video Block poster related PRs (34415 and 34411).

This week, planning to investigate 33437.

@oandregal

@zieladam

@youknowriad

  • I’ve worked a bit on performance. I want to get back to some layout related work.
  • I’ve reviewed a number of PRs as well.
  • I’ve spent some time this week exploring some wild ideas for block registration (both to make easier and more universal/language independent). For the curious, the repo is here http://wayback.fauppsala.se:80/wayback/20210908144455/https://github.com/youknowriad/blocky it’s no where near ready but I’d love to learn more about your custom blocks, if you have examples or ideas about how you’d ideally write them and what use-cases would you want to see for the simplified “view” property.

@joen

@gziolo

@annezazu

  • Recapping and responding to the current call for testing for the outreach program.
  • Finalizing the next call for testing(more exploration than call for testing right now on theme switching).
  • Drafting some core editor improvement posts + assisting with an upcoming News post
  • Shipped a YouTube video all about patterns.
  • Triaging unlabeled PRs (down from over 100 to in the 20s). The unlabeled PRs that are left I am not quite sure what to do with so feel free to jump in.

Open Floor

Offer to run a Gutenberg Release for the first time. Raised by @mikeschroder.

If folks are interested, after shadowing @talldanwp (thanks again!), I would love to try running a Gutenberg release for the first time. Whenever it works best for the team is okay with me!

Next step: @priethor will coordinate since he helps wrangle the release process.

Proposed migration of E2E specs to Playwright. Raised by Bart Kalisz.

A proof concept was shared and well received thus far as part of a proposed migration to Playwright. At this point, a wider discussion needs to happen with impacted parties to ensure that folks are willing to follow the proposed changes. A few folks chimed in agreeing that a wider discussion needs to happen along with perhaps a comparison with Cypress (mentioned by @swissspidy). Depending on how things go, a Make Core post might make sense.

Next steps: Bart alerted the crew in #core-test and @annezazu will ensure that it gets discussed in the Core Dev meeting for wider attention.

Call for community ideas for FSE Outreach testing calls. Raised by @annezazu.

I’d love to start experimenting with community members sharing ideas for what to test in the outreach program. If you’d like to suggest an idea for a call for testing, know it’s very welcomed and all ideas will be weighed against current project priorities to figure out what makes the most sense to pursue. You can share ideas directly in the #fse-outreach-experiment slack channel or via DM to me! In case you’re curious about how calls for testing have been wrangled in the past, it’s typically been a combination of monthly project priorities/release priorities + my own testing/what I can make happen + conversations with contributors.

#core-editor, #core-editor-summary, #summary

WordPress 5.8.1 RC 1

WordPress 5.8.1 Release Candidate 1 (RC1) is available for testing!

Some ways you can help testing WordPress 5.8.1 RC1:

What’s in this release candidate?

5.8.1 Release Candidate 1 features 41 bug fixes on Core, as well as 20 bug fixes for the Block Editor.

The following core tickets from Trac are fixed:

  • #52818 – Ordering metaboxes broken in WP 5.7
  • #53556 – Add a new template-editing tag to the Theme API
  • #53562 – Widgets Editor in Customizer doesn’t load with E2E tests + 0ms Animations
  • #53609 – Responsive widget block embeds not showing in the customizer
  • #53616 – Registered block styles should only be rendered when the block exists on a page
  • #53641 – Can not configure image widget (and others) in widget accessability mode
  • #53654 – Menus: Hide bulk-select options when no menus exist
  • #53667 – Support wp_editor_set_quality for both loaded and saved mime_types
  • #53668 – Generated images for one file can be overwritten by another with the same name when mapping mime types for generated images
  • #53679 – The media library looks broken on mobile
  • #53680 – Correct inline documentation about IMAGETYPE_WEBP and IMG_WEBP
  • #53696 – wp_add_iframed_editor_assets_html() not checking for block editor
  • #53697 – Possible Regression – Border settings not displaying for Button Block
  • #53702 – Four css files removed between 5.7.x and 5.8 were not included in $_old_files
  • #53713 – Bounce underscore.js version in script-loader
  • #53714 – Bounce jquery.form.js version in script-loader
  • #53715 – Bounce hoverIntent.js version in script-loader
  • #53716 – The “/” missing at the end of image tag
  • #53719grunt clean:css does not clean the css/dist folder
  • #53738 – Broken loop in WP_Theme_JSON_Resolver
  • #53752 – Twenty Ten: Block patterns file causes error in child themes
  • #53757 – Widget editor calls get_block_categories() with incorrect arg type
  • #53762 – Replace the remaining references to wp.editor with wp.oldEditor
  • #53769 – Bundled themes: block-patterns.php file should use get_template_directory_uri instead of get_stylesheet_directory_uri
  • #53773 – /wp-admin/includes/ajax-actions.php file line 3006 is creating divide by zero error
  • #53777 – Bump bundled theme versions for
  • #53799 – Remove version-controlled files check from Test Old Branches workflow
  • #53803 – Customizer: Radio button on background image position selector visible on focus
  • #53820 – Build doesn’t support Docker Compose V2
  • #53827 – Increase number of media items displayed when clicking button to “Load More”
  • #53830 – Default filters try to create nonce during installation before options table exists
  • #53833 – ‘Replace image’ Media Modal is missing select fields under filter media due to css issues
  • #53877 – Menus: Selected display locations for new menus aren’t saved
  • #53898 – Duplicated 404 templates in the TemplatePanel
  • #53922Docblock in get_block_editor_settings function
  • #53932 – Media grid view doesn’t show all media elements
  • #53936 – Output of serialize_block_attributes does not match equivalent Gutenberg function
  • #53955 – Fix and improve the docs for the image_editor_output_format filter
  • #54030 – Pressing esc in Widgets Editor closes panel in customizer
  • #54036 – PclZip throwing errors on PHP 8 – previously merged patch is incomplete
  • #54052 – Block editor package updates for 5.8.1

The following block editor issues from GitHub are fixed:

  • PR33384 – Fix API docs for data reference guides
  • PR33381 – Docs: use markdown headings instead of links for API declarations
  • PR33498 – Docs: Run Prettier after updating API in documentation
  • PR33549 – Use tabs instead of spaces in block transform doc example
  • PR30617 – Fix metabox reordering
  • PR32083 – Block editor: move layout styles to document head (instead of rendering inline)
  • PR33814 – Widgets: Allow HTML tags in description
  • PR33457 – Editor: Set ‘hide_empty’ for the most used terms query
  • PR33482 – Update widget editor help links to point to the new support article
  • PR33621 – Fixed that the block is selected instead of the title when using the select all shortcut.
  • PR33699 – Writing flow: select all: remove early return for post title
  • PR33618 – Call onChangeSectionExpanded conditionally
  • PR33679 – FontSizePicker: Use number values when the initial value is a number
  • PR33739 – Fix justification for button block when selected
  • PR33771 – Add error boundaries to widget screens
  • PR33802 – Fix insertion point in Widgets editors
  • PR34280 – Default batch processor: Respect the batch endpoint’s maxItems
  • PR34314 – Fix button block focus trap after a URL has been added
  • PR34076 – Text for dropdown fields within legacy widgets in the Customizer is off centered
  • PR32935 – Add a SearchControl component and reuse accross the UI(class change in tests)

What’s next?

The dev-reviewed workflow (double committer sign-off) is now in effect when making any changes to the 5.8 branch.

As per the proposed WordPress 5.8.1 schedule, the final release is expected on Wednesday, September 8, 2021. Please note that this date can change depending on possible issues after RC1 is released. Coordination will happen in the WordPress.org Slack #5-8-release-leads channel.

A special thanks to everyone who helped test, raised issues, and helped to fix tickets. With this release candidate testing continues, so please, help test!

The 5.8.1 release is being led by @desrosj and @circlecube.

Props @webcommsat and @desrosj for peer review.

#5-8, #5-8-1, #minor-releases, #releases