Welcome back to a new issue of Week in Core. Let’s take a look at what changed on Trac between September 6 and September 13, 2021.
- 37 commits
- 30 contributors
- 40 tickets created
- 4 tickets reopened
- 25 tickets closed
As expected, WordPress 5.8.1 was released last week! Props to @desrosj and @circlecube for leading this new point release 🌟
The Core team is currently working on the next point (5.8.2) and major (5.9) releases 🛠
Ticket numbers are based on the Trac timeline for the period above. The following is a summary of commits, organized by component and/or focus.
Code changes
Administration
- Accessibility: Improve
aria-label
on network admin Themes screen – #24442
Build/Test Tools
- Fix CI for running tests on PHP 8.1 – #53945
- Add more invalid IP test cases and
@covers
to Tests_Functions_Anonymization
– #53363 - Add tests for
wpdb::_real_escape()
– #53363 - Fix “null to non-nullable” deprecation notice in
Tests_Admin_IncludesPlugin::test_get_plugin_files_folder()
– #53635
Bundled Themes
- Twenty Eleven: Set a fixed height for search form when header image is added – #40398
Code Modernization
- Fix “passing null to non-nullable” deprecation in
wpdb::_real_escape()
– #53635 - Fix “passing null to non-nullable” deprecation notice in
WP_Comment_Query::get_comment_ids()
– #53635 - Fix “passing null to non-nullable” deprecation notices in
WP_Http::normalize_cookies()
– #53635 - Fix last parameter name mismatches for parent/child classes in
Walker::start_el()
– #51553 - Fix null to non-nullable deprecation in
term_exists()
– #53635 - Fix null to non-nullable deprecation in
wp_privacy_anonymize_ip()
– #53635 - Fix null to non-nullable deprecations in
WP_Meta_Query::get_sql_for_clause()
– #53635 - Fix parameter name mismatch with parent in
WP_Customize_Custom_CSS_Setting::validate()
– #51553 - Fix parameter name mismatches for parent/child classes in
WP_Customize_Setting::sanitize()
– #51553 - Fix parameter name mismatches for parent/child classes in
WP_Customize_Setting::update()
– #51553 - Fix parameter name mismatches for parent/child classes in
WP_Image_Editor::save()
– #51553 - Fix parameter name mismatches for parent/child classes in
WP_List_Table::column_cb()
– #51553 - Fix parameter name mismatches for parent/child classes in
WP_List_Table::handle_row_actions()
– #51553 - Fix parameter name mismatches for parent/child classes in
WP_REST_Controller::prepare_item_for_response()
– #51553 - Fix parameter name mismatches for parent/child classes in
WP_Sitemaps_Provider::get_max_num_pages()
– #51553 - Fix parameter name mismatches for parent/child classes in
WP_Sitemaps_Provider::get_url_list()
– #51553 - Fix parameter name mismatches for parent/child classes in
WP_Upgrader_Skin::error()
– #51553 - Fix parameter name mismatches for parent/child classes in
WP_Widget::update()
– #51553 - Fix reserved keyword and parameter name mismatches for parent/child classes in
WP_Upgrader_Skin::feedback()
– #51553 - Fix reserved keyword and parameter name mismatches for parent/child classes in
Walker::end_el()
– #51553 - Fix reserved keyword and parameter name mismatches for parent/child classes in
Walker::start_el()
– #51553 - Improve
@since
message in WP_List_Table::column_default()
– #51553
Documentation
- Correct documentation for the
in_plugin_update_message-{$file}
filter – #40006
Editor
- Revert [51748] and [51649]. They intorduced a bug where
wp.editor
may be replaced with wp.oldEditor
in certain cases – #53762 - Editor: fix the replacement of
wp.editor
with wp.oldEditor
in the inline script outputted when enqueueing the old editor – #53762
External Libraries
- Update jQuery UI to 1.13.0-rc2 – #52163
General
- Only use
_jsonp_wp_die_handler()
for JSONP REST API requests
Site Health
- Add Intl to the list of recommended PHP extensions – #52654
- Site Health: Move the Imagick entry higher in the list of recommended PHP extensions – #52654
Users
- Introduce a
meta_input
argument for wp_insert_user()
– #41950
Widgets
Props
Thanks to the 30 people who contributed to WordPress Core on Trac last week: @hellofromTonya (26), @jrf (26), @azaozz (19), @desrosj (18), @johnbillion (15), @sergeybiryukov (15), @audrasjb (2), @david.binda (2), @sabernhardt (2), @Clorith (2), @Soean (1), @davidmosterd (1), @BinaryKitten (1), @donmhico (1), @peterwilsoncc (1), @mdawaffe (1), @get_dave (1), @grantmkin (1), @fullofcaffeine (1), @lukecavanagh (1), @josklever (1), @mukesh27 (1), @zieladam (1), @andraganescu (1), @fedepia (1), @zodiac1978 (1), @mgol (1), @JavierCasares (1), @zeo (1), and @SergeyBiryukov (1).
Congrats and welcome to our new contributor of the week: @josklever ♥️
Core committers: @hellofromtonya (26), @sergeybiryukov (6), @azaozz (3), and @johnbillion (2).
#5-8-2, #5-9, #core, #week-in-core
I’m working on how to make the Nav Editor more resilient to changes in the Navigation block.
One route I’m exploring is using Theme JSON to control the features of the Nav block. My proposal does two things that I’d like some input on:
1. opens up `theme.json` for extensibility by developers via hooks/filters.
2. allows `theme.json` to control features that are unique to particular blocks (as opposed to things that are common across all blocks such as spacing).
I’d like to hear what folks (especially those working on Global Styles) think about this.
I’ve been working on assorted things: alignments (add wide control only if theme provides wideSize, fix for floats), link color (fix for clearing the class, fix for link color in containers), cache issues for global styles (stylesheet, theme.json), and adding support for disabling text and background color controls via theme.json
Here’s a general update for the navigation editor:
http://wayback.fauppsala.se:80/wayback/20210916143909/https://github.com/WordPress/gutenberg/issues/29102#issuecomment-919886307
@get_dave, @annezazu, and myself are hosting a Hallway Hangout tomorrow @ 1600 UTC discussing Full Site Editing pathways to adoption, click for details.
I’m working on a couple minor issues, adding shortcut key to Preview Post but requires some refactoring.
The other is adding explanatory text to the Quick Inserter when used in InnerBlocks, but still needs some further questions answered to have a clear path forward.
The following comment made by a4jp . com was posted to last weeks Core Editor Chat agenda after the chat was held. Perhaps something for the Open Floor.
The inserter (add block – the line with plus mark) is missing above the top inserted block.
Toggle block inserter doesn’t help here either.
http://wayback.fauppsala.se:80/wayback/20210916143909/https://wordpress.org/support/topic/blocks-cant-be-added-at-the-top-of-pages/#post-14847846
http://wayback.fauppsala.se:80/wayback/20210916143909/https://github.com/WordPress/gutenberg/issues/22801#issuecomment-913302262
You currently have to add a block under the top inserted block then move it above the top block each time. It would be nice to get this fixed.
If the line that said add block were above the first block added it would just take one click to add new blocks, which is very nice.