Weston Ruter (@westonruter) – WordPress user profile

Member Since: May 16th, 2007
Location: Portland, OR, USA
Website: weston.ruter.net
GitHub: westonruter
Job Title: Developer Programs Engineer
Employer: Google
Find me on:

Bio

Googler working on AMP, PWA, & open web; WordPress core team; XWP alum.

Contributions Sponsored

Weston Ruter contributes 5 hours per week to the Core team.

Contribution History

Core Contributor
Core Team
Documentation Contributor
Meta Contributor
Plugin Developer
WordCamp Speaker

Activity
Plugins
Favorites

Posted a reply to Turn off Persistent Object Cache notification, on the site WordPress.org Forums:
I've implemented this as part of this pull request: https://github.com/ampproject/amp-wp/pull/6456

2 days ago
Posted a reply to Enable comments pagination only amp page, on the site WordPress.org Forums:
Note: It's probably not necessary to wrap the filters in a wp action since they…

4 days ago
Posted a reply to More amp problems, less I can do about it., on the site WordPress.org Forums:
This seems to be an issue with Jetpack and not AMP.

5 days ago
Posted a reply to Error when configuring, on the site WordPress.org Forums:
I've encountered this issue myself recently: https://github.com/ampproject/amp-toolbox-php/pull/319 The issue is coming from this code: https://github.com/ampproject/amp-wp/blob/24923a403e6c010228b143375309336509f2eda1/includes/validation/class-amp-validation-manager.php#L1686…

7 days ago
Posted a reply to Lighthouse Audit: Page does not work offline, on the site WordPress.org Forums:
Sorry I didn't get a chance to look at this until today.

2 weeks ago
Posted a reply to Removing transients from wp_options, on the site WordPress.org Forums:
Hi Thomas. The reason for the transients is to cache highlight.php's parsing of the code…

2 weeks ago
Posted a reply to Turn off Persistent Object Cache notification, on the site WordPress.org Forums:
Even though page caching like Varnish does reduce the need for persistent object caching, it…

2 weeks ago
Committed [2591705] to Plugins Trac:
Tagging 2.1.4

3 weeks ago
Committed [2591704] to Plugins Trac:
Committing 2.1.4 to trunk

3 weeks ago
Posted a reply to Top bar and nav bar…, on the site WordPress.org Forums:
I believe you're referring to the theme_color: https://developer.mozilla.org/en-US/docs/Web/Manifest/theme_color You can see the logic for obtaining…

3 weeks ago
Posted a reply to CPU usage reached 100%., on the site WordPress.org Forums:
If you haven't already, please make sure that you have a page caching plugin active.…

4 weeks ago
Posted a reply to Any way to use Spoken Word with audio recording of a real person?, on the site WordPress.org Forums:
I did that before in a manual process: https://github.com/westonruter/html5-audio-read-along I did try some automatic linking…

4 weeks ago
Posted a reply to CSS syntax error in tag ‘style amp-custom’, on the site WordPress.org Forums:
We're working on a fix for this. See https://github.com/ampproject/amp-wp/issues/6557

4 weeks ago
Posted a reply to CSS syntax error in tag ‘style amp-custom’., on the site WordPress.org Forums:
We're working on a fix for this. See https://github.com/ampproject/amp-wp/issues/6557

4 weeks ago
Posted a reply to CSS syntax error in tag ‘style amp-custom’, on the site WordPress.org Forums:
Yeah, the AMP Validator seems stale. It's better to use the AMP Playground instead.

1 month ago
Posted a reply to CSS syntax error in tag ‘style amp-custom’, on the site WordPress.org Forums:
@milindmore22 I wonder if this is a bug in the AMP validator spec? Given this…

1 month ago
Posted a reply to amp-iframe not allowing http on localhost, on the site WordPress.org Forums:
The component JS allows localhost, but the validator does not. That's the difference. The AMP…

1 month ago
Posted a reply to amp-iframe not allowing http on localhost, on the site WordPress.org Forums:
@jcedwards76 Since it's a validation error, the AMP plugin removes it. What you can do…

1 month ago
Posted a reply to Nothing has changed after installation, on the site WordPress.org Forums:
The manifest is output in the head here: https://github.com/GoogleChromeLabs/pwa-wp/blob/4aa2b8a791afd746cc8a02f5df9f896cb52c0f34/wp-includes/class-wp-web-app-manifest.php#L62 The web app manifest is obtained…

1 month ago
Posted a reply to Add app shortcuts, on the site WordPress.org Forums:
Hey there. This is possible today since all that seems required is modifying the Web…

1 month ago
Posted a reply to Homepage Shows “Installing service worker…”, on the site WordPress.org Forums:
That code is specifically coming from the AMP plugin via the amp-install-serviceworker component. Specifically, this…

1 month ago
Posted a reply to Upload PWA to iStore and Google Play, on the site WordPress.org Forums:
As I understand, no app stores don't facilitate PWA's being uploaded as-is, except perhaps Microsoft…

1 month ago
Posted a reply to AMP plugins not working using php8, on the site WordPress.org Forums:
I've merged the change that we believe will fix your issue. You can test by…

2 months ago
Posted a reply to AMP plugins not working using php8, on the site WordPress.org Forums:
@indoloto Do you by chance have a persistent object caching plugin active? I'm wondering if…

2 months ago
Posted a reply to AMP plugins not working using php8, on the site WordPress.org Forums:
@indoloto Thanks a lot for providing the helpful error message and stack trace. I've opened…

2 months ago
Posted a reply to Nothing has changed after installation, on the site WordPress.org Forums:
The request to https://edieta.org/wp.serviceworker is not returning with JS code, however. It's returning with an…

2 months ago
Posted a reply to Nothing has changed after installation, on the site WordPress.org Forums:
Did you deactivate the plugin? I don't see it running.

2 months ago
Posted a reply to Redirect Loop if url parameter has multiple spaces, on the site WordPress.org Forums:
I'll resolve this topic since we'll now track it in GitHub.

2 months ago
Posted a reply to Error: Failed to construct ‘URL’: Invalid URL, on the site WordPress.org Forums:
Yes: https://github.com/google/site-kit-wp/issues/3752#issuecomment-887685802 (I won't add further replies to the forum topic to avoid duplication.)

2 months ago
Posted a reply to Redirect Loop if url parameter has multiple spaces, on the site WordPress.org Forums:
@rolandfarkas What template mode are you using? If transitional or reader, do you also have…

2 months ago
Posted a reply to URL redirected to “noamp=available”, on the site WordPress.org Forums:
@milindmore22 This may be because there was invalid markup that got marked as "kept". In…

2 months ago
Posted a reply to Preload AMP runtime, on the site WordPress.org Forums:
You can ignore that. It's obsolete. See https://github.com/ampproject/amp-toolbox/issues/1255

2 months ago
Posted a reply to Error: Failed to construct ‘URL’: Invalid URL, on the site WordPress.org Forums:
Disconnecting Analytics did stop the error from happening. However, once I reconnected Analytics then the…

2 months ago
Posted a reply to Error: Failed to construct ‘URL’: Invalid URL, on the site WordPress.org Forums:
How do I deactivate the PageSpeed Insights module? Nevertheless, in the stack trace there is…

2 months ago
Posted a reply to Lighthouse Errors, on the site WordPress.org Forums:
For the maskable icon, please see this issue: https://github.com/GoogleChromeLabs/pwa-wp/issues/304 There is some PHP code you…

2 months ago
Posted a reply to Lighthouse Errors, on the site WordPress.org Forums:
The script in question is an inline script, not an external one. So you'd need…

2 months ago
Posted a reply to Lighthouse Errors, on the site WordPress.org Forums:
I recommend excluding scripts that include wp.serviceworker.

2 months ago
Posted a reply to [PWA] Lighthouse Errors, on the site WordPress.org Forums:
Hummm. I’m seeing the same thing. Nevertheless, the service worker is installed and I can…

2 months ago
Posted a reply to Error: Failed to construct ‘URL’: Invalid URL, on the site WordPress.org Forums:
Site Health info submitted via form.

2 months ago
Posted a reply to Error: Failed to construct ‘URL’: Invalid URL, on the site WordPress.org Forums:
I also enabled Troubleshooting mode and enabled only Site Kit and I still got the…

2 months ago
Created a topic, Error: Failed to construct ‘URL’: Invalid URL, on the site WordPress.org Forums:
I just tried accessing the Site Kit dashboard after up…

2 months ago
Wrote a comment on the post What’s new in Gutenberg 11.1.0? (21 July), on the site Make WordPress Core:
Admin panel available as PWA. (33102, 33310) For PWA, I'm going to be working on…

2 months ago
Posted a reply to How to not lazy load the first featured image, on the site WordPress.org Forums:
Relatedly, this is an issue with WordPress Core as well: https://make.wordpress.org/core/2021/07/15/refining-wordpress-cores-lazy-loading-implementation/ Assuming that AMP Optimizer…

2 months ago
Posted a reply to PWA Statistics, on the site WordPress.org Forums:
You could listen for the appinstalled event for installations: https://web.dev/customize-install/#detect-install For active users, you could…

2 months ago
Posted a reply to Can’t get it to work, on the site WordPress.org Forums:
Add to homescreen is not a PWA capability that iOS provides, unfortunately. See https://caniuse.com/web-app-manifest This…

2 months ago
Posted a reply to Plugin duplicates last characters of every word, on the site WordPress.org Forums:
The problem in highlight.php was fixed and a pull request to update that dependency has…

2 months ago
Committed [2557184] to Plugins Trac:
Tagging 2.1.3

3 months ago
Committed [2557183] to Plugins Trac:
Committing 2.1.3 to trunk

3 months ago
Posted a reply to Header and javascript and plugins not working in amp, on the site WordPress.org Forums:
Yeah, this file doesn't need to be executable. It needs to be writable so that…

3 months ago
Posted a reply to CSS syntax error in tag ‘style amp-custom’., on the site WordPress.org Forums:
Actually, instead of using https://validator.ampproject.org I recommend using https://playground.amp.dev/ Use the Import functionality. I can…

3 months ago