Weston Ruter (@westonruter) – WordPress user profile

Member Since: May 16th, 2007
Location: Portland, OR, USA
Website: weston.ruter.net
GitHub: westonruter
Job Title: Developer Programs Engineer
Employer: Google
Find me on:

Bio

Googler working on AMP, PWA, & open web; WordPress core team; XWP alum.

Contributions Sponsored

Weston Ruter contributes 5 hours per week to the Core team.

Contribution History

Core Contributor
Core Team
Documentation Contributor
Meta Contributor
Plugin Developer
WordCamp Speaker

Activity
Plugins
Favorites

Posted a reply to How to Disable AMP Versioning on a Specific Post, on the site WordPress.org Forums:
@armavitadigital Please open a new support topic. In any case, the screenshot I provided above…

15 hours ago
Posted a reply to Only amp-boilerplate and amp-custom ‘style’ tags are allowed ( AMP WORDPRESS ), on the site WordPress.org Forums:
The validation errors are coming from markup like: <style>img.lazy{min-height:1px}</style> and: <script>window.w3tc_lazyload=1,window.lazyLoadOptions={elements_selector:".lazy",callback_loaded:function(t){var e;try{e=new CustomEvent("w3tc_lazyload_loaded",{detail:{e:t}})}catch(a){(e=document.createEvent("CustomEvent")).initCustomEvent("w3tc_lazyload_loaded",!1,!1,{e:t})}window.dispatchEvent(e)}}</script><script async src="https://www.bestforexar.com/wp-content/plugins/w3-total-cache/pub/js/lazyload.min.js"></script>…

21 hours ago
Posted a reply to No line breaks, on the site WordPress.org Forums:
OK, thanks. I've filed an issue to make the plugin more resilient to such theme…

23 hours ago
Posted a reply to No line breaks, on the site WordPress.org Forums:
What plugin is the source of the above code?

1 day ago
Posted a reply to No line breaks, on the site WordPress.org Forums:
I can see the expected line breaks when I look at the HTML source: <pre…

2 days ago
Posted a reply to No line breaks, on the site WordPress.org Forums:
Please share the URL where the issue can be seen.

2 days ago
Posted a reply to Suitable for template specific PWA/SW?, on the site WordPress.org Forums:
How did you opt-in to navigation caching? Perhaps that could be an argument when calling…

1 week ago
Wrote a comment on the post Implementing a Webfonts API in WordPress Core, on the site Make WordPress Core:
Great to see! Question: Why include “webfont” in the API instead of just “font”? Isn't…

1 week ago
Posted a reply to No AMP Output, on the site WordPress.org Forums:
Great to hear that plugin suppression is working as intended! (It would indeed be great…

1 week ago
Posted a reply to “Redirect mobile visitors to AMP” destroys load time, on the site WordPress.org Forums:
I wonder if we should default to doing server-side redirection instead of client-side redirection. While…

1 week ago
Posted a reply to How to Disable AMP Versioning on a Specific Post, on the site WordPress.org Forums:
That's not the toggle I'm referring to. This is the one:

2 weeks ago
Posted a reply to How to Disable AMP Versioning on a Specific Post, on the site WordPress.org Forums:
There is an "Enable AMP" toggle that shows up in the publish metabox in the…

2 weeks ago
Posted a reply to Suitable for template specific PWA/SW?, on the site WordPress.org Forums:
How many paths are you talking about here? While the regex may be complex, you…

2 weeks ago
Committed [2602614] to Plugins Trac:
Bump tested up to

2 weeks ago
Committed [2602609] to Plugins Trac:
Bump tested up to

2 weeks ago
Posted a reply to Suitable for template specific PWA/SW?, on the site WordPress.org Forums:
It sounds like what you need to do is add a route for /resources/<post-id> which…

2 weeks ago
Posted a reply to Suitable for template specific PWA/SW?, on the site WordPress.org Forums:
The plugin provides a PHP abstraction for the Workbox JS API, while also allowing you…

2 weeks ago
Posted a reply to Turn off Persistent Object Cache notification, on the site WordPress.org Forums:
I've implemented this as part of this pull request: https://github.com/ampproject/amp-wp/pull/6456

3 weeks ago
Posted a reply to Enable comments pagination only amp page, on the site WordPress.org Forums:
Note: It's probably not necessary to wrap the filters in a wp action since they…

3 weeks ago
Posted a reply to More amp problems, less I can do about it., on the site WordPress.org Forums:
This seems to be an issue with Jetpack and not AMP.

3 weeks ago
Posted a reply to Error when configuring, on the site WordPress.org Forums:
I've encountered this issue myself recently: https://github.com/ampproject/amp-toolbox-php/pull/319 The issue is coming from this code: https://github.com/ampproject/amp-wp/blob/24923a403e6c010228b143375309336509f2eda1/includes/validation/class-amp-validation-manager.php#L1686…

3 weeks ago
Posted a reply to Lighthouse Audit: Page does not work offline, on the site WordPress.org Forums:
Sorry I didn't get a chance to look at this until today.

4 weeks ago
Posted a reply to Removing transients from wp_options, on the site WordPress.org Forums:
Hi Thomas. The reason for the transients is to cache highlight.php's parsing of the code…

4 weeks ago
Posted a reply to Turn off Persistent Object Cache notification, on the site WordPress.org Forums:
Even though page caching like Varnish does reduce the need for persistent object caching, it…

4 weeks ago
Committed [2591705] to Plugins Trac:
Tagging 2.1.4

1 month ago
Committed [2591704] to Plugins Trac:
Committing 2.1.4 to trunk

1 month ago
Posted a reply to Top bar and nav bar…, on the site WordPress.org Forums:
I believe you're referring to the theme_color: https://developer.mozilla.org/en-US/docs/Web/Manifest/theme_color You can see the logic for obtaining…

1 month ago
Posted a reply to CPU usage reached 100%., on the site WordPress.org Forums:
If you haven't already, please make sure that you have a page caching plugin active.…

1 month ago
Posted a reply to Any way to use Spoken Word with audio recording of a real person?, on the site WordPress.org Forums:
I did that before in a manual process: https://github.com/westonruter/html5-audio-read-along I did try some automatic linking…

1 month ago
Posted a reply to CSS syntax error in tag ‘style amp-custom’, on the site WordPress.org Forums:
We're working on a fix for this. See https://github.com/ampproject/amp-wp/issues/6557

1 month ago
Posted a reply to CSS syntax error in tag ‘style amp-custom’., on the site WordPress.org Forums:
We're working on a fix for this. See https://github.com/ampproject/amp-wp/issues/6557

1 month ago
Posted a reply to CSS syntax error in tag ‘style amp-custom’, on the site WordPress.org Forums:
Yeah, the AMP Validator seems stale. It's better to use the AMP Playground instead.

2 months ago
Posted a reply to CSS syntax error in tag ‘style amp-custom’, on the site WordPress.org Forums:
@milindmore22 I wonder if this is a bug in the AMP validator spec? Given this…

2 months ago
Posted a reply to amp-iframe not allowing http on localhost, on the site WordPress.org Forums:
The component JS allows localhost, but the validator does not. That's the difference. The AMP…

2 months ago
Posted a reply to amp-iframe not allowing http on localhost, on the site WordPress.org Forums:
@jcedwards76 Since it's a validation error, the AMP plugin removes it. What you can do…

2 months ago
Posted a reply to Nothing has changed after installation, on the site WordPress.org Forums:
The manifest is output in the head here: https://github.com/GoogleChromeLabs/pwa-wp/blob/4aa2b8a791afd746cc8a02f5df9f896cb52c0f34/wp-includes/class-wp-web-app-manifest.php#L62 The web app manifest is obtained…

2 months ago
Posted a reply to Add app shortcuts, on the site WordPress.org Forums:
Hey there. This is possible today since all that seems required is modifying the Web…

2 months ago
Posted a reply to Homepage Shows “Installing service worker…”, on the site WordPress.org Forums:
That code is specifically coming from the AMP plugin via the amp-install-serviceworker component. Specifically, this…

2 months ago
Posted a reply to Upload PWA to iStore and Google Play, on the site WordPress.org Forums:
As I understand, no app stores don't facilitate PWA's being uploaded as-is, except perhaps Microsoft…

2 months ago
Posted a reply to AMP plugins not working using php8, on the site WordPress.org Forums:
I've merged the change that we believe will fix your issue. You can test by…

2 months ago
Posted a reply to AMP plugins not working using php8, on the site WordPress.org Forums:
@indoloto Do you by chance have a persistent object caching plugin active? I'm wondering if…

2 months ago
Posted a reply to AMP plugins not working using php8, on the site WordPress.org Forums:
@indoloto Thanks a lot for providing the helpful error message and stack trace. I've opened…

2 months ago
Posted a reply to Nothing has changed after installation, on the site WordPress.org Forums:
The request to https://edieta.org/wp.serviceworker is not returning with JS code, however. It's returning with an…

2 months ago
Posted a reply to Nothing has changed after installation, on the site WordPress.org Forums:
Did you deactivate the plugin? I don't see it running.

2 months ago
Posted a reply to Redirect Loop if url parameter has multiple spaces, on the site WordPress.org Forums:
I'll resolve this topic since we'll now track it in GitHub.

2 months ago
Posted a reply to Error: Failed to construct ‘URL’: Invalid URL, on the site WordPress.org Forums:
Yes: https://github.com/google/site-kit-wp/issues/3752#issuecomment-887685802 (I won't add further replies to the forum topic to avoid duplication.)

2 months ago
Posted a reply to Redirect Loop if url parameter has multiple spaces, on the site WordPress.org Forums:
@rolandfarkas What template mode are you using? If transitional or reader, do you also have…

2 months ago
Posted a reply to URL redirected to “noamp=available”, on the site WordPress.org Forums:
@milindmore22 This may be because there was invalid markup that got marked as "kept". In…

2 months ago
Posted a reply to Preload AMP runtime, on the site WordPress.org Forums:
You can ignore that. It's obsolete. See https://github.com/ampproject/amp-toolbox/issues/1255

2 months ago
Posted a reply to Error: Failed to construct ‘URL’: Invalid URL, on the site WordPress.org Forums:
Disconnecting Analytics did stop the error from happening. However, once I reconnected Analytics then the…

2 months ago