Size Change: +1.43 kB (0%)

Total Size: 1.05 MB

_{compressed-size-action}

It needs to be investigated. It should be an easy fix. We need to add a missing import statement:

import { store as editorStore } from '@wordpress/editor';

Also, I know some of the commits cherry picked here were not marked with the label or appropriate milestone. My reasoning for including the first 4 commits in the list above was to avoid some problematic merge conflicts in the other commits that followed these. It may result in a few more packages being updated than necessary for the release, but it will make backporting any PRs with README updates much easier during 5.8.x.

Adding also these two Reusable block PRs
Add Convert to Regular Blocks button to ellipsis Dropdown
#32310
and
perhaps also: #31109 (comment)

It needs to be investigated. It should be an easy fix. We need to add a missing import statement

Looks like #30617 depends on #34170, and the latter isn't included in this PR. Adding the missing import would help, but the argument in the calls to controls.dispatch and controls.select might also need to be changed back to the editorStore.name style. I'm not 100% sure though, @gziolo would know better.

It needs to be investigated. It should be an easy fix. We need to add a missing import statement

Looks like #30617 depends on #34170, and the latter isn't included in this PR. Adding the missing import would help, but the argument in the calls to controls.dispatch and controls.select might also need to be changed back to the editorStore.name style. I'm not 100% sure though, @gziolo would know better.

The simpler way would be to access the name of the story through the imported object so we don't have to bring more unrelated code from #34170:

import { store as editorStore } from '@wordpress/editor';

controls.select( edtiorStore.name ).selector();

Also, I know some of the commits cherry picked here were not marked with the label or appropriate milestone. My reasoning for including the first 4 commits in the list above was to avoid some problematic merge conflicts in the other commits that followed these

That's a good strategy. I was initially surprised seeing some of PRs on the list, but it all makes sense 👍🏻

The simpler way would be to access the name of the story through the imported object so we don't have to bring more unrelated code from #34170:

Yep, that's what I was suggesting 😄

Adding also these two Reusable block PRs
Add Convert to Regular Blocks button to ellipsis Dropdown
#32310
and
perhaps also: #31109 (comment)

In my opinion, both of these feel like they are bug fixes by way of enhancement/refinement and I think I'm more comfortable waiting until 5.9 to include these. If a few Gutenberg leads feel that this is important and low risk enough to include, I'm happy to reconsider.

@talldan @gziolo would either of you be able to perform a partial cherry pick of the needed code? It's not clear to me where those imports would need to take place.

@desrosj, any idea why some (or even all) CI jobs run twice when targeting WP release branches?

I added two commits that should make static analysis CI jobs pass.

Thanks!

@desrosj, any idea why some (or even all) CI jobs run twice when targeting WP release branches?

Ah that is my fault. They are running twice because they are configured to happen on pull_request, and push events to trunk, release/**, or wp/** branches, and I named my branch wp/5.8.1-fixes.

Looks like the performance tests are failing, but the failing test is a timeout. I've restarted it.

Just noting that the failing end-to-end tests were run on the push event. The ones running for this pull request are passing, so it should be fine to merge.